Re: [PATCH v3 1/4] net: phy: dp83867: Add documentation for optional impedance control

2016-10-12 Thread Mugunthan V N
On Monday 10 October 2016 06:48 PM, Rob Herring wrote:
> On Thu, Oct 06, 2016 at 10:43:52AM +0530, Mugunthan V N wrote:
>> Add documention of ti,impedance-control which can be used to
> 
> Needs updating.

Oops, will update this in next version.

> 
>> correct MAC impedance mismatch using phy extended registers.
>>
>> Signed-off-by: Mugunthan V N 
>> ---
>>  Documentation/devicetree/bindings/net/ti,dp83867.txt | 12 
>>  1 file changed, 12 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/ti,dp83867.txt 
>> b/Documentation/devicetree/bindings/net/ti,dp83867.txt
>> index 5d21141..85bf945 100644
>> --- a/Documentation/devicetree/bindings/net/ti,dp83867.txt
>> +++ b/Documentation/devicetree/bindings/net/ti,dp83867.txt
>> @@ -9,6 +9,18 @@ Required properties:
>>  - ti,fifo-depth - Transmitt FIFO depth- see dt-bindings/net/ti-dp83867.h
>>  for applicable values
>>  
>> +Optional property:
>> +- ti,min-output-impedance - MAC Interface Impedance control to set
>> +the programmable output impedance to
>> +minimum value (35 ohms).
>> +- ti,max-output-impedance - MAC Interface Impedance control to set
>> +the programmable output impedance to
>> +maximum value (70 ohms).
> 
> Define what are valid range of values for these.

The values are already mentioned in documentation as 35/70 ohms.
Are you mentioning about the register values?

Regards
Mugunthan V N


Re: [PATCH v3 1/4] net: phy: dp83867: Add documentation for optional impedance control

2016-10-12 Thread Mugunthan V N
On Monday 10 October 2016 06:48 PM, Rob Herring wrote:
> On Thu, Oct 06, 2016 at 10:43:52AM +0530, Mugunthan V N wrote:
>> Add documention of ti,impedance-control which can be used to
> 
> Needs updating.

Oops, will update this in next version.

> 
>> correct MAC impedance mismatch using phy extended registers.
>>
>> Signed-off-by: Mugunthan V N 
>> ---
>>  Documentation/devicetree/bindings/net/ti,dp83867.txt | 12 
>>  1 file changed, 12 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/ti,dp83867.txt 
>> b/Documentation/devicetree/bindings/net/ti,dp83867.txt
>> index 5d21141..85bf945 100644
>> --- a/Documentation/devicetree/bindings/net/ti,dp83867.txt
>> +++ b/Documentation/devicetree/bindings/net/ti,dp83867.txt
>> @@ -9,6 +9,18 @@ Required properties:
>>  - ti,fifo-depth - Transmitt FIFO depth- see dt-bindings/net/ti-dp83867.h
>>  for applicable values
>>  
>> +Optional property:
>> +- ti,min-output-impedance - MAC Interface Impedance control to set
>> +the programmable output impedance to
>> +minimum value (35 ohms).
>> +- ti,max-output-impedance - MAC Interface Impedance control to set
>> +the programmable output impedance to
>> +maximum value (70 ohms).
> 
> Define what are valid range of values for these.

The values are already mentioned in documentation as 35/70 ohms.
Are you mentioning about the register values?

Regards
Mugunthan V N


Re: [PATCH v3 1/4] net: phy: dp83867: Add documentation for optional impedance control

2016-10-10 Thread Rob Herring
On Thu, Oct 06, 2016 at 10:43:52AM +0530, Mugunthan V N wrote:
> Add documention of ti,impedance-control which can be used to

Needs updating.

> correct MAC impedance mismatch using phy extended registers.
> 
> Signed-off-by: Mugunthan V N 
> ---
>  Documentation/devicetree/bindings/net/ti,dp83867.txt | 12 
>  1 file changed, 12 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/ti,dp83867.txt 
> b/Documentation/devicetree/bindings/net/ti,dp83867.txt
> index 5d21141..85bf945 100644
> --- a/Documentation/devicetree/bindings/net/ti,dp83867.txt
> +++ b/Documentation/devicetree/bindings/net/ti,dp83867.txt
> @@ -9,6 +9,18 @@ Required properties:
>   - ti,fifo-depth - Transmitt FIFO depth- see dt-bindings/net/ti-dp83867.h
>   for applicable values
>  
> +Optional property:
> + - ti,min-output-impedance - MAC Interface Impedance control to set
> + the programmable output impedance to
> + minimum value (35 ohms).
> + - ti,max-output-impedance - MAC Interface Impedance control to set
> + the programmable output impedance to
> + maximum value (70 ohms).

Define what are valid range of values for these.

> +
> +Note: ti,min-output-impedance and ti,max-output-impedance are mutually
> +  exclusive. When both properties are present ti,max-output-impedance
> +  takes precedence.
> +
>  Default child nodes are standard Ethernet PHY device
>  nodes as described in Documentation/devicetree/bindings/net/phy.txt
>  
> -- 
> 2.10.0.372.g6fe1b14
> 


Re: [PATCH v3 1/4] net: phy: dp83867: Add documentation for optional impedance control

2016-10-10 Thread Rob Herring
On Thu, Oct 06, 2016 at 10:43:52AM +0530, Mugunthan V N wrote:
> Add documention of ti,impedance-control which can be used to

Needs updating.

> correct MAC impedance mismatch using phy extended registers.
> 
> Signed-off-by: Mugunthan V N 
> ---
>  Documentation/devicetree/bindings/net/ti,dp83867.txt | 12 
>  1 file changed, 12 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/ti,dp83867.txt 
> b/Documentation/devicetree/bindings/net/ti,dp83867.txt
> index 5d21141..85bf945 100644
> --- a/Documentation/devicetree/bindings/net/ti,dp83867.txt
> +++ b/Documentation/devicetree/bindings/net/ti,dp83867.txt
> @@ -9,6 +9,18 @@ Required properties:
>   - ti,fifo-depth - Transmitt FIFO depth- see dt-bindings/net/ti-dp83867.h
>   for applicable values
>  
> +Optional property:
> + - ti,min-output-impedance - MAC Interface Impedance control to set
> + the programmable output impedance to
> + minimum value (35 ohms).
> + - ti,max-output-impedance - MAC Interface Impedance control to set
> + the programmable output impedance to
> + maximum value (70 ohms).

Define what are valid range of values for these.

> +
> +Note: ti,min-output-impedance and ti,max-output-impedance are mutually
> +  exclusive. When both properties are present ti,max-output-impedance
> +  takes precedence.
> +
>  Default child nodes are standard Ethernet PHY device
>  nodes as described in Documentation/devicetree/bindings/net/phy.txt
>  
> -- 
> 2.10.0.372.g6fe1b14
>