RE: [PATCH v3 10/11] arm64: dts: layerscape: Add PCIe EP node for ls1088a
> -Original Message-
> From: Andrew Murray
> Sent: 2019年9月12日 21:02
> To: Xiaowei Bao
> Cc: robh...@kernel.org; mark.rutl...@arm.com; shawn...@kernel.org; Leo
> Li ; kis...@ti.com; lorenzo.pieral...@arm.com; M.h.
> Lian ; Mingkai Hu ; Roy
> Zang ; jingooh...@gmail.com;
> gustavo.pimen...@synopsys.com; linux-...@vger.kernel.org;
> devicet...@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-arm-ker...@lists.infradead.org; linuxppc-...@lists.ozlabs.org;
> a...@arndb.de; gre...@linuxfoundation.org; Z.q. Hou
>
> Subject: Re: [PATCH v3 10/11] arm64: dts: layerscape: Add PCIe EP node for
> ls1088a
>
> On Tue, Sep 03, 2019 at 02:01:32AM +, Xiaowei Bao wrote:
> >
> >
> > > -Original Message-
> > > From: Andrew Murray
> > > Sent: 2019年9月2日 21:06
> > > To: Xiaowei Bao
> > > Cc: robh...@kernel.org; mark.rutl...@arm.com; shawn...@kernel.org;
> > > Leo Li ; kis...@ti.com; lorenzo.pieral...@arm.com;
> M.h.
> > > Lian ; Mingkai Hu ; Roy
> > > Zang ; jingooh...@gmail.com;
> > > gustavo.pimen...@synopsys.com; linux-...@vger.kernel.org;
> > > devicet...@vger.kernel.org; linux-kernel@vger.kernel.org;
> > > linux-arm-ker...@lists.infradead.org; linuxppc-...@lists.ozlabs.org;
> > > a...@arndb.de; gre...@linuxfoundation.org; Z.q. Hou
> > >
> > > Subject: Re: [PATCH v3 10/11] arm64: dts: layerscape: Add PCIe EP
> > > node for ls1088a
> > >
> > > On Mon, Sep 02, 2019 at 11:17:15AM +0800, Xiaowei Bao wrote:
> > > > Add PCIe EP node for ls1088a to support EP mode.
> > > >
> > > > Signed-off-by: Xiaowei Bao
> > > > ---
> > > > v2:
> > > > - Remove the pf-offset proparty.
> > > > v3:
> > > > - No change.
> > > >
> > > > arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 31
> > > ++
> > > > 1 file changed, 31 insertions(+)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > > b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > > > index c676d07..da246ab 100644
> > > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > > > @@ -483,6 +483,17 @@
> > > > status = "disabled";
> > > > };
> > > >
> > > > + pcie_ep@340 {
> > > > + compatible =
> > > > "fsl,ls1088a-pcie-ep","fsl,ls-pcie-ep";
> > >
> > > Here you specify a fallback "fsl,ls-pcie-ep" that is removed by this
> > > series.
> > >
> > > Besides that, this looks OK.
> >
> > As explained, the "fsl,ls-pcie-ep" is needed, due to the u-boot will
> > fixup the status property base on this compatible, I think we reserve
> > this compatible is helpfully, if delate this compatible, I have to modify
> > the
> code of bootloader.
>
> I assume you mean that u-boot fixes up "fsl,ls-pcie-ep" *only* for ls1046a
> devices?
No, all Layerscape platform of NXP.
>
> Thanks,
>
> Andrew Murray
>
> >
> > Thanks
> > XIaowei
> >
> > >
> > > Thanks,
> > >
> > > Andrew Murray
> > >
> > > > + reg = <0x00 0x0340 0x0 0x0010
> > > > + 0x20 0x 0x8 0x>;
> > > > + reg-names = "regs", "addr_space";
> > > > + num-ib-windows = <24>;
> > > > + num-ob-windows = <128>;
> > > > + max-functions = /bits/ 8 <2>;
> > > > + status = "disabled";
> > > > + };
> > > > +
> > > > pcie@350 {
> > > > compatible = "fsl,ls1088a-pcie";
> > > > reg = <0x00 0x0350 0x0 0x0010 /*
> > > > controller
> > > registers */
> > > > @@ -508,6 +519,16 @@
> > > > status = "disabled";
> > > > };
> > > >
> > > > + pcie_ep@350 {
> > > > + compatible =
> > > > "fsl,ls1088a-pcie-ep","fsl,ls-pcie-ep
Re: [PATCH v3 10/11] arm64: dts: layerscape: Add PCIe EP node for ls1088a
On Tue, Sep 03, 2019 at 02:01:32AM +, Xiaowei Bao wrote:
>
>
> > -Original Message-
> > From: Andrew Murray
> > Sent: 2019年9月2日 21:06
> > To: Xiaowei Bao
> > Cc: robh...@kernel.org; mark.rutl...@arm.com; shawn...@kernel.org; Leo
> > Li ; kis...@ti.com; lorenzo.pieral...@arm.com; M.h.
> > Lian ; Mingkai Hu ; Roy
> > Zang ; jingooh...@gmail.com;
> > gustavo.pimen...@synopsys.com; linux-...@vger.kernel.org;
> > devicet...@vger.kernel.org; linux-kernel@vger.kernel.org;
> > linux-arm-ker...@lists.infradead.org; linuxppc-...@lists.ozlabs.org;
> > a...@arndb.de; gre...@linuxfoundation.org; Z.q. Hou
> >
> > Subject: Re: [PATCH v3 10/11] arm64: dts: layerscape: Add PCIe EP node for
> > ls1088a
> >
> > On Mon, Sep 02, 2019 at 11:17:15AM +0800, Xiaowei Bao wrote:
> > > Add PCIe EP node for ls1088a to support EP mode.
> > >
> > > Signed-off-by: Xiaowei Bao
> > > ---
> > > v2:
> > > - Remove the pf-offset proparty.
> > > v3:
> > > - No change.
> > >
> > > arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 31
> > ++
> > > 1 file changed, 31 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > > index c676d07..da246ab 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > > @@ -483,6 +483,17 @@
> > > status = "disabled";
> > > };
> > >
> > > + pcie_ep@340 {
> > > + compatible = "fsl,ls1088a-pcie-ep","fsl,ls-pcie-ep";
> >
> > Here you specify a fallback "fsl,ls-pcie-ep" that is removed by this series.
> >
> > Besides that, this looks OK.
>
> As explained, the "fsl,ls-pcie-ep" is needed, due to the u-boot will fixup
> the status
> property base on this compatible, I think we reserve this compatible is
> helpfully,
> if delate this compatible, I have to modify the code of bootloader.
I assume you mean that u-boot fixes up "fsl,ls-pcie-ep" *only* for ls1046a
devices?
Thanks,
Andrew Murray
>
> Thanks
> XIaowei
>
> >
> > Thanks,
> >
> > Andrew Murray
> >
> > > + reg = <0x00 0x0340 0x0 0x0010
> > > +0x20 0x 0x8 0x>;
> > > + reg-names = "regs", "addr_space";
> > > + num-ib-windows = <24>;
> > > + num-ob-windows = <128>;
> > > + max-functions = /bits/ 8 <2>;
> > > + status = "disabled";
> > > + };
> > > +
> > > pcie@350 {
> > > compatible = "fsl,ls1088a-pcie";
> > > reg = <0x00 0x0350 0x0 0x0010 /* controller
> > registers */
> > > @@ -508,6 +519,16 @@
> > > status = "disabled";
> > > };
> > >
> > > + pcie_ep@350 {
> > > + compatible = "fsl,ls1088a-pcie-ep","fsl,ls-pcie-ep";
> > > + reg = <0x00 0x0350 0x0 0x0010
> > > +0x28 0x 0x8 0x>;
> > > + reg-names = "regs", "addr_space";
> > > + num-ib-windows = <6>;
> > > + num-ob-windows = <8>;
> > > + status = "disabled";
> > > + };
> > > +
> > > pcie@360 {
> > > compatible = "fsl,ls1088a-pcie";
> > > reg = <0x00 0x0360 0x0 0x0010 /* controller
> > registers */
> > > @@ -533,6 +554,16 @@
> > > status = "disabled";
> > > };
> > >
> > > + pcie_ep@360 {
> > > + compatible = "fsl,ls1088a-pcie-ep","fsl,ls-pcie-ep";
> > > + reg = <0x00 0x0360 0x0 0x0010
> > > +0x30 0x 0x8 0x>;
> > > + reg-names = "regs", "addr_space";
> > > + num-ib-windows = <6>;
> > > + num-ob-windows = <8>;
> > > + status = "disabled";
> > > + };
> > > +
> > > smmu: iommu@500 {
> > > compatible = "arm,mmu-500";
> > > reg = <0 0x500 0 0x80>;
> > > --
> > > 2.9.5
> > >
RE: [PATCH v3 10/11] arm64: dts: layerscape: Add PCIe EP node for ls1088a
> -Original Message-
> From: Andrew Murray
> Sent: 2019年9月2日 21:06
> To: Xiaowei Bao
> Cc: robh...@kernel.org; mark.rutl...@arm.com; shawn...@kernel.org; Leo
> Li ; kis...@ti.com; lorenzo.pieral...@arm.com; M.h.
> Lian ; Mingkai Hu ; Roy
> Zang ; jingooh...@gmail.com;
> gustavo.pimen...@synopsys.com; linux-...@vger.kernel.org;
> devicet...@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-arm-ker...@lists.infradead.org; linuxppc-...@lists.ozlabs.org;
> a...@arndb.de; gre...@linuxfoundation.org; Z.q. Hou
>
> Subject: Re: [PATCH v3 10/11] arm64: dts: layerscape: Add PCIe EP node for
> ls1088a
>
> On Mon, Sep 02, 2019 at 11:17:15AM +0800, Xiaowei Bao wrote:
> > Add PCIe EP node for ls1088a to support EP mode.
> >
> > Signed-off-by: Xiaowei Bao
> > ---
> > v2:
> > - Remove the pf-offset proparty.
> > v3:
> > - No change.
> >
> > arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 31
> ++
> > 1 file changed, 31 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > index c676d07..da246ab 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > @@ -483,6 +483,17 @@
> > status = "disabled";
> > };
> >
> > + pcie_ep@340 {
> > + compatible = "fsl,ls1088a-pcie-ep","fsl,ls-pcie-ep";
>
> Here you specify a fallback "fsl,ls-pcie-ep" that is removed by this series.
>
> Besides that, this looks OK.
As explained, the "fsl,ls-pcie-ep" is needed, due to the u-boot will fixup the
status
property base on this compatible, I think we reserve this compatible is
helpfully,
if delate this compatible, I have to modify the code of bootloader.
Thanks
XIaowei
>
> Thanks,
>
> Andrew Murray
>
> > + reg = <0x00 0x0340 0x0 0x0010
> > + 0x20 0x 0x8 0x>;
> > + reg-names = "regs", "addr_space";
> > + num-ib-windows = <24>;
> > + num-ob-windows = <128>;
> > + max-functions = /bits/ 8 <2>;
> > + status = "disabled";
> > + };
> > +
> > pcie@350 {
> > compatible = "fsl,ls1088a-pcie";
> > reg = <0x00 0x0350 0x0 0x0010 /* controller
> registers */
> > @@ -508,6 +519,16 @@
> > status = "disabled";
> > };
> >
> > + pcie_ep@350 {
> > + compatible = "fsl,ls1088a-pcie-ep","fsl,ls-pcie-ep";
> > + reg = <0x00 0x0350 0x0 0x0010
> > + 0x28 0x 0x8 0x>;
> > + reg-names = "regs", "addr_space";
> > + num-ib-windows = <6>;
> > + num-ob-windows = <8>;
> > + status = "disabled";
> > + };
> > +
> > pcie@360 {
> > compatible = "fsl,ls1088a-pcie";
> > reg = <0x00 0x0360 0x0 0x0010 /* controller
> registers */
> > @@ -533,6 +554,16 @@
> > status = "disabled";
> > };
> >
> > + pcie_ep@360 {
> > + compatible = "fsl,ls1088a-pcie-ep","fsl,ls-pcie-ep";
> > + reg = <0x00 0x0360 0x0 0x0010
> > + 0x30 0x 0x8 0x>;
> > + reg-names = "regs", "addr_space";
> > + num-ib-windows = <6>;
> > + num-ob-windows = <8>;
> > + status = "disabled";
> > + };
> > +
> > smmu: iommu@500 {
> > compatible = "arm,mmu-500";
> > reg = <0 0x500 0 0x80>;
> > --
> > 2.9.5
> >
Re: [PATCH v3 10/11] arm64: dts: layerscape: Add PCIe EP node for ls1088a
On Mon, Sep 02, 2019 at 11:17:15AM +0800, Xiaowei Bao wrote:
> Add PCIe EP node for ls1088a to support EP mode.
>
> Signed-off-by: Xiaowei Bao
> ---
> v2:
> - Remove the pf-offset proparty.
> v3:
> - No change.
>
> arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 31
> ++
> 1 file changed, 31 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> index c676d07..da246ab 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> @@ -483,6 +483,17 @@
> status = "disabled";
> };
>
> + pcie_ep@340 {
> + compatible = "fsl,ls1088a-pcie-ep","fsl,ls-pcie-ep";
Here you specify a fallback "fsl,ls-pcie-ep" that is removed by this series.
Besides that, this looks OK.
Thanks,
Andrew Murray
> + reg = <0x00 0x0340 0x0 0x0010
> +0x20 0x 0x8 0x>;
> + reg-names = "regs", "addr_space";
> + num-ib-windows = <24>;
> + num-ob-windows = <128>;
> + max-functions = /bits/ 8 <2>;
> + status = "disabled";
> + };
> +
> pcie@350 {
> compatible = "fsl,ls1088a-pcie";
> reg = <0x00 0x0350 0x0 0x0010 /* controller
> registers */
> @@ -508,6 +519,16 @@
> status = "disabled";
> };
>
> + pcie_ep@350 {
> + compatible = "fsl,ls1088a-pcie-ep","fsl,ls-pcie-ep";
> + reg = <0x00 0x0350 0x0 0x0010
> +0x28 0x 0x8 0x>;
> + reg-names = "regs", "addr_space";
> + num-ib-windows = <6>;
> + num-ob-windows = <8>;
> + status = "disabled";
> + };
> +
> pcie@360 {
> compatible = "fsl,ls1088a-pcie";
> reg = <0x00 0x0360 0x0 0x0010 /* controller
> registers */
> @@ -533,6 +554,16 @@
> status = "disabled";
> };
>
> + pcie_ep@360 {
> + compatible = "fsl,ls1088a-pcie-ep","fsl,ls-pcie-ep";
> + reg = <0x00 0x0360 0x0 0x0010
> +0x30 0x 0x8 0x>;
> + reg-names = "regs", "addr_space";
> + num-ib-windows = <6>;
> + num-ob-windows = <8>;
> + status = "disabled";
> + };
> +
> smmu: iommu@500 {
> compatible = "arm,mmu-500";
> reg = <0 0x500 0 0x80>;
> --
> 2.9.5
>
