Re: [PATCH v3 2/2] ARM: s3c24xx: Correct SD card write protect detection on Mini2440

2018-09-10 Thread Krzysztof Kozlowski
On Fri, Sep 07, 2018 at 11:54:46PM +0200, Cedric Roux wrote: > The mini2440 computer uses "active high" to signal that the "write protect" > of the inserted MMC is set. The current code uses the opposite, leading to > a wrong detection of write protection. The solution is simply to use >

Re: [PATCH v3 2/2] ARM: s3c24xx: Correct SD card write protect detection on Mini2440

2018-09-10 Thread Krzysztof Kozlowski
On Fri, Sep 07, 2018 at 11:54:46PM +0200, Cedric Roux wrote: > The mini2440 computer uses "active high" to signal that the "write protect" > of the inserted MMC is set. The current code uses the opposite, leading to > a wrong detection of write protection. The solution is simply to use >

Re: [PATCH v3 2/2] ARM: s3c24xx: Correct SD card write protect detection on Mini2440

2018-09-10 Thread Krzysztof Kozlowski
On Mon, Sep 10, 2018 at 06:55:09PM +0200, Cedric Roux wrote: > On 09/10/2018 12:23 PM, Krzysztof Kozlowski wrote: > >> static struct s3c24xx_mci_pdata mini2440_mmc_cfg __initdata = { > >> - .gpio_detect = S3C2410_GPG(8), > >> - .gpio_wprotect = S3C2410_GPH(8), > >> -

Re: [PATCH v3 2/2] ARM: s3c24xx: Correct SD card write protect detection on Mini2440

2018-09-10 Thread Krzysztof Kozlowski
On Mon, Sep 10, 2018 at 06:55:09PM +0200, Cedric Roux wrote: > On 09/10/2018 12:23 PM, Krzysztof Kozlowski wrote: > >> static struct s3c24xx_mci_pdata mini2440_mmc_cfg __initdata = { > >> - .gpio_detect = S3C2410_GPG(8), > >> - .gpio_wprotect = S3C2410_GPH(8), > >> -

Re: [PATCH v3 2/2] ARM: s3c24xx: Correct SD card write protect detection on Mini2440

2018-09-10 Thread Cedric Roux
On 09/10/2018 12:23 PM, Krzysztof Kozlowski wrote: >> static struct s3c24xx_mci_pdata mini2440_mmc_cfg __initdata = { >> - .gpio_detect = S3C2410_GPG(8), >> - .gpio_wprotect = S3C2410_GPH(8), >> - .set_power = NULL, >> - .ocr_avail = MMC_VDD_32_33|MMC_VDD_33_34,

Re: [PATCH v3 2/2] ARM: s3c24xx: Correct SD card write protect detection on Mini2440

2018-09-10 Thread Cedric Roux
On 09/10/2018 12:23 PM, Krzysztof Kozlowski wrote: >> static struct s3c24xx_mci_pdata mini2440_mmc_cfg __initdata = { >> - .gpio_detect = S3C2410_GPG(8), >> - .gpio_wprotect = S3C2410_GPH(8), >> - .set_power = NULL, >> - .ocr_avail = MMC_VDD_32_33|MMC_VDD_33_34,

Re: [PATCH v3 2/2] ARM: s3c24xx: Correct SD card write protect detection on Mini2440

2018-09-10 Thread Krzysztof Kozlowski
On Fri, 7 Sep 2018 at 23:53, Cedric Roux wrote: > > The mini2440 computer uses "active high" to signal that the "write protect" > of the inserted MMC is set. The current code uses the opposite, leading to > a wrong detection of write protection. The solution is simply to use > ".wprotect_invert =

Re: [PATCH v3 2/2] ARM: s3c24xx: Correct SD card write protect detection on Mini2440

2018-09-10 Thread Krzysztof Kozlowski
On Fri, 7 Sep 2018 at 23:53, Cedric Roux wrote: > > The mini2440 computer uses "active high" to signal that the "write protect" > of the inserted MMC is set. The current code uses the opposite, leading to > a wrong detection of write protection. The solution is simply to use > ".wprotect_invert =