Re: [PATCH v3 2/2] dwc: PCI: intel: Intel PCIe RC controller driver

2019-09-15 Thread Dilip Kota
On 9/13/2019 6:12 PM, andriy.shevche...@intel.com wrote: On Fri, Sep 13, 2019 at 05:20:26PM +0800, Dilip Kota wrote: On 9/12/2019 6:49 PM, Gustavo Pimentel wrote: On Thu, Sep 12, 2019 at 10:23:31, Dilip Kota wrote: Hi, I just return from parental leave, therefore I still trying to get the pa

Re: [PATCH v3 2/2] dwc: PCI: intel: Intel PCIe RC controller driver

2019-09-13 Thread andriy.shevche...@intel.com
On Fri, Sep 13, 2019 at 05:20:26PM +0800, Dilip Kota wrote: > On 9/12/2019 6:49 PM, Gustavo Pimentel wrote: > > On Thu, Sep 12, 2019 at 10:23:31, Dilip Kota > > wrote: > > Hi, I just return from parental leave, therefore I still trying to get > > the pace in mailing list discussion. > > > > Howe

Re: [PATCH v3 2/2] dwc: PCI: intel: Intel PCIe RC controller driver

2019-09-13 Thread Dilip Kota
On 9/12/2019 6:49 PM, Gustavo Pimentel wrote: On Thu, Sep 12, 2019 at 10:23:31, Dilip Kota wrote: Quoting Andrew Murray: Quoting Gustavo Pimentel: On 9/12/2019 4:25 PM, Andrew Murray wrote: [...] +static void intel_pcie_max_link_width_setup(struct intel_pcie_port *lpp) +{ + u32 mask

RE: [PATCH v3 2/2] dwc: PCI: intel: Intel PCIe RC controller driver

2019-09-12 Thread Gustavo Pimentel
On Thu, Sep 12, 2019 at 10:23:31, Dilip Kota wrote: > Quoting Andrew Murray: > Quoting Gustavo Pimentel: > > On 9/12/2019 4:25 PM, Andrew Murray wrote: > > [...] > >> +static void intel_pcie_max_link_width_setup(struct > >> intel_pcie_port *lpp) > >> +{ > >> +

Re: [PATCH v3 2/2] dwc: PCI: intel: Intel PCIe RC controller driver

2019-09-12 Thread Dilip Kota
Quoting Andrew Murray: Quoting Gustavo Pimentel: On 9/12/2019 4:25 PM, Andrew Murray wrote: [...] +static void intel_pcie_max_link_width_setup(struct intel_pcie_port *lpp) +{ + u32 mask, val; + + /* HW auto bandwidth negotiation must be enabled */ + pcie_rc_cfg_wr_mask(lpp, PC

Re: [PATCH v3 2/2] dwc: PCI: intel: Intel PCIe RC controller driver

2019-09-12 Thread Andrew Murray
On Thu, Sep 12, 2019 at 02:58:45PM +0800, Dilip Kota wrote: > Hi Andrew Murray, > > On 9/11/2019 6:30 PM, Andrew Murray wrote: > > On Tue, Sep 10, 2019 at 03:46:17PM +0800, Dilip Kota wrote: > > > Hi Andrew Murray, > > > > > > Please find my response inline. > > > > > > On 9/9/2019 4:31 PM, Andr

Re: [PATCH v3 2/2] dwc: PCI: intel: Intel PCIe RC controller driver

2019-09-12 Thread Dilip Kota
Hi Andy, On 9/5/2019 7:40 PM, Andy Shevchenko wrote: On Thu, Sep 05, 2019 at 11:45:18AM +0100, Andrew Murray wrote: On Wed, Sep 04, 2019 at 06:10:31PM +0800, Dilip Kota wrote: Add support to PCIe RC controller on Intel Universal Gateway SoC. PCIe controller is based of Synopsys Designware pci

Re: [PATCH v3 2/2] dwc: PCI: intel: Intel PCIe RC controller driver

2019-09-11 Thread Dilip Kota
Hi Andrew Murray, On 9/11/2019 6:30 PM, Andrew Murray wrote: On Tue, Sep 10, 2019 at 03:46:17PM +0800, Dilip Kota wrote: Hi Andrew Murray, Please find my response inline. On 9/9/2019 4:31 PM, Andrew Murray wrote: On Mon, Sep 09, 2019 at 02:51:03PM +0800, Dilip Kota wrote: On 9/6/2019 7:20 P

Re: [PATCH v3 2/2] dwc: PCI: intel: Intel PCIe RC controller driver

2019-09-11 Thread Andrew Murray
On Tue, Sep 10, 2019 at 03:46:17PM +0800, Dilip Kota wrote: > Hi Andrew Murray, > > Please find my response inline. > > On 9/9/2019 4:31 PM, Andrew Murray wrote: > > On Mon, Sep 09, 2019 at 02:51:03PM +0800, Dilip Kota wrote: > > > On 9/6/2019 7:20 PM, Andrew Murray wrote: > > > > On Fri, Sep 06,

Re: [PATCH v3 2/2] dwc: PCI: intel: Intel PCIe RC controller driver

2019-09-10 Thread Dilip Kota
[Got delivery failure mail; so re-sending the mail] Hi Andrew Murray, Please find my response inline. On 9/9/2019 4:31 PM, Andrew Murray wrote: On Mon, Sep 09, 2019 at 02:51:03PM +0800, Dilip Kota wrote: On 9/6/2019 7:20 PM, Andrew Murray wrote: On Fri, Sep 06, 2019 at 06:58:11PM +0800, Dili

Re: [PATCH v3 2/2] dwc: PCI: intel: Intel PCIe RC controller driver

2019-09-09 Thread Andrew Murray
On Mon, Sep 09, 2019 at 02:51:03PM +0800, Dilip Kota wrote: > > On 9/6/2019 7:20 PM, Andrew Murray wrote: > > On Fri, Sep 06, 2019 at 06:58:11PM +0800, Dilip Kota wrote: > > > Hi Andrew Murray, > > > > > > Thanks for the review. Please find my response inline. > > > > > > On 9/5/2019 6:45 PM, An

Re: [PATCH v3 2/2] dwc: PCI: intel: Intel PCIe RC controller driver

2019-09-08 Thread Dilip Kota
On 9/6/2019 7:20 PM, Andrew Murray wrote: On Fri, Sep 06, 2019 at 06:58:11PM +0800, Dilip Kota wrote: Hi Andrew Murray, Thanks for the review. Please find my response inline. On 9/5/2019 6:45 PM, Andrew Murray wrote: On Wed, Sep 04, 2019 at 06:10:31PM +0800, Dilip Kota wrote: Add support t

Re: [PATCH v3 2/2] dwc: PCI: intel: Intel PCIe RC controller driver

2019-09-06 Thread Andrew Murray
On Fri, Sep 06, 2019 at 06:58:11PM +0800, Dilip Kota wrote: > Hi Andrew Murray, > > Thanks for the review. Please find my response inline. > > On 9/5/2019 6:45 PM, Andrew Murray wrote: > > On Wed, Sep 04, 2019 at 06:10:31PM +0800, Dilip Kota wrote: > > > Add support to PCIe RC controller on Intel

Re: [PATCH v3 2/2] dwc: PCI: intel: Intel PCIe RC controller driver

2019-09-06 Thread Dilip Kota
Hi Andrew Murray, Thanks for the review. Please find my response inline. On 9/5/2019 6:45 PM, Andrew Murray wrote: On Wed, Sep 04, 2019 at 06:10:31PM +0800, Dilip Kota wrote: Add support to PCIe RC controller on Intel Universal Gateway SoC. PCIe controller is based of Synopsys Designware pci c

Re: [PATCH v3 2/2] dwc: PCI: intel: Intel PCIe RC controller driver

2019-09-06 Thread Dilip Kota
Hi Andy, Thanks for the review comments, please find my response inline. On 9/4/2019 9:05 PM, Andy Shevchenko wrote: On Wed, Sep 04, 2019 at 06:10:31PM +0800, Dilip Kota wrote: Add support to PCIe RC controller on Intel Universal Gateway SoC. PCIe controller is based of Synopsys Designware pci

Re: [PATCH v3 2/2] dwc: PCI: intel: Intel PCIe RC controller driver

2019-09-05 Thread Andy Shevchenko
On Thu, Sep 05, 2019 at 11:45:18AM +0100, Andrew Murray wrote: > On Wed, Sep 04, 2019 at 06:10:31PM +0800, Dilip Kota wrote: > > Add support to PCIe RC controller on Intel Universal > > Gateway SoC. PCIe controller is based of Synopsys > > Designware pci core. > > +config PCIE_INTEL_AXI I think t

Re: [PATCH v3 2/2] dwc: PCI: intel: Intel PCIe RC controller driver

2019-09-05 Thread Christoph Hellwig
On Thu, Sep 05, 2019 at 11:45:18AM +0100, Andrew Murray wrote: > > +depends on OF > > +select PCIE_DW_HOST > > +help > > + Say 'Y' here to enable support for Intel AHB/AXI PCIe Host > > + controller driver. > > + The Intel PCIe controller is based on the Syn

Re: [PATCH v3 2/2] dwc: PCI: intel: Intel PCIe RC controller driver

2019-09-05 Thread Andrew Murray
On Wed, Sep 04, 2019 at 06:10:31PM +0800, Dilip Kota wrote: > Add support to PCIe RC controller on Intel Universal > Gateway SoC. PCIe controller is based of Synopsys > Designware pci core. > > Signed-off-by: Dilip Kota > --- Hi Dilip, Thanks for the patch, initial feedback below: > changes on

Re: [PATCH v3 2/2] dwc: PCI: intel: Intel PCIe RC controller driver

2019-09-04 Thread Chuan Hua, Lei
Hi Dilip, On 9/4/2019 6:10 PM, Dilip Kota wrote: Add support to PCIe RC controller on Intel Universal Gateway SoC. PCIe controller is based of Synopsys Designware pci core. Signed-off-by: Dilip Kota --- changes on v3: Rename PCIe app logic registers with PCIE_APP prefix. PCIE_I

Re: [PATCH v3 2/2] dwc: PCI: intel: Intel PCIe RC controller driver

2019-09-04 Thread Andy Shevchenko
On Wed, Sep 04, 2019 at 06:10:31PM +0800, Dilip Kota wrote: > Add support to PCIe RC controller on Intel Universal > Gateway SoC. PCIe controller is based of Synopsys > Designware pci core. Thanks for an update. My comments below. > +config PCIE_INTEL_AXI > +bool "Intel AHB/AXI PCIe host