On Tue, Apr 20, 2021 at 2:36 PM Tomas Melin wrote:
> On 4/20/21 1:47 PM, Andy Shevchenko wrote:
> > On Tue, Apr 20, 2021 at 11:50 AM Tomas Melin
> > wrote:
...
> + for_each_set_bit(bit, indio_dev->active_scan_mask,
> +indio_dev->masklength) {
> +
On 4/20/21 1:47 PM, Andy Shevchenko wrote:
On Tue, Apr 20, 2021 at 11:50 AM Tomas Melin wrote:
+ sca_data->txbuf[0] = 0x0 | (SCA3300_REG_STATUS << 2);
Seems you ignored my comment. What is this 0x0? What is the meaning of it?
Same for all the rest magic numbers in the code.
Sorry,
On Tue, Apr 20, 2021 at 11:50 AM Tomas Melin wrote:
> On 4/19/21 4:55 PM, Andy Shevchenko wrote:
> > On Mon, Apr 19, 2021 at 4:26 PM Tomas Melin wrote:
...
> >> +#define SCA3300_MASK_STATUSGENMASK(8, 0)
> >> +#define SCA3300_MASK_RS_STATUS GENMASK(1, 0)
> > This feels like an orphan.
Hi Andy,
Thanks for further comments, see some answers/questions below.
thanks,
Tomas
On 4/19/21 4:55 PM, Andy Shevchenko wrote:
On Mon, Apr 19, 2021 at 4:26 PM Tomas Melin wrote:
Thanks for an update, it's getting better! My comments below.
Add initial support for Murata SCA3300 3-axis
On Mon, Apr 19, 2021 at 4:26 PM Tomas Melin wrote:
Thanks for an update, it's getting better! My comments below.
> Add initial support for Murata SCA3300 3-axis industrial
> accelerometer with digital SPI interface. This device also
> provides a temperature measurement.
First of all, you
5 matches
Mail list logo
