Re: [PATCH v3 2/2] x86/apic: Replace common tools with new ones

2018-02-25 Thread Dou Liyang 

Hi Andy,

At 02/23/2018 08:40 PM, Andy Shevchenko wrote:

On Fri, Feb 23, 2018 at 9:54 AM, Dou Liyang  wrote:

The pending interrupt check code is old, update the following code.

   -Replace for() with for_each_set_bit()



-   for (j = 31; j >= 0; j--) {
-   if (value & (1<

for_each_set_bit(), mind 'set' part, is equivalent to for-if pair...


+   if (j) {


...here you just exclude bit 0 from consideration by unknown reason.



Oops! my fault, will modify it.

Thanks,
dou


 ack_APIC_irq();
 acked++;
 }
 }

Re: [PATCH v3 2/2] x86/apic: Replace common tools with new ones

2018-02-23 Thread Andy Shevchenko 
On Fri, Feb 23, 2018 at 9:54 AM, Dou Liyang  wrote:
> The pending interrupt check code is old, update the following code.
>
>   -Replace for() with for_each_set_bit()

> -   for (j = 31; j >= 0; j--) {
> -   if (value & (1< +   for_each_set_bit(j, &value, 32) {

for_each_set_bit(), mind 'set' part, is equivalent to for-if pair...

> +   if (j) {

...here you just exclude bit 0 from consideration by unknown reason.

> ack_APIC_irq();
> acked++;
> }
> }

-- 
With Best Regards,
Andy Shevchenko