Re: [PATCH v3 2/3] ioremap: Update pgtable free interfaces with addr
On Thu, 2018-05-17 at 08:47 +0200, Michal Hocko wrote: > On Wed 16-05-18 17:32:06, Kani Toshimitsu wrote: > > From: Chintan Pandya > > > > This patch ("mm/vmalloc: Add interfaces to free unmapped > > page table") adds following 2 interfaces to free the page > > table in case we implement huge mapping. > > > > pud_free_pmd_page() and pmd_free_pte_page() > > > > Some architectures (like arm64) needs to do proper TLB > > maintanance after updating pagetable entry even in map. > > Why ? Read this, > > https://patchwork.kernel.org/patch/10134581/ > > Please add that information to the changelog. I will update the description and resend this patch. Thanks! -Toshi
Re: [PATCH v3 2/3] ioremap: Update pgtable free interfaces with addr
On Wed 16-05-18 17:32:06, Kani Toshimitsu wrote: > From: Chintan Pandya > > This patch ("mm/vmalloc: Add interfaces to free unmapped > page table") adds following 2 interfaces to free the page > table in case we implement huge mapping. > > pud_free_pmd_page() and pmd_free_pte_page() > > Some architectures (like arm64) needs to do proper TLB > maintanance after updating pagetable entry even in map. > Why ? Read this, > https://patchwork.kernel.org/patch/10134581/ Please add that information to the changelog. -- Michal Hocko SUSE Labs