Re: [PATCH v3 2/5] ASoC: codecs: msm8916-wcd-analog: get micbias voltage from dt
On 10/08/17 16:24, Mark Brown wrote: On Wed, Aug 09, 2017 at 06:49:24PM +0200, srinivas.kandaga...@linaro.org wrote: - snd_soc_write(codec, CDC_A_MICB_1_VAL, MICB_1_VAL_MICB_OUT_VAL_V2P70V); - /* -* Special headset needs MICBIAS as 2.7V so wait for -* 50 msec for the MICBIAS to reach 2.7 volts. -*/ - msleep(50); + if (wcd->micbias_mv) We seem to have just completely lost this ramp time handling? Yes, will take care of this in next version.
Re: [PATCH v3 2/5] ASoC: codecs: msm8916-wcd-analog: get micbias voltage from dt
On 10/08/17 16:24, Mark Brown wrote: On Wed, Aug 09, 2017 at 06:49:24PM +0200, srinivas.kandaga...@linaro.org wrote: - snd_soc_write(codec, CDC_A_MICB_1_VAL, MICB_1_VAL_MICB_OUT_VAL_V2P70V); - /* -* Special headset needs MICBIAS as 2.7V so wait for -* 50 msec for the MICBIAS to reach 2.7 volts. -*/ - msleep(50); + if (wcd->micbias_mv) We seem to have just completely lost this ramp time handling? Yes, will take care of this in next version.
Re: [PATCH v3 2/5] ASoC: codecs: msm8916-wcd-analog: get micbias voltage from dt
On Wed, Aug 09, 2017 at 06:49:24PM +0200, srinivas.kandaga...@linaro.org wrote: > - snd_soc_write(codec, CDC_A_MICB_1_VAL, MICB_1_VAL_MICB_OUT_VAL_V2P70V); > - /* > - * Special headset needs MICBIAS as 2.7V so wait for > - * 50 msec for the MICBIAS to reach 2.7 volts. > - */ > - msleep(50); > + if (wcd->micbias_mv) We seem to have just completely lost this ramp time handling? signature.asc Description: PGP signature
Re: [PATCH v3 2/5] ASoC: codecs: msm8916-wcd-analog: get micbias voltage from dt
On Wed, Aug 09, 2017 at 06:49:24PM +0200, srinivas.kandaga...@linaro.org wrote: > - snd_soc_write(codec, CDC_A_MICB_1_VAL, MICB_1_VAL_MICB_OUT_VAL_V2P70V); > - /* > - * Special headset needs MICBIAS as 2.7V so wait for > - * 50 msec for the MICBIAS to reach 2.7 volts. > - */ > - msleep(50); > + if (wcd->micbias_mv) We seem to have just completely lost this ramp time handling? signature.asc Description: PGP signature
