Re: [PATCH v3 2/5] crypto: caam: Fix endless loop when RNG is already initialized

2018-02-05 Thread Auer, Lukas
On Mon, 2018-02-05 at 08:45 +, Horia Geantă wrote: > On 2/2/2018 2:54 PM, Auer, Lukas wrote: > > On Fri, 2018-02-02 at 11:20 +, Bryan O'Donoghue wrote: > > > On 01/02/18 12:16, Horia Geantă wrote: > > > > If the loop cannot exit based on value of "ret" != -EAGAIN, > > > > then it > > > > me

Re: [PATCH v3 2/5] crypto: caam: Fix endless loop when RNG is already initialized

2018-02-05 Thread Horia Geantă
On 2/2/2018 2:54 PM, Auer, Lukas wrote: > On Fri, 2018-02-02 at 11:20 +, Bryan O'Donoghue wrote: >> On 01/02/18 12:16, Horia Geantă wrote: >>> If the loop cannot exit based on value of "ret" != -EAGAIN, then it >>> means >>> caam_probe() will eventually fail due to ret == -EAGAIN: >>> if (r

Re: [PATCH v3 2/5] crypto: caam: Fix endless loop when RNG is already initialized

2018-02-02 Thread Auer, Lukas
On Fri, 2018-02-02 at 11:20 +, Bryan O'Donoghue wrote: > On 01/02/18 12:16, Horia Geantă wrote: > > If the loop cannot exit based on value of "ret" != -EAGAIN, then it > > means > > caam_probe() will eventually fail due to ret == -EAGAIN: > > if (ret) { > > dev_err(dev, "failed

Re: [PATCH v3 2/5] crypto: caam: Fix endless loop when RNG is already initialized

2018-02-02 Thread Bryan O'Donoghue
On 01/02/18 12:16, Horia Geantă wrote: If the loop cannot exit based on value of "ret" != -EAGAIN, then it means caam_probe() will eventually fail due to ret == -EAGAIN: if (ret) { dev_err(dev, "failed to instantiate RNG"); goto caam_remove; } For

Re: [PATCH v3 2/5] crypto: caam: Fix endless loop when RNG is already initialized

2018-02-01 Thread Horia Geantă
On 1/31/2018 4:00 AM, Bryan O'Donoghue wrote: > commit 1005bccd7a4a ("crypto: caam - enable instantiation of all RNG4 state > handles") introduces a control when incrementing ent_delay which contains > the following comment above it: > > /* > * If either SH were instantiated by somebody else > *