Re: [PATCH v3 2/9] soc: samsung: Convert exynos-chipid driver to use the regmap API

2019-08-21 Thread Bartlomiej Zolnierkiewicz
On 8/21/19 2:16 PM, Krzysztof Kozlowski wrote: > On Wed, 21 Aug 2019 at 13:51, Bartlomiej Zolnierkiewicz > wrote: > Following this change, I am now seeing the above error on our Tegra > boards where this driver is enabled. This is triggering a kernel > warnings test we have to fail.

Re: [PATCH v3 2/9] soc: samsung: Convert exynos-chipid driver to use the regmap API

2019-08-21 Thread Krzysztof Kozlowski
On Wed, 21 Aug 2019 at 14:41, Sylwester Nawrocki wrote: > > On 8/21/19 14:16, Krzysztof Kozlowski wrote: > >>> I'm also inclined to have it converted to a regular driver. We already > >>> have "exynos-asv" driver matching on the chipid node (patch 3/9). > >>> The ASV patches will not be merged so

Re: [PATCH v3 2/9] soc: samsung: Convert exynos-chipid driver to use the regmap API

2019-08-21 Thread Sylwester Nawrocki
On 8/21/19 14:16, Krzysztof Kozlowski wrote: >>> I'm also inclined to have it converted to a regular driver. We already >>> have "exynos-asv" driver matching on the chipid node (patch 3/9). >>> The ASV patches will not be merged soon anyway, all this needs some more >>> thought. Krzysztof, can we

Re: [PATCH v3 2/9] soc: samsung: Convert exynos-chipid driver to use the regmap API

2019-08-21 Thread Krzysztof Kozlowski
On Wed, 21 Aug 2019 at 13:51, Bartlomiej Zolnierkiewicz wrote: > >>> Following this change, I am now seeing the above error on our Tegra > >>> boards where this driver is enabled. This is triggering a kernel > >>> warnings test we have to fail. Hence, I don't think that you can remove > >>> the co

Re: [PATCH v3 2/9] soc: samsung: Convert exynos-chipid driver to use the regmap API

2019-08-21 Thread Bartlomiej Zolnierkiewicz
Hi, On 8/20/19 11:38 PM, Sylwester Nawrocki wrote: > On 8/20/19 21:37, Krzysztof Kozlowski wrote: diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c > @@ -51,29 +48,24 @@ static const char * __init product_id_to_soc_id(unsigned int produ

Re: [PATCH v3 2/9] soc: samsung: Convert exynos-chipid driver to use the regmap API

2019-08-21 Thread Krzysztof Kozlowski
On Tue, 20 Aug 2019 at 23:38, Sylwester Nawrocki wrote: > > On 8/20/19 21:37, Krzysztof Kozlowski wrote: > >>> diff --git a/drivers/soc/samsung/exynos-chipid.c > >>> b/drivers/soc/samsung/exynos-chipid.c > > >>> @@ -51,29 +48,24 @@ static const char * __init > >>> product_id_to_soc_id(unsigned i

Re: [PATCH v3 2/9] soc: samsung: Convert exynos-chipid driver to use the regmap API

2019-08-20 Thread Sylwester Nawrocki
On 8/20/19 21:37, Krzysztof Kozlowski wrote: >>> diff --git a/drivers/soc/samsung/exynos-chipid.c >>> b/drivers/soc/samsung/exynos-chipid.c >>> @@ -51,29 +48,24 @@ static const char * __init >>> product_id_to_soc_id(unsigned int product_id) >>> int __init exynos_chipid_early_init(void) >>> {

Re: [PATCH v3 2/9] soc: samsung: Convert exynos-chipid driver to use the regmap API

2019-08-20 Thread Krzysztof Kozlowski
On Tue, 20 Aug 2019 at 21:24, Jon Hunter wrote: > > > On 13/08/2019 16:08, Sylwester Nawrocki wrote: > > Convert the driver to use regmap API in order to allow other > > drivers, like ASV, to access the CHIPID registers. > > > > This patch adds definition of selected CHIPID register offsets > > an

Re: [PATCH v3 2/9] soc: samsung: Convert exynos-chipid driver to use the regmap API

2019-08-20 Thread Jon Hunter
On 13/08/2019 16:08, Sylwester Nawrocki wrote: > Convert the driver to use regmap API in order to allow other > drivers, like ASV, to access the CHIPID registers. > > This patch adds definition of selected CHIPID register offsets > and register bit fields for Exynos5422 SoC. > > Signed-off-by:

Re: [PATCH v3 2/9] soc: samsung: Convert exynos-chipid driver to use the regmap API

2019-08-15 Thread Krzysztof Kozlowski
On Tue, Aug 13, 2019 at 05:08:20PM +0200, Sylwester Nawrocki wrote: > Convert the driver to use regmap API in order to allow other > drivers, like ASV, to access the CHIPID registers. > > This patch adds definition of selected CHIPID register offsets > and register bit fields for Exynos5422 SoC. >