Re: [PATCH v3 3/3] Bluetooth: hci_qca: Add serdev support

2018-03-14 Thread Thierry Escande 

On 13/03/2018 21:57, Andy Shevchenko wrote:

On Tue, Mar 13, 2018 at 8:38 PM, Thierry Escande
 wrote:

Add support for Qualcomm serial slave devices. Probe the serial device,
retrieve its maximum speed and register a new hci uart device.



  config BT_HCIUART_QCA
 bool "Qualcomm Atheros protocol support"
-   depends on BT_HCIUART
+   depends on BT_HCIUART_SERDEV


Consider to address Loic's comments.


+#include 


This is still here. Why?


I forgot that one. This was for struct of_device_id. I'll replace it 
with mod_devicetable.h.


Regards,
Thierry

Re: [PATCH v3 3/3] Bluetooth: hci_qca: Add serdev support

2018-03-13 Thread Andy Shevchenko 
On Tue, Mar 13, 2018 at 8:38 PM, Thierry Escande
 wrote:
> Add support for Qualcomm serial slave devices. Probe the serial device,
> retrieve its maximum speed and register a new hci uart device.

>  config BT_HCIUART_QCA
> bool "Qualcomm Atheros protocol support"
> -   depends on BT_HCIUART
> +   depends on BT_HCIUART_SERDEV

Consider to address Loic's comments.

> +#include 

This is still here. Why?

-- 
With Best Regards,
Andy Shevchenko