Re: [PATCH v3 3/9] x86/microcode/AMD: install_equiv_cpu_table() should not return (signed) int

2018-03-14 Thread Maciej S. Szmigiero
On 15.03.2018 01:56, Borislav Petkov wrote: > On Thu, Mar 15, 2018 at 01:13:07AM +0100, Maciej S. Szmigiero wrote: >> This can be done if this function is modified to return only the CPU >> equivalence table length (without the container header length), leaving >> its single caller the job of

Re: [PATCH v3 3/9] x86/microcode/AMD: install_equiv_cpu_table() should not return (signed) int

2018-03-14 Thread Maciej S. Szmigiero
On 15.03.2018 01:56, Borislav Petkov wrote: > On Thu, Mar 15, 2018 at 01:13:07AM +0100, Maciej S. Szmigiero wrote: >> This can be done if this function is modified to return only the CPU >> equivalence table length (without the container header length), leaving >> its single caller the job of

Re: [PATCH v3 3/9] x86/microcode/AMD: install_equiv_cpu_table() should not return (signed) int

2018-03-14 Thread Borislav Petkov
On Thu, Mar 15, 2018 at 01:13:07AM +0100, Maciej S. Szmigiero wrote: > This can be done if this function is modified to return only the CPU > equivalence table length (without the container header length), leaving > its single caller the job of adding the container header length to skip > to the

Re: [PATCH v3 3/9] x86/microcode/AMD: install_equiv_cpu_table() should not return (signed) int

2018-03-14 Thread Borislav Petkov
On Thu, Mar 15, 2018 at 01:13:07AM +0100, Maciej S. Szmigiero wrote: > This can be done if this function is modified to return only the CPU > equivalence table length (without the container header length), leaving > its single caller the job of adding the container header length to skip > to the

Re: [PATCH v3 3/9] x86/microcode/AMD: install_equiv_cpu_table() should not return (signed) int

2018-03-14 Thread Maciej S. Szmigiero
On 15.03.2018 00:58, Borislav Petkov wrote: > On Thu, Mar 15, 2018 at 12:46:05AM +0100, Maciej S. Szmigiero wrote: >> The maximum possible value returned by install_equiv_cpu_table() of >> UINT_MAX + CONTAINER_HDR_SZ comes from the maximum value of this 'size' >> variable (that is UINT_MAX) plus

Re: [PATCH v3 3/9] x86/microcode/AMD: install_equiv_cpu_table() should not return (signed) int

2018-03-14 Thread Maciej S. Szmigiero
On 15.03.2018 00:58, Borislav Petkov wrote: > On Thu, Mar 15, 2018 at 12:46:05AM +0100, Maciej S. Szmigiero wrote: >> The maximum possible value returned by install_equiv_cpu_table() of >> UINT_MAX + CONTAINER_HDR_SZ comes from the maximum value of this 'size' >> variable (that is UINT_MAX) plus

Re: [PATCH v3 3/9] x86/microcode/AMD: install_equiv_cpu_table() should not return (signed) int

2018-03-14 Thread Borislav Petkov
On Thu, Mar 15, 2018 at 12:46:05AM +0100, Maciej S. Szmigiero wrote: > The maximum possible value returned by install_equiv_cpu_table() of > UINT_MAX + CONTAINER_HDR_SZ comes from the maximum value of this 'size' > variable (that is UINT_MAX) plus the header length of CONTAINER_HDR_SZ. > This

Re: [PATCH v3 3/9] x86/microcode/AMD: install_equiv_cpu_table() should not return (signed) int

2018-03-14 Thread Borislav Petkov
On Thu, Mar 15, 2018 at 12:46:05AM +0100, Maciej S. Szmigiero wrote: > The maximum possible value returned by install_equiv_cpu_table() of > UINT_MAX + CONTAINER_HDR_SZ comes from the maximum value of this 'size' > variable (that is UINT_MAX) plus the header length of CONTAINER_HDR_SZ. > This

Re: [PATCH v3 3/9] x86/microcode/AMD: install_equiv_cpu_table() should not return (signed) int

2018-03-14 Thread Maciej S. Szmigiero
On 14.03.2018 18:58, Borislav Petkov wrote: > On Tue, Mar 13, 2018 at 10:06:34PM +0100, Maciej S. Szmigiero wrote: >> The maximum possible value returned by install_equiv_cpu_table() is >> UINT_MAX + CONTAINER_HDR_SZ (on a 64-bit kernel). >> This is more than (signed) int type currently returned

Re: [PATCH v3 3/9] x86/microcode/AMD: install_equiv_cpu_table() should not return (signed) int

2018-03-14 Thread Maciej S. Szmigiero
On 14.03.2018 18:58, Borislav Petkov wrote: > On Tue, Mar 13, 2018 at 10:06:34PM +0100, Maciej S. Szmigiero wrote: >> The maximum possible value returned by install_equiv_cpu_table() is >> UINT_MAX + CONTAINER_HDR_SZ (on a 64-bit kernel). >> This is more than (signed) int type currently returned

Re: [PATCH v3 3/9] x86/microcode/AMD: install_equiv_cpu_table() should not return (signed) int

2018-03-14 Thread Borislav Petkov
On Tue, Mar 13, 2018 at 10:06:34PM +0100, Maciej S. Szmigiero wrote: > The maximum possible value returned by install_equiv_cpu_table() is > UINT_MAX + CONTAINER_HDR_SZ (on a 64-bit kernel). > This is more than (signed) int type currently returned by this function can > hold so this function will

Re: [PATCH v3 3/9] x86/microcode/AMD: install_equiv_cpu_table() should not return (signed) int

2018-03-14 Thread Borislav Petkov
On Tue, Mar 13, 2018 at 10:06:34PM +0100, Maciej S. Szmigiero wrote: > The maximum possible value returned by install_equiv_cpu_table() is > UINT_MAX + CONTAINER_HDR_SZ (on a 64-bit kernel). > This is more than (signed) int type currently returned by this function can > hold so this function will