Re: [PATCH v3 4/5] KVM: LAPIC: Delay trace advance expire delta

2019-05-20 Thread Sean Christopherson
On Mon, May 20, 2019 at 02:38:44PM +0800, Wanpeng Li wrote: > On Sat, 18 May 2019 at 03:44, Sean Christopherson > wrote: > > This needs to be guarded with lapic_in_kernel(vcpu). But, since this is > > all in the same flow, a better approach would be to return the delta from > >

Re: [PATCH v3 4/5] KVM: LAPIC: Delay trace advance expire delta

2019-05-20 Thread Wanpeng Li
On Sat, 18 May 2019 at 03:44, Sean Christopherson wrote: > > On Thu, May 16, 2019 at 11:06:19AM +0800, Wanpeng Li wrote: > > From: Wanpeng Li > > > > wait_lapic_expire() call was moved above guest_enter_irqoff() because of > > its tracepoint, which violated the RCU extended quiescent state

Re: [PATCH v3 4/5] KVM: LAPIC: Delay trace advance expire delta

2019-05-17 Thread Sean Christopherson
On Thu, May 16, 2019 at 11:06:19AM +0800, Wanpeng Li wrote: > From: Wanpeng Li > > wait_lapic_expire() call was moved above guest_enter_irqoff() because of > its tracepoint, which violated the RCU extended quiescent state invoked > by guest_enter_irqoff()[1][2]. This patch simply moves the