Re: [PATCH v3 4/9] media: davinci: vpif_capture: move the freeing of irq and global variables to remove()

2013-05-28 Thread Prabhakar Lad
Hi Laurent, Thanks for the review. On Wed, May 29, 2013 at 8:02 AM, Laurent Pinchart wrote: > Hi Prabhakar, > > Thanks for the patch. > > On Sunday 26 May 2013 17:30:07 Prabhakar Lad wrote: >> From: Lad, Prabhakar >> >> Ideally the freeing of irq's and the global variables needs to be >> done

Re: [PATCH v3 4/9] media: davinci: vpif_capture: move the freeing of irq and global variables to remove()

2013-05-28 Thread Laurent Pinchart
Hi Prabhakar, Thanks for the patch. On Sunday 26 May 2013 17:30:07 Prabhakar Lad wrote: > From: Lad, Prabhakar > > Ideally the freeing of irq's and the global variables needs to be > done in the remove() rather than module_exit(), this patch moves > the freeing up of irq's and freeing the

Re: [PATCH v3 4/9] media: davinci: vpif_capture: move the freeing of irq and global variables to remove()

2013-05-28 Thread Laurent Pinchart
Hi Prabhakar, Thanks for the patch. On Sunday 26 May 2013 17:30:07 Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com Ideally the freeing of irq's and the global variables needs to be done in the remove() rather than module_exit(), this patch moves the freeing up of irq's

Re: [PATCH v3 4/9] media: davinci: vpif_capture: move the freeing of irq and global variables to remove()

2013-05-28 Thread Prabhakar Lad
Hi Laurent, Thanks for the review. On Wed, May 29, 2013 at 8:02 AM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Prabhakar, Thanks for the patch. On Sunday 26 May 2013 17:30:07 Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com Ideally the freeing of

Re: [PATCH v3 4/9] media: davinci: vpif_capture: move the freeing of irq and global variables to remove()

2013-05-26 Thread Sergei Shtylyov
Hello. On 26-05-2013 16:00, Prabhakar Lad wrote: From: Lad, Prabhakar Ideally the freeing of irq's and the global variables needs to be done in the remove() rather than module_exit(), this patch moves the freeing up of irq's and freeing the memory allocated to channel objects to remove()

Re: [PATCH v3 4/9] media: davinci: vpif_capture: move the freeing of irq and global variables to remove()

2013-05-26 Thread Sergei Shtylyov
Hello. On 26-05-2013 16:00, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com Ideally the freeing of irq's and the global variables needs to be done in the remove() rather than module_exit(), this patch moves the freeing up of irq's and freeing the memory allocated to