Re: [PATCH v3 5/5] dell-wmi: support Dell Inspiron M5110

2016-02-18 Thread Michał Kępień
> > Please note that except for the first 5 entries, the keymap is sorted by > > event code in ascending order. > > I have prepared some patches which sort all event codes plus adds > missing comments... So after all dell patches are in Darren tree, I will > rewrite/rebase my and can send them. >

Re: [PATCH v3 5/5] dell-wmi: support Dell Inspiron M5110

2016-02-18 Thread Michał Kępień
> > Please note that except for the first 5 entries, the keymap is sorted by > > event code in ascending order. > > I have prepared some patches which sort all event codes plus adds > missing comments... So after all dell patches are in Darren tree, I will > rewrite/rebase my and can send them. >

Re: [PATCH v3 5/5] dell-wmi: support Dell Inspiron M5110

2016-02-17 Thread Pali Rohár
On Wednesday 17 February 2016 13:01:58 Michał Kępień wrote: > > > > > /* Shortcut and audio panel keys */ > > > > > { KE_KEY, 0xe025, { KEY_PROG4 } }, > > > > > { KE_IGNORE, 0xe026, { KEY_RESERVED } }, > > > > > + { KE_KEY, 0xe029, { KEY_PROG4 } }, > > > > > > > > Hi! Above

Re: [PATCH v3 5/5] dell-wmi: support Dell Inspiron M5110

2016-02-17 Thread Pali Rohár
On Wednesday 17 February 2016 13:01:58 Michał Kępień wrote: > > > > > /* Shortcut and audio panel keys */ > > > > > { KE_KEY, 0xe025, { KEY_PROG4 } }, > > > > > { KE_IGNORE, 0xe026, { KEY_RESERVED } }, > > > > > + { KE_KEY, 0xe029, { KEY_PROG4 } }, > > > > > > > > Hi! Above

Re: [PATCH v3 5/5] dell-wmi: support Dell Inspiron M5110

2016-02-17 Thread Michał Kępień
> > > > /* Shortcut and audio panel keys */ > > > > { KE_KEY, 0xe025, { KEY_PROG4 } }, > > > > { KE_IGNORE, 0xe026, { KEY_RESERVED } }, > > > > + { KE_KEY, 0xe029, { KEY_PROG4 } }, > > > > > > Hi! Above comment (Shortcut and audio panel keys) is not relevant for > >

Re: [PATCH v3 5/5] dell-wmi: support Dell Inspiron M5110

2016-02-17 Thread Michał Kępień
> > > > /* Shortcut and audio panel keys */ > > > > { KE_KEY, 0xe025, { KEY_PROG4 } }, > > > > { KE_IGNORE, 0xe026, { KEY_RESERVED } }, > > > > + { KE_KEY, 0xe029, { KEY_PROG4 } }, > > > > > > Hi! Above comment (Shortcut and audio panel keys) is not relevant for > >

Re: [PATCH v3 5/5] dell-wmi: support Dell Inspiron M5110

2016-02-17 Thread Pali Rohár
On Tuesday 16 February 2016 23:03:12 Michał Kępień wrote: > > > /* Shortcut and audio panel keys */ > > > { KE_KEY, 0xe025, { KEY_PROG4 } }, > > > { KE_IGNORE, 0xe026, { KEY_RESERVED } }, > > > + { KE_KEY, 0xe029, { KEY_PROG4 } }, > > > > Hi! Above comment (Shortcut and audio panel keys) is

Re: [PATCH v3 5/5] dell-wmi: support Dell Inspiron M5110

2016-02-17 Thread Pali Rohár
On Tuesday 16 February 2016 23:03:12 Michał Kępień wrote: > > > /* Shortcut and audio panel keys */ > > > { KE_KEY, 0xe025, { KEY_PROG4 } }, > > > { KE_IGNORE, 0xe026, { KEY_RESERVED } }, > > > + { KE_KEY, 0xe029, { KEY_PROG4 } }, > > > > Hi! Above comment (Shortcut and audio panel keys) is

Re: [PATCH v3 5/5] dell-wmi: support Dell Inspiron M5110

2016-02-16 Thread Michał Kępień
> > /* Shortcut and audio panel keys */ > > { KE_KEY, 0xe025, { KEY_PROG4 } }, > > { KE_IGNORE, 0xe026, { KEY_RESERVED } }, > > + { KE_KEY, 0xe029, { KEY_PROG4 } }, > > Hi! Above comment (Shortcut and audio panel keys) is not relevant for > this 0xe029, right? I believe it is

Re: [PATCH v3 5/5] dell-wmi: support Dell Inspiron M5110

2016-02-16 Thread Michał Kępień
> > /* Shortcut and audio panel keys */ > > { KE_KEY, 0xe025, { KEY_PROG4 } }, > > { KE_IGNORE, 0xe026, { KEY_RESERVED } }, > > + { KE_KEY, 0xe029, { KEY_PROG4 } }, > > Hi! Above comment (Shortcut and audio panel keys) is not relevant for > this 0xe029, right? I believe it is

Re: [PATCH v3 5/5] dell-wmi: support Dell Inspiron M5110

2016-02-16 Thread Pali Rohár
On Tuesday 16 February 2016 15:50:30 Michał Kępień wrote: > /* Shortcut and audio panel keys */ > { KE_KEY, 0xe025, { KEY_PROG4 } }, > { KE_IGNORE, 0xe026, { KEY_RESERVED } }, > + { KE_KEY, 0xe029, { KEY_PROG4 } }, Hi! Above comment (Shortcut and audio panel keys) is not

Re: [PATCH v3 5/5] dell-wmi: support Dell Inspiron M5110

2016-02-16 Thread Pali Rohár
On Tuesday 16 February 2016 15:50:30 Michał Kępień wrote: > /* Shortcut and audio panel keys */ > { KE_KEY, 0xe025, { KEY_PROG4 } }, > { KE_IGNORE, 0xe026, { KEY_RESERVED } }, > + { KE_KEY, 0xe029, { KEY_PROG4 } }, Hi! Above comment (Shortcut and audio panel keys) is not