Re: [PATCH v4] debugobjects: scale the static pool size

2018-11-26 Thread Catalin Marinas
On Mon, Nov 26, 2018 at 04:45:54AM -0500, Qian Cai wrote: > On 11/25/18 11:52 PM, Qian Cai wrote: > > BTW, calling debug_objects_mem_init() before kmemleak_init() actually > > could trigger a loop on machines with 160+ CPUs until the pool is filled > > up, > > > > debug_objects_pool_min_level +=

Re: [PATCH v4] debugobjects: scale the static pool size

2018-11-26 Thread Catalin Marinas
On Mon, Nov 26, 2018 at 04:45:54AM -0500, Qian Cai wrote: > On 11/25/18 11:52 PM, Qian Cai wrote: > > BTW, calling debug_objects_mem_init() before kmemleak_init() actually > > could trigger a loop on machines with 160+ CPUs until the pool is filled > > up, > > > > debug_objects_pool_min_level +=

Re: [PATCH v4] debugobjects: scale the static pool size

2018-11-26 Thread Qian Cai
On 11/25/18 11:52 PM, Qian Cai wrote: On 11/25/18 8:31 PM, Waiman Long wrote: On 11/25/2018 03:42 PM, Qian Cai wrote: On 11/23/18 10:01 PM, Qian Cai wrote: On Nov 22, 2018, at 4:56 PM, Thomas Gleixner wrote: On Tue, 20 Nov 2018, Qian Cai wrote: Looking deeper at that. diff

Re: [PATCH v4] debugobjects: scale the static pool size

2018-11-26 Thread Qian Cai
On 11/25/18 11:52 PM, Qian Cai wrote: On 11/25/18 8:31 PM, Waiman Long wrote: On 11/25/2018 03:42 PM, Qian Cai wrote: On 11/23/18 10:01 PM, Qian Cai wrote: On Nov 22, 2018, at 4:56 PM, Thomas Gleixner wrote: On Tue, 20 Nov 2018, Qian Cai wrote: Looking deeper at that. diff

Re: [PATCH v4] debugobjects: scale the static pool size

2018-11-25 Thread Qian Cai
On 11/25/18 8:31 PM, Waiman Long wrote: On 11/25/2018 03:42 PM, Qian Cai wrote: On 11/23/18 10:01 PM, Qian Cai wrote: On Nov 22, 2018, at 4:56 PM, Thomas Gleixner wrote: On Tue, 20 Nov 2018, Qian Cai wrote: Looking deeper at that. diff --git a/lib/debugobjects.c

Re: [PATCH v4] debugobjects: scale the static pool size

2018-11-25 Thread Qian Cai
On 11/25/18 8:31 PM, Waiman Long wrote: On 11/25/2018 03:42 PM, Qian Cai wrote: On 11/23/18 10:01 PM, Qian Cai wrote: On Nov 22, 2018, at 4:56 PM, Thomas Gleixner wrote: On Tue, 20 Nov 2018, Qian Cai wrote: Looking deeper at that. diff --git a/lib/debugobjects.c

Re: [PATCH v4] debugobjects: scale the static pool size

2018-11-25 Thread Waiman Long
On 11/25/2018 03:42 PM, Qian Cai wrote: > > > On 11/23/18 10:01 PM, Qian Cai wrote: >> >> >>> On Nov 22, 2018, at 4:56 PM, Thomas Gleixner >>> wrote: >>> >>> On Tue, 20 Nov 2018, Qian Cai wrote: >>> >>> Looking deeper at that. >>> diff --git a/lib/debugobjects.c b/lib/debugobjects.c

Re: [PATCH v4] debugobjects: scale the static pool size

2018-11-25 Thread Waiman Long
On 11/25/2018 03:42 PM, Qian Cai wrote: > > > On 11/23/18 10:01 PM, Qian Cai wrote: >> >> >>> On Nov 22, 2018, at 4:56 PM, Thomas Gleixner >>> wrote: >>> >>> On Tue, 20 Nov 2018, Qian Cai wrote: >>> >>> Looking deeper at that. >>> diff --git a/lib/debugobjects.c b/lib/debugobjects.c

Re: [PATCH v4] debugobjects: scale the static pool size

2018-11-25 Thread Qian Cai
On 11/22/18 4:56 PM, Thomas Gleixner wrote: On Tue, 20 Nov 2018, Qian Cai wrote: Looking deeper at that. diff --git a/lib/debugobjects.c b/lib/debugobjects.c index 70935ed91125..140571aa483c 100644 --- a/lib/debugobjects.c +++ b/lib/debugobjects.c @@ -23,9 +23,81 @@ #define

Re: [PATCH v4] debugobjects: scale the static pool size

2018-11-25 Thread Qian Cai
On 11/22/18 4:56 PM, Thomas Gleixner wrote: On Tue, 20 Nov 2018, Qian Cai wrote: Looking deeper at that. diff --git a/lib/debugobjects.c b/lib/debugobjects.c index 70935ed91125..140571aa483c 100644 --- a/lib/debugobjects.c +++ b/lib/debugobjects.c @@ -23,9 +23,81 @@ #define

Re: [PATCH v4] debugobjects: scale the static pool size

2018-11-25 Thread Qian Cai
On 11/23/18 10:01 PM, Qian Cai wrote: On Nov 22, 2018, at 4:56 PM, Thomas Gleixner wrote: On Tue, 20 Nov 2018, Qian Cai wrote: Looking deeper at that. diff --git a/lib/debugobjects.c b/lib/debugobjects.c index 70935ed91125..140571aa483c 100644 --- a/lib/debugobjects.c +++

Re: [PATCH v4] debugobjects: scale the static pool size

2018-11-25 Thread Qian Cai
On 11/23/18 10:01 PM, Qian Cai wrote: On Nov 22, 2018, at 4:56 PM, Thomas Gleixner wrote: On Tue, 20 Nov 2018, Qian Cai wrote: Looking deeper at that. diff --git a/lib/debugobjects.c b/lib/debugobjects.c index 70935ed91125..140571aa483c 100644 --- a/lib/debugobjects.c +++

Re: [PATCH v4] debugobjects: scale the static pool size

2018-11-23 Thread Qian Cai
> On Nov 22, 2018, at 4:56 PM, Thomas Gleixner wrote: > > On Tue, 20 Nov 2018, Qian Cai wrote: > > Looking deeper at that. > >> diff --git a/lib/debugobjects.c b/lib/debugobjects.c >> index 70935ed91125..140571aa483c 100644 >> --- a/lib/debugobjects.c >> +++ b/lib/debugobjects.c >> @@ -23,9

Re: [PATCH v4] debugobjects: scale the static pool size

2018-11-23 Thread Qian Cai
> On Nov 22, 2018, at 4:56 PM, Thomas Gleixner wrote: > > On Tue, 20 Nov 2018, Qian Cai wrote: > > Looking deeper at that. > >> diff --git a/lib/debugobjects.c b/lib/debugobjects.c >> index 70935ed91125..140571aa483c 100644 >> --- a/lib/debugobjects.c >> +++ b/lib/debugobjects.c >> @@ -23,9

Re: [PATCH v4] debugobjects: scale the static pool size

2018-11-22 Thread Thomas Gleixner
On Tue, 20 Nov 2018, Qian Cai wrote: Looking deeper at that. > diff --git a/lib/debugobjects.c b/lib/debugobjects.c > index 70935ed91125..140571aa483c 100644 > --- a/lib/debugobjects.c > +++ b/lib/debugobjects.c > @@ -23,9 +23,81 @@ > #define ODEBUG_HASH_BITS 14 > #define ODEBUG_HASH_SIZE

Re: [PATCH v4] debugobjects: scale the static pool size

2018-11-22 Thread Thomas Gleixner
On Tue, 20 Nov 2018, Qian Cai wrote: Looking deeper at that. > diff --git a/lib/debugobjects.c b/lib/debugobjects.c > index 70935ed91125..140571aa483c 100644 > --- a/lib/debugobjects.c > +++ b/lib/debugobjects.c > @@ -23,9 +23,81 @@ > #define ODEBUG_HASH_BITS 14 > #define ODEBUG_HASH_SIZE

Re: [PATCH v4] debugobjects: scale the static pool size

2018-11-21 Thread Waiman Long
On 11/20/2018 09:11 PM, Qian Cai wrote: > The current value of the early boot static pool size is not big enough > for systems with large number of CPUs with timer or/and workqueue > objects selected. As the results, systems have 60+ CPUs with both timer > and workqueue objects enabled could

Re: [PATCH v4] debugobjects: scale the static pool size

2018-11-21 Thread Waiman Long
On 11/20/2018 09:11 PM, Qian Cai wrote: > The current value of the early boot static pool size is not big enough > for systems with large number of CPUs with timer or/and workqueue > objects selected. As the results, systems have 60+ CPUs with both timer > and workqueue objects enabled could