Re: [PATCH v4] perf diff: Report noisy for cycles diff

2019-08-15 Thread Jin, Yao
On 8/15/2019 9:23 PM, Jiri Olsa wrote: On Tue, Aug 13, 2019 at 03:30:37PM +0800, Jin Yao wrote: This patch prints the stddev and hist for the cycles diff of program block. It can help us to understand if the cycles is noisy or not. This patch is inspired by Andi Kleen's patch

Re: [PATCH v4] perf diff: Report noisy for cycles diff

2019-08-15 Thread Jin, Yao
On 8/15/2019 9:22 PM, Jiri Olsa wrote: On Tue, Aug 13, 2019 at 03:30:37PM +0800, Jin Yao wrote: SNIP static void hpp__entry_unpair(struct hist_entry *he, int idx, char *buf, size_t size) { @@ -1662,6 +1794,10 @@ static void data__hpp_register(struct data__file *d, int idx)

Re: [PATCH v4] perf diff: Report noisy for cycles diff

2019-08-15 Thread Jiri Olsa
On Tue, Aug 13, 2019 at 03:30:37PM +0800, Jin Yao wrote: > This patch prints the stddev and hist for the cycles diff of > program block. It can help us to understand if the cycles > is noisy or not. > > This patch is inspired by Andi Kleen's patch > https://lwn.net/Articles/600471/ now that we

Re: [PATCH v4] perf diff: Report noisy for cycles diff

2019-08-15 Thread Jiri Olsa
On Tue, Aug 13, 2019 at 03:30:37PM +0800, Jin Yao wrote: SNIP > static void > hpp__entry_unpair(struct hist_entry *he, int idx, char *buf, size_t size) > { > @@ -1662,6 +1794,10 @@ static void data__hpp_register(struct data__file *d, > int idx) > fmt->color = hpp__color_cycles;