Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

On 15/09/15 03:52, Dmitry Torokhov wrote: On Mon, Sep 14, 2015 at 4:16 AM, Sudeep Holla wrote: [...] This is wrong assumption in the driver. enable_irq_wake doesn't implicitly enable the IRQ. So the disable_irq should be moved to else. And the resume patch also needs to be fixed

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

On 15/09/15 03:52, Dmitry Torokhov wrote: On Mon, Sep 14, 2015 at 4:16 AM, Sudeep Holla wrote: [...] This is wrong assumption in the driver. enable_irq_wake doesn't implicitly enable the IRQ. So the disable_irq should be moved to else. And the resume patch also

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

On Mon, Sep 14, 2015 at 4:16 AM, Sudeep Holla wrote: > > > On 12/09/15 10:50, maoguang meng wrote: >> hi Sudeep: >> >> I test flowlling your blow suggestions,but the system can not be woken. >> >> beacuse,mtk_eint_suspend will mask it.As we know if eint wakeup system >> it must be unmasked before

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

Adding dtor & linux-input as we are now discussing the elan trackpad driver... On Mon, Sep 14, 2015 at 7:16 PM, Sudeep Holla wrote: > > > On 12/09/15 10:50, maoguang meng wrote: >> hi Sudeep: >> >> I test flowlling your blow suggestions,but the system can not be woken. >> >>

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

On 12/09/15 10:50, maoguang meng wrote: > hi Sudeep: > > I test flowlling your blow suggestions,but the system can not be woken. > > beacuse,mtk_eint_suspend will mask it.As we know if eint wakeup system > it must be unmasked before enter suspend flow. > > e.x > > static int __maybe_unused

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

On 12/09/15 10:50, maoguang meng wrote: > hi Sudeep: > > I test flowlling your blow suggestions,but the system can not be woken. > > beacuse,mtk_eint_suspend will mask it.As we know if eint wakeup system > it must be unmasked before enter suspend flow. > > e.x > > static int __maybe_unused

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

Adding dtor & linux-input as we are now discussing the elan trackpad driver... On Mon, Sep 14, 2015 at 7:16 PM, Sudeep Holla wrote: > > > On 12/09/15 10:50, maoguang meng wrote: >> hi Sudeep: >> >> I test flowlling your blow suggestions,but the system can not be woken. >>

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

On Mon, Sep 14, 2015 at 4:16 AM, Sudeep Holla wrote: > > > On 12/09/15 10:50, maoguang meng wrote: >> hi Sudeep: >> >> I test flowlling your blow suggestions,but the system can not be woken. >> >> beacuse,mtk_eint_suspend will mask it.As we know if eint wakeup system >> it

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

hi Sudeep: I test flowlling your blow suggestions,but the system can not be woken. beacuse,mtk_eint_suspend will mask it.As we know if eint wakeup system it must be unmasked before enter suspend flow. e.x static int __maybe_unused elan_suspend(struct device *dev) { struct i2c_client

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

hi Sudeep: I test flowlling your blow suggestions,but the system can not be woken. beacuse,mtk_eint_suspend will mask it.As we know if eint wakeup system it must be unmasked before enter suspend flow. e.x static int __maybe_unused elan_suspend(struct device *dev) { struct i2c_client

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

On 11/09/15 12:22, Chung-Yih Wang (王崇懿) wrote: Hi Sudeep and Maoguang, Please correct me if I am wrong. I think the wake_mask Maoguang implemented is the wake-up configuration and it is how he disabled other unwanted interrupt sources(e.g. audio jacket insertion) during suspend. OK,

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

Hi Sudeep and Maoguang, Please correct me if I am wrong. I think the wake_mask Maoguang implemented is the wake-up configuration and it is how he disabled other unwanted interrupt sources(e.g. audio jacket insertion) during suspend. With Sudeep's patch which we had similar one before, the

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

Hi Sudeep and Maoguang, Please correct me if I am wrong. I think the wake_mask Maoguang implemented is the wake-up configuration and it is how he disabled other unwanted interrupt sources(e.g. audio jacket insertion) during suspend. With Sudeep's patch which we had similar one before, the

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

On 11/09/15 12:22, Chung-Yih Wang (王崇懿) wrote: Hi Sudeep and Maoguang, Please correct me if I am wrong. I think the wake_mask Maoguang implemented is the wake-up configuration and it is how he disabled other unwanted interrupt sources(e.g. audio jacket insertion) during suspend. OK,

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

On 08/09/15 10:28, Sudeep Holla wrote: On 06/09/15 11:39, maoguang meng wrote: On Wed, 2015-09-02 at 14:02 +0800, Daniel Kurtz wrote: Hi maoguang, On Tue, Aug 25, 2015 at 12:27 AM, Sudeep Holla wrote: On 14/08/15 09:38, maoguang.m...@mediatek.com wrote: From: Maoguang Meng This

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

On 06/09/15 11:39, maoguang meng wrote: On Wed, 2015-09-02 at 14:02 +0800, Daniel Kurtz wrote: Hi maoguang, On Tue, Aug 25, 2015 at 12:27 AM, Sudeep Holla wrote: On 14/08/15 09:38, maoguang.m...@mediatek.com wrote: From: Maoguang Meng This patch implement irq_set_wake to get who is

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

On 06/09/15 11:39, maoguang meng wrote: On Wed, 2015-09-02 at 14:02 +0800, Daniel Kurtz wrote: Hi maoguang, On Tue, Aug 25, 2015 at 12:27 AM, Sudeep Holla wrote: On 14/08/15 09:38, maoguang.m...@mediatek.com wrote: From: Maoguang Meng

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

On 08/09/15 10:28, Sudeep Holla wrote: On 06/09/15 11:39, maoguang meng wrote: On Wed, 2015-09-02 at 14:02 +0800, Daniel Kurtz wrote: Hi maoguang, On Tue, Aug 25, 2015 at 12:27 AM, Sudeep Holla wrote: On 14/08/15 09:38, maoguang.m...@mediatek.com wrote: From:

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

On Wed, 2015-09-02 at 14:02 +0800, Daniel Kurtz wrote: > Hi maoguang, > > On Tue, Aug 25, 2015 at 12:27 AM, Sudeep Holla wrote: > > > > > > On 14/08/15 09:38, maoguang.m...@mediatek.com wrote: > >> > >> From: Maoguang Meng > >> > >> This patch implement irq_set_wake to get who is wakeup source

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

On Wed, 2015-09-02 at 14:02 +0800, Daniel Kurtz wrote: > Hi maoguang, > > On Tue, Aug 25, 2015 at 12:27 AM, Sudeep Holla wrote: > > > > > > On 14/08/15 09:38, maoguang.m...@mediatek.com wrote: > >> > >> From: Maoguang Meng > >> > >> This patch

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

Hi maoguang, On Tue, Aug 25, 2015 at 12:27 AM, Sudeep Holla wrote: > > > On 14/08/15 09:38, maoguang.m...@mediatek.com wrote: >> >> From: Maoguang Meng >> >> This patch implement irq_set_wake to get who is wakeup source and >> setup on suspend resume. >> >> Signed-off-by: Maoguang Meng >>

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

Hi maoguang, On Tue, Aug 25, 2015 at 12:27 AM, Sudeep Holla wrote: > > > On 14/08/15 09:38, maoguang.m...@mediatek.com wrote: >> >> From: Maoguang Meng >> >> This patch implement irq_set_wake to get who is wakeup source and >> setup on suspend

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

On Fri, Aug 14, 2015 at 10:38 AM, wrote: > From: Maoguang Meng > > This patch implement irq_set_wake to get who is wakeup source and > setup on suspend resume. > > Signed-off-by: Maoguang Meng > > --- > changes since v3: > -add a comment in mtk_eint_chip_read_mask. > -delete ALIGN when

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

On Fri, Aug 14, 2015 at 10:38 AM, maoguang.m...@mediatek.com wrote: From: Maoguang Meng maoguang.m...@mediatek.com This patch implement irq_set_wake to get who is wakeup source and setup on suspend resume. Signed-off-by: Maoguang Meng maoguang.m...@mediatek.com --- changes since v3:

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

On 14/08/15 09:38, maoguang.m...@mediatek.com wrote: From: Maoguang Meng This patch implement irq_set_wake to get who is wakeup source and setup on suspend resume. Signed-off-by: Maoguang Meng --- changes since v3: -add a comment in mtk_eint_chip_read_mask. -delete ALIGN when allocate

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

On 14/08/15 09:38, maoguang.m...@mediatek.com wrote: From: Maoguang Meng maoguang.m...@mediatek.com This patch implement irq_set_wake to get who is wakeup source and setup on suspend resume. Signed-off-by: Maoguang Meng maoguang.m...@mediatek.com --- changes since v3: -add a comment in

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

On Mon, 2015-08-17 at 21:25 +0800, Yingjoe Chen wrote: > On Mon, 2015-08-17 at 17:09 +0800, Daniel Kurtz wrote: > > On Mon, Aug 17, 2015 at 3:52 PM, Yingjoe Chen > > wrote: > > > On Fri, 2015-08-14 at 16:38 +0800, maoguang.m...@mediatek.com wrote: > > >> From: Maoguang Meng > > >> > > >> This

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

On Mon, 2015-08-17 at 17:09 +0800, Daniel Kurtz wrote: > On Mon, Aug 17, 2015 at 3:52 PM, Yingjoe Chen > wrote: > > On Fri, 2015-08-14 at 16:38 +0800, maoguang.m...@mediatek.com wrote: > >> From: Maoguang Meng > >> > >> This patch implement irq_set_wake to get who is wakeup source and > >>

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

On Mon, Aug 17, 2015 at 3:52 PM, Yingjoe Chen wrote: > On Fri, 2015-08-14 at 16:38 +0800, maoguang.m...@mediatek.com wrote: >> From: Maoguang Meng >> >> This patch implement irq_set_wake to get who is wakeup source and >> setup on suspend resume. >> >> Signed-off-by: Maoguang Meng >> >> --- >>

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

On Fri, 2015-08-14 at 16:38 +0800, maoguang.m...@mediatek.com wrote: > From: Maoguang Meng > > This patch implement irq_set_wake to get who is wakeup source and > setup on suspend resume. > > Signed-off-by: Maoguang Meng > > --- > changes since v3: > -add a comment in mtk_eint_chip_read_mask.

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

On Mon, 2015-08-17 at 21:25 +0800, Yingjoe Chen wrote: On Mon, 2015-08-17 at 17:09 +0800, Daniel Kurtz wrote: On Mon, Aug 17, 2015 at 3:52 PM, Yingjoe Chen yingjoe.c...@mediatek.com wrote: On Fri, 2015-08-14 at 16:38 +0800, maoguang.m...@mediatek.com wrote: From: Maoguang Meng

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

On Mon, Aug 17, 2015 at 3:52 PM, Yingjoe Chen yingjoe.c...@mediatek.com wrote: On Fri, 2015-08-14 at 16:38 +0800, maoguang.m...@mediatek.com wrote: From: Maoguang Meng maoguang.m...@mediatek.com This patch implement irq_set_wake to get who is wakeup source and setup on suspend resume.

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

On Mon, 2015-08-17 at 17:09 +0800, Daniel Kurtz wrote: On Mon, Aug 17, 2015 at 3:52 PM, Yingjoe Chen yingjoe.c...@mediatek.com wrote: On Fri, 2015-08-14 at 16:38 +0800, maoguang.m...@mediatek.com wrote: From: Maoguang Meng maoguang.m...@mediatek.com This patch implement irq_set_wake to

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

On Fri, 2015-08-14 at 16:38 +0800, maoguang.m...@mediatek.com wrote: From: Maoguang Meng maoguang.m...@mediatek.com This patch implement irq_set_wake to get who is wakeup source and setup on suspend resume. Signed-off-by: Maoguang Meng maoguang.m...@mediatek.com --- changes since v3:

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

On Fri, Aug 14, 2015 at 4:38 PM, wrote: > > From: Maoguang Meng > > This patch implement irq_set_wake to get who is wakeup source and > setup on suspend resume. > > Signed-off-by: Maoguang Meng Reviewed-by: Daniel Kurtz Thanks! -Dan > > --- > changes since v3: > -add a comment in

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

On Fri, Aug 14, 2015 at 4:38 PM, maoguang.m...@mediatek.com wrote: From: Maoguang Meng maoguang.m...@mediatek.com This patch implement irq_set_wake to get who is wakeup source and setup on suspend resume. Signed-off-by: Maoguang Meng maoguang.m...@mediatek.com Reviewed-by: Daniel Kurtz