Re: [PATCH v4 07/18] x86/intel_rdt: Add Haswell feature discovery

2016-10-17 Thread Thomas Gleixner
On Fri, 14 Oct 2016, Fenghua Yu wrote: > +static inline bool cache_alloc_hsw_probe(void) > +{ > + u32 l, h; > + u32 max_cbm = BIT_MASK(20) - 1; Two options here: + u32 l, h, max_cbm = BIT_MASK(20) - 1; or + u32 max_cbm = BIT_MASK(20) - 1; + u32 l, h; I personally

Re: [PATCH v4 07/18] x86/intel_rdt: Add Haswell feature discovery

2016-10-17 Thread Thomas Gleixner
On Fri, 14 Oct 2016, Fenghua Yu wrote: > +static inline bool cache_alloc_hsw_probe(void) > +{ > + u32 l, h; > + u32 max_cbm = BIT_MASK(20) - 1; Two options here: + u32 l, h, max_cbm = BIT_MASK(20) - 1; or + u32 max_cbm = BIT_MASK(20) - 1; + u32 l, h; I personally