Re: [PATCH v4 07/45] powerpc/ptdump: Limit size of flags text to 1/2 chars on PPC32
Christophe Leroy writes: > Le 25/05/2020 à 07:15, Michael Ellerman a écrit : >> Christophe Leroy writes: >>> In order to have all flags fit on a 80 chars wide screen, >>> reduce the flags to 1 char (2 where ambiguous). >> >> I don't love this, the output is less readable. Is fitting on an 80 char >> screen a real issue for you? I just make my terminal window bigger. > > I don't have strong opinion about that, and the terminal can be made bigger. > I just don't like how messy it is, some flags are so big that they hide > other ones and getting it more ordered and more compact helped me during > all the verifications I did with this series, but we can leave it as is > if you prefer. I think I do. > Would you like a v5 without patches 7 and 8 ? Or I can just resend the > patches that will be impacted, that is 9 and 38 ? I dropped 7 and 8 and then fixed up 9 and 38, it was easy enough. I used "coherent" and "huge". > With the change I get. > > ---[ Start of kernel VM ]--- > 0xc000-0xc0ff 0x16M h r x psh a > 0xc100-0xc7ff 0x0100 112M h rw psh d a > ---[ vmalloc() Area ]--- > 0xc900-0xc9003fff 0x050e400016K rw psh d a > 0xc9008000-0xc900bfff 0x050ec00016K rw psh d a > 0xc901-0xc9013fff 0xd00016K rw p i g sh d a > 0xc9018000-0xc901bfff 0x050f16K rw psh d a It's definitely more compact :) But I worry no one other than you will be able to decipher it, without constantly referring back to the source code. cheers
Re: [PATCH v4 07/45] powerpc/ptdump: Limit size of flags text to 1/2 chars on PPC32
Le 25/05/2020 à 07:15, Michael Ellerman a écrit : Christophe Leroy writes: In order to have all flags fit on a 80 chars wide screen, reduce the flags to 1 char (2 where ambiguous). I don't love this, the output is less readable. Is fitting on an 80 char screen a real issue for you? I just make my terminal window bigger. I don't have strong opinion about that, and the terminal can be made bigger. I just don't like how messy it is, some flags are so big that they hide other ones and getting it more ordered and more compact helped me during all the verifications I did with this series, but we can leave it as is if you prefer. Would you like a v5 without patches 7 and 8 ? Or I can just resend the patches that will be impacted, that is 9 and 38 ? Without the changes I get: ---[ Start of kernel VM ]--- 0xc000-0xc0ff 0x16M huge shared rX present accessed 0xc100-0xc7ff 0x0100 112M huge shared rw present dirty accessed ---[ vmalloc() Area ]--- 0xc900-0xc9003fff 0x050e400016K shared rw present dirty accessed 0xc9008000-0xc900bfff 0x050ec00016K shared rw present dirty accessed 0xc901-0xc9013fff 0xd00016K shared rw present guarded dirty accessed no cache 0xc9018000-0xc901bfff 0x050f16K shared rw present dirty accessed ---[ Fixmap start ]--- 0xf7f0-0xf7f7 0xff00 512K huge shared rw present guarded dirty accessed no cache ---[ Fixmap end ]--- ---[ kasan shadow mem start ]--- 0xf800-0xf8ff 0x070016M huge shared rw present dirty accessed 0xf900-0xf91f [0x01288000] 16K shared r present accessed 0xf920-0xf9203fff 0x050e16K shared rw present dirty accessed With the change I get. ---[ Start of kernel VM ]--- 0xc000-0xc0ff 0x16M h r x psh a 0xc100-0xc7ff 0x0100 112M h rw psh d a ---[ vmalloc() Area ]--- 0xc900-0xc9003fff 0x050e400016K rw psh d a 0xc9008000-0xc900bfff 0x050ec00016K rw psh d a 0xc901-0xc9013fff 0xd00016K rw p i g sh d a 0xc9018000-0xc901bfff 0x050f16K rw psh d a ---[ Fixmap start ]--- 0xf7f0-0xf7f7 0xff00 512K h rw p i g sh d a ---[ Fixmap end ]--- ---[ kasan shadow mem start ]--- 0xf800-0xf8ff 0x070016M h rw psh d a 0xf900-0xf91f [0x01288000] 16K r psh a 0xf920-0xf9203fff 0x050e16K rw psh d a Christophe cheers No cache is 'i' User is 'ur' (Supervisor would be sr) Shared (for 8xx) becomes 'sh' (it was 'user' when not shared but that was ambiguous because that's not entirely right) Signed-off-by: Christophe Leroy --- arch/powerpc/mm/ptdump/8xx.c| 33 --- arch/powerpc/mm/ptdump/shared.c | 35 + 2 files changed, 35 insertions(+), 33 deletions(-)
Re: [PATCH v4 07/45] powerpc/ptdump: Limit size of flags text to 1/2 chars on PPC32
Christophe Leroy writes: > In order to have all flags fit on a 80 chars wide screen, > reduce the flags to 1 char (2 where ambiguous). I don't love this, the output is less readable. Is fitting on an 80 char screen a real issue for you? I just make my terminal window bigger. cheers > No cache is 'i' > User is 'ur' (Supervisor would be sr) > Shared (for 8xx) becomes 'sh' (it was 'user' when not shared but > that was ambiguous because that's not entirely right) > > Signed-off-by: Christophe Leroy > --- > arch/powerpc/mm/ptdump/8xx.c| 33 --- > arch/powerpc/mm/ptdump/shared.c | 35 + > 2 files changed, 35 insertions(+), 33 deletions(-)
