Re: [PATCH v4 09/10] x86/jump-label: remove support for custom poker
From: Peter Zijlstra Sent: November 11, 2018 at 3:05:53 PM GMT > To: Nadav Amit > Cc: Ingo Molnar , linux-kernel@vger.kernel.org, > x...@kernel.org, H. Peter Anvin , Thomas Gleixner > , Borislav Petkov , Dave Hansen > , Andy Lutomirski , Kees Cook > , Dave Hansen , Masami > Hiramatsu > Subject: Re: [PATCH v4 09/10] x86/jump-label: remove support for custom poker > > > On Sat, Nov 10, 2018 at 03:17:31PM -0800, Nadav Amit wrote: >> There are only two types of poking: early and breakpoint based. The use >> of a function pointer to perform poking complicates the code and is >> probably inefficient due to the use of indirect branches. > > Right; we used to have a 3rd way, but that is long gone. > > Nice cleanup! Thanks, but I actually should have got rid of the early_poking variable. I will do it for v5.
Re: [PATCH v4 09/10] x86/jump-label: remove support for custom poker
From: Peter Zijlstra Sent: November 11, 2018 at 3:05:53 PM GMT > To: Nadav Amit > Cc: Ingo Molnar , linux-kernel@vger.kernel.org, > x...@kernel.org, H. Peter Anvin , Thomas Gleixner > , Borislav Petkov , Dave Hansen > , Andy Lutomirski , Kees Cook > , Dave Hansen , Masami > Hiramatsu > Subject: Re: [PATCH v4 09/10] x86/jump-label: remove support for custom poker > > > On Sat, Nov 10, 2018 at 03:17:31PM -0800, Nadav Amit wrote: >> There are only two types of poking: early and breakpoint based. The use >> of a function pointer to perform poking complicates the code and is >> probably inefficient due to the use of indirect branches. > > Right; we used to have a 3rd way, but that is long gone. > > Nice cleanup! Thanks, but I actually should have got rid of the early_poking variable. I will do it for v5.
Re: [PATCH v4 09/10] x86/jump-label: remove support for custom poker
On Sat, Nov 10, 2018 at 03:17:31PM -0800, Nadav Amit wrote: > There are only two types of poking: early and breakpoint based. The use > of a function pointer to perform poking complicates the code and is > probably inefficient due to the use of indirect branches. Right; we used to have a 3rd way, but that is long gone. Nice cleanup!
Re: [PATCH v4 09/10] x86/jump-label: remove support for custom poker
On Sat, Nov 10, 2018 at 03:17:31PM -0800, Nadav Amit wrote: > There are only two types of poking: early and breakpoint based. The use > of a function pointer to perform poking complicates the code and is > probably inefficient due to the use of indirect branches. Right; we used to have a 3rd way, but that is long gone. Nice cleanup!
