Re: [PATCH v4 1/3] lib: add bitrev8x4()

Hi Joshua, On Thu, 1 Dec 2016 16:04:09 -0800 Joshua Clayton stillcompil...@gmail.com wrote: ... >>> +static __always_inline __attribute_const__ u32 __arch_bitrev8x4(u32 x) >>> +{ >>> + __asm__ ("rbit %0, %1; rev %0, %0" : "=r" (x) : "r" (x)); >> return x; >Oops thats a little

Re: [PATCH v4 1/3] lib: add bitrev8x4()

Hi Joshua, On Thu, 1 Dec 2016 16:04:09 -0800 Joshua Clayton stillcompil...@gmail.com wrote: ... >>> +static __always_inline __attribute_const__ u32 __arch_bitrev8x4(u32 x) >>> +{ >>> + __asm__ ("rbit %0, %1; rev %0, %0" : "=r" (x) : "r" (x)); >> return x; >Oops thats a little

Re: [PATCH v4 1/3] lib: add bitrev8x4()

Hello Anatolij, Thanks for the review. On 12/01/2016 02:45 PM, Anatolij Gustschin wrote: > On Thu, 1 Dec 2016 09:04:50 -0800 > Joshua Clayton stillcompil...@gmail.com wrote: > ... >> diff --git a/arch/arm/include/asm/bitrev.h b/arch/arm/include/asm/bitrev.h >> index ec291c3..6d2e9ca 100644 >>

Re: [PATCH v4 1/3] lib: add bitrev8x4()

Hello Anatolij, Thanks for the review. On 12/01/2016 02:45 PM, Anatolij Gustschin wrote: > On Thu, 1 Dec 2016 09:04:50 -0800 > Joshua Clayton stillcompil...@gmail.com wrote: > ... >> diff --git a/arch/arm/include/asm/bitrev.h b/arch/arm/include/asm/bitrev.h >> index ec291c3..6d2e9ca 100644 >>

Re: [PATCH v4 1/3] lib: add bitrev8x4()

On Thu, 1 Dec 2016 09:04:50 -0800 Joshua Clayton stillcompil...@gmail.com wrote: ... >diff --git a/arch/arm/include/asm/bitrev.h b/arch/arm/include/asm/bitrev.h >index ec291c3..6d2e9ca 100644 >--- a/arch/arm/include/asm/bitrev.h >+++ b/arch/arm/include/asm/bitrev.h >@@ -17,4 +17,9 @@ static

Re: [PATCH v4 1/3] lib: add bitrev8x4()

On Thu, 1 Dec 2016 09:04:50 -0800 Joshua Clayton stillcompil...@gmail.com wrote: ... >diff --git a/arch/arm/include/asm/bitrev.h b/arch/arm/include/asm/bitrev.h >index ec291c3..6d2e9ca 100644 >--- a/arch/arm/include/asm/bitrev.h >+++ b/arch/arm/include/asm/bitrev.h >@@ -17,4 +17,9 @@ static