Re: [PATCH v4 16/24] fpga: dfl: add fpga manager platform driver for FME

2018-04-06 Thread Wu Hao
On Thu, Apr 05, 2018 at 01:45:07PM -0500, Alan Tull wrote: > On Thu, Mar 22, 2018 at 1:07 AM, Wu Hao wrote: > > On Wed, Mar 21, 2018 at 09:55:52AM -0700, Moritz Fischer wrote: > >> On Wed, Mar 21, 2018 at 10:50:01AM +0800, Wu Hao wrote: > >> > On Tue, Mar 20, 2018 at 03:32:34PM -0500, Alan Tull wr

Re: [PATCH v4 16/24] fpga: dfl: add fpga manager platform driver for FME

2018-04-05 Thread Alan Tull
On Thu, Mar 22, 2018 at 1:07 AM, Wu Hao wrote: > On Wed, Mar 21, 2018 at 09:55:52AM -0700, Moritz Fischer wrote: >> On Wed, Mar 21, 2018 at 10:50:01AM +0800, Wu Hao wrote: >> > On Tue, Mar 20, 2018 at 03:32:34PM -0500, Alan Tull wrote: >> > > On Tue, Feb 13, 2018 at 3:24 AM, Wu Hao wrote: >> > >

Re: [PATCH v4 16/24] fpga: dfl: add fpga manager platform driver for FME

2018-03-21 Thread Wu Hao
On Wed, Mar 21, 2018 at 09:55:52AM -0700, Moritz Fischer wrote: > On Wed, Mar 21, 2018 at 10:50:01AM +0800, Wu Hao wrote: > > On Tue, Mar 20, 2018 at 03:32:34PM -0500, Alan Tull wrote: > > > On Tue, Feb 13, 2018 at 3:24 AM, Wu Hao wrote: > > > > > > Hi Hao, > > > > > > Elsewhere we discussed mov

Re: [PATCH v4 16/24] fpga: dfl: add fpga manager platform driver for FME

2018-03-21 Thread Moritz Fischer
On Wed, Mar 21, 2018 at 10:50:01AM +0800, Wu Hao wrote: > On Tue, Mar 20, 2018 at 03:32:34PM -0500, Alan Tull wrote: > > On Tue, Feb 13, 2018 at 3:24 AM, Wu Hao wrote: > > > > Hi Hao, > > > > Elsewhere we discussed moving #defines used only in this driver either > > to this .c file or to a simil

Re: [PATCH v4 16/24] fpga: dfl: add fpga manager platform driver for FME

2018-03-20 Thread Wu Hao
On Tue, Mar 20, 2018 at 03:32:34PM -0500, Alan Tull wrote: > On Tue, Feb 13, 2018 at 3:24 AM, Wu Hao wrote: > > Hi Hao, > > Elsewhere we discussed moving #defines used only in this driver either > to this .c file or to a similarly named .h file. A couple minor > things below. Hi Alan, Yes, I

Re: [PATCH v4 16/24] fpga: dfl: add fpga manager platform driver for FME

2018-03-20 Thread Alan Tull
On Tue, Feb 13, 2018 at 3:24 AM, Wu Hao wrote: Hi Hao, Elsewhere we discussed moving #defines used only in this driver either to this .c file or to a similarly named .h file. A couple minor things below. > This patch adds fpga manager driver for FPGA Management Engine (FME). It > implements fp