Re: [PATCH v4 2/5] phy: Add LVDS configuration options

2021-03-25 Thread Liu Ying
Hi Vinod, On Thu, 2021-03-25 at 12:58 +0530, Vinod Koul wrote: > On 18-03-21, 10:22, Liu Ying wrote: > > > > Can we have these in kernel-doc style please, similar to style in > > > linux/phy/phy.h > > > > I take this way of in-line member documentation comment for the below 3 > > reasons: > >

Re: [PATCH v4 2/5] phy: Add LVDS configuration options

2021-03-25 Thread Vinod Koul
On 18-03-21, 10:22, Liu Ying wrote: > > Can we have these in kernel-doc style please, similar to style in > > linux/phy/phy.h > > I take this way of in-line member documentation comment for the below 3 > reasons: > > 1) Members of struct phy_configure_opts_mipi_dphy and > struct

Re: [PATCH v4 2/5] phy: Add LVDS configuration options

2021-03-17 Thread Liu Ying
Hi Vinod, On Wed, 2021-03-17 at 15:52 +0530, Vinod Koul wrote: > On 08-03-21, 11:52, Liu Ying wrote: > > This patch allows LVDS PHYs to be configured through > > the generic functions and through a custom structure > > added to the generic union. > > > > The parameters added here are based on

Re: [PATCH v4 2/5] phy: Add LVDS configuration options

2021-03-17 Thread Vinod Koul
On 08-03-21, 11:52, Liu Ying wrote: > This patch allows LVDS PHYs to be configured through > the generic functions and through a custom structure > added to the generic union. > > The parameters added here are based on common LVDS PHY > implementation practices. The set of parameters > should