Re: [PATCH v4 3/5] ghes_edac: add platform check to enable ghes_edac

2017-08-31 Thread Borislav Petkov
On Thu, Aug 31, 2017 at 04:17:07PM +, Kani, Toshimitsu wrote: > I followed in the footsteps of 'ghes_disable', which is also a kernel > boot option and uses 0. Ok, ghes_disable comment says that using module_param() is easier. ghes_edac is not a module but then __setup() is for "really core

Re: [PATCH v4 3/5] ghes_edac: add platform check to enable ghes_edac

2017-08-31 Thread Borislav Petkov
On Thu, Aug 31, 2017 at 04:17:07PM +, Kani, Toshimitsu wrote: > I followed in the footsteps of 'ghes_disable', which is also a kernel > boot option and uses 0. Ok, ghes_disable comment says that using module_param() is easier. ghes_edac is not a module but then __setup() is for "really core

Re: [PATCH v4 3/5] ghes_edac: add platform check to enable ghes_edac

2017-08-31 Thread Kani, Toshimitsu
On Thu, 2017-08-31 at 12:56 +0200, Borislav Petkov wrote: > On Wed, Aug 23, 2017 at 04:54:45PM -0600, Toshi Kani wrote: : > > --- > >  drivers/edac/ghes_edac.c |   29 - > >  1 file changed, 24 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/edac/ghes_edac.c

Re: [PATCH v4 3/5] ghes_edac: add platform check to enable ghes_edac

2017-08-31 Thread Kani, Toshimitsu
On Thu, 2017-08-31 at 12:56 +0200, Borislav Petkov wrote: > On Wed, Aug 23, 2017 at 04:54:45PM -0600, Toshi Kani wrote: : > > --- > >  drivers/edac/ghes_edac.c |   29 - > >  1 file changed, 24 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/edac/ghes_edac.c

Re: [PATCH v4 3/5] ghes_edac: add platform check to enable ghes_edac

2017-08-31 Thread Borislav Petkov
On Wed, Aug 23, 2017 at 04:54:45PM -0600, Toshi Kani wrote: > The ghes_edac driver was introduced in 2013 [1], but it has not > been enabled by any distro yet. This driver obtains error info > from firmware interfaces, which are not properly implemented on > many platforms, as the driver always

Re: [PATCH v4 3/5] ghes_edac: add platform check to enable ghes_edac

2017-08-31 Thread Borislav Petkov
On Wed, Aug 23, 2017 at 04:54:45PM -0600, Toshi Kani wrote: > The ghes_edac driver was introduced in 2013 [1], but it has not > been enabled by any distro yet. This driver obtains error info > from firmware interfaces, which are not properly implemented on > many platforms, as the driver always