RE: [PATCH v4 6/7] typec: tcpm: Represent source supply through power_supply class

2018-02-09 Thread Adam Thomson
On 08 February 2018 10:45, Heikki Krogerus wrote: Hi Heikki, Comments in-line as usual. Bit verbose, and may have stated the obvious in places, but trying to build a picture and aim for something sensible. > Hi Adam, > > On Tue, Feb 06, 2018 at 03:51:26PM +, Adam Thomson wrote: > > Right now

Re: [PATCH v4 6/7] typec: tcpm: Represent source supply through power_supply class

2018-02-08 Thread Heikki Krogerus
Hi Adam, On Tue, Feb 06, 2018 at 03:51:26PM +, Adam Thomson wrote: > Right now there is no documentation for the generic psy class. The stuff in > sysfs-class-power is device specific property information, and the same goes > for > sysfs-class-power-twl4030. The property usage can vary depend

RE: [PATCH v4 6/7] typec: tcpm: Represent source supply through power_supply class

2018-02-06 Thread Adam Thomson
On 30 January 2018 13:12, Heikki Krogerus wrote: > Hi Adam, > > On Tue, Jan 02, 2018 at 03:50:54PM +, Adam Thomson wrote: > > This commit adds a power_supply class instance to represent a > > PD source's voltage and current properties. This provides an > > interface for reading these propertie

Re: [PATCH v4 6/7] typec: tcpm: Represent source supply through power_supply class

2018-01-30 Thread Heikki Krogerus
Hi Adam, On Tue, Jan 02, 2018 at 03:50:54PM +, Adam Thomson wrote: > This commit adds a power_supply class instance to represent a > PD source's voltage and current properties. This provides an > interface for reading these properties from user-space or other > drivers. > > For PPS enabled So