Re: [PATCH v4 6/8] PCI: Rework of_pci_get_host_bridge_resources() to devm_of_pci_get_host_bridge_resources()

2018-05-15 Thread Andy Shevchenko
On Tue, May 15, 2018 at 7:48 PM, Andy Shevchenko wrote: > On Tue, May 15, 2018 at 12:07 PM, Jan Kiszka wrote: >> + devm_kfree(dev, res); devm_kfree() makes my eyes hurt. > res = devm_kmemdump(); devm_kmemdup(); --

Re: [PATCH v4 6/8] PCI: Rework of_pci_get_host_bridge_resources() to devm_of_pci_get_host_bridge_resources()

2018-05-15 Thread Andy Shevchenko
On Tue, May 15, 2018 at 7:48 PM, Andy Shevchenko wrote: > On Tue, May 15, 2018 at 12:07 PM, Jan Kiszka wrote: >> + devm_kfree(dev, res); devm_kfree() makes my eyes hurt. > res = devm_kmemdump(); devm_kmemdup(); -- With Best Regards, Andy Shevchenko

Re: [PATCH v4 6/8] PCI: Rework of_pci_get_host_bridge_resources() to devm_of_pci_get_host_bridge_resources()

2018-05-15 Thread Andy Shevchenko
On Tue, May 15, 2018 at 12:07 PM, Jan Kiszka wrote: > From: Jan Kiszka > > of_pci_get_host_bridge_resources() allocates the resource structures it > fills dynamically, but none of its callers care to release them so far. > Rather than requiring

Re: [PATCH v4 6/8] PCI: Rework of_pci_get_host_bridge_resources() to devm_of_pci_get_host_bridge_resources()

2018-05-15 Thread Andy Shevchenko
On Tue, May 15, 2018 at 12:07 PM, Jan Kiszka wrote: > From: Jan Kiszka > > of_pci_get_host_bridge_resources() allocates the resource structures it > fills dynamically, but none of its callers care to release them so far. > Rather than requiring everyone to do this explicitly, convert the >

Re: [PATCH v4 6/8] PCI: Rework of_pci_get_host_bridge_resources() to devm_of_pci_get_host_bridge_resources()

2018-05-15 Thread Jingoo Han
On Tuesday, May 15, 2018 5:07 AM, Jan Kiszka wrote: > > From: Jan Kiszka > > of_pci_get_host_bridge_resources() allocates the resource structures it > fills dynamically, but none of its callers care to release them so far. > Rather than requiring everyone to do this

Re: [PATCH v4 6/8] PCI: Rework of_pci_get_host_bridge_resources() to devm_of_pci_get_host_bridge_resources()

2018-05-15 Thread Jingoo Han
On Tuesday, May 15, 2018 5:07 AM, Jan Kiszka wrote: > > From: Jan Kiszka > > of_pci_get_host_bridge_resources() allocates the resource structures it > fills dynamically, but none of its callers care to release them so far. > Rather than requiring everyone to do this explicitly, convert the >

Re: [PATCH v4 6/8] PCI: Rework of_pci_get_host_bridge_resources() to devm_of_pci_get_host_bridge_resources()

2018-05-15 Thread Joao Pinto
Hi Jan, Às 10:07 AM de 5/15/2018, Jan Kiszka escreveu: > From: Jan Kiszka > > of_pci_get_host_bridge_resources() allocates the resource structures it > fills dynamically, but none of its callers care to release them so far. > Rather than requiring everyone to do this

Re: [PATCH v4 6/8] PCI: Rework of_pci_get_host_bridge_resources() to devm_of_pci_get_host_bridge_resources()

2018-05-15 Thread Joao Pinto
Hi Jan, Às 10:07 AM de 5/15/2018, Jan Kiszka escreveu: > From: Jan Kiszka > > of_pci_get_host_bridge_resources() allocates the resource structures it > fills dynamically, but none of its callers care to release them so far. > Rather than requiring everyone to do this explicitly, convert the >

Re: [PATCH v4 6/8] PCI: Rework of_pci_get_host_bridge_resources() to devm_of_pci_get_host_bridge_resources()

2018-05-15 Thread Vladimir Zapolskiy
On 05/15/2018 12:07 PM, Jan Kiszka wrote: > From: Jan Kiszka > > of_pci_get_host_bridge_resources() allocates the resource structures it > fills dynamically, but none of its callers care to release them so far. > Rather than requiring everyone to do this explicitly,

Re: [PATCH v4 6/8] PCI: Rework of_pci_get_host_bridge_resources() to devm_of_pci_get_host_bridge_resources()

2018-05-15 Thread Vladimir Zapolskiy
On 05/15/2018 12:07 PM, Jan Kiszka wrote: > From: Jan Kiszka > > of_pci_get_host_bridge_resources() allocates the resource structures it > fills dynamically, but none of its callers care to release them so far. > Rather than requiring everyone to do this explicitly, convert the > existing