Re: [PATCH v4 7/7] zram: writeback throttle

On (12/03/18 15:02), Sergey Senozhatsky wrote: > Seems like I misread writeback_limit_store() a bit. > > So, if I want to, say, let only 10M of writteback pages, I need to > do > > echo 0 > writeback_limit > echo 10M > writeback_limit_store// memparse format is for >

Re: [PATCH v4 7/7] zram: writeback throttle

On (12/03/18 15:02), Sergey Senozhatsky wrote: > Seems like I misread writeback_limit_store() a bit. > > So, if I want to, say, let only 10M of writteback pages, I need to > do > > echo 0 > writeback_limit > echo 10M > writeback_limit_store// memparse format is for >

Re: [PATCH v4 7/7] zram: writeback throttle

On (12/03/18 14:50), Sergey Senozhatsky wrote: > On (12/03/18 11:40), Minchan Kim wrote: > [..] > > + down_read(>init_lock); > > + atomic64_set(>stats.bd_wb_limit, val); > > + if (val == 0) > > + zram->stop_writeback = false; > > + up_read(>init_lock); > > [..] > > > +

Re: [PATCH v4 7/7] zram: writeback throttle

On (12/03/18 14:50), Sergey Senozhatsky wrote: > On (12/03/18 11:40), Minchan Kim wrote: > [..] > > + down_read(>init_lock); > > + atomic64_set(>stats.bd_wb_limit, val); > > + if (val == 0) > > + zram->stop_writeback = false; > > + up_read(>init_lock); > > [..] > > > +

Re: [PATCH v4 7/7] zram: writeback throttle

On (12/03/18 11:40), Minchan Kim wrote: [..] > + down_read(>init_lock); > + atomic64_set(>stats.bd_wb_limit, val); > + if (val == 0) > + zram->stop_writeback = false; > + up_read(>init_lock); [..] > + if (zram->stop_writeback) { > + ret

Re: [PATCH v4 7/7] zram: writeback throttle

On (12/03/18 11:40), Minchan Kim wrote: [..] > + down_read(>init_lock); > + atomic64_set(>stats.bd_wb_limit, val); > + if (val == 0) > + zram->stop_writeback = false; > + up_read(>init_lock); [..] > + if (zram->stop_writeback) { > + ret