Re: [PATCH v4 9/9] w1: ds2438: support for writing to offset register
On Mon, Apr 05, 2021 at 09:44:01AM -0300, Luiz Sampaio wrote: > On Mon, Apr 05, 2021 at 01:04:59PM +0200, Greg KH wrote: > > On Mon, Apr 05, 2021 at 07:50:09AM -0300, Luiz Sampaio wrote: > > > Added a sysfs entry to support writing to the offset register on page1. > > > This register is used to calibrate the chip canceling offset errors in the > > > current ADC. This means that, over time, reading the IAD register will not > > > return the correct current measurement, it will have an offset. Writing to > > > the offset register if the two's complement of the current register while > > > passing zero current to the load will calibrate the measurements. This > > > change was tested on real hardware and it was able to calibrate the chip > > > correctly. > > > > > > Signed-off-by: Luiz Sampaio > > > --- > > > Documentation/w1/slaves/w1_ds2438.rst | 11 +- > > > drivers/w1/slaves/w1_ds2438.c | 49 +++ > > > 2 files changed, 59 insertions(+), 1 deletion(-) > > > > In this, and the previous patch, you added new sysfs files, but no > > update to Documentation/ABI/ for them. Please fix that up. > > > > thanks, > > > > greg k-h > > Hello! I'm sorry about some errors, this is my first patch and I'm not sure > about some things in the documentation. I really appreciate the responses and > guidance. No problem, again you should try wrapping your email lines :) > The file I need to add to Documentation/ABI/ is going to be in testing or > stable? And the file I need to create can be called, for instance, > sysfs-driver-w1_ds2438? stable I guess as you know this is what you want to do. And the file name seems right, thanks. greg k-h
Re: [PATCH v4 9/9] w1: ds2438: support for writing to offset register
On Mon, Apr 05, 2021 at 01:04:59PM +0200, Greg KH wrote: > On Mon, Apr 05, 2021 at 07:50:09AM -0300, Luiz Sampaio wrote: > > Added a sysfs entry to support writing to the offset register on page1. > > This register is used to calibrate the chip canceling offset errors in the > > current ADC. This means that, over time, reading the IAD register will not > > return the correct current measurement, it will have an offset. Writing to > > the offset register if the two's complement of the current register while > > passing zero current to the load will calibrate the measurements. This > > change was tested on real hardware and it was able to calibrate the chip > > correctly. > > > > Signed-off-by: Luiz Sampaio > > --- > > Documentation/w1/slaves/w1_ds2438.rst | 11 +- > > drivers/w1/slaves/w1_ds2438.c | 49 +++ > > 2 files changed, 59 insertions(+), 1 deletion(-) > > In this, and the previous patch, you added new sysfs files, but no > update to Documentation/ABI/ for them. Please fix that up. > > thanks, > > greg k-h Hello! I'm sorry about some errors, this is my first patch and I'm not sure about some things in the documentation. I really appreciate the responses and guidance. The file I need to add to Documentation/ABI/ is going to be in testing or stable? And the file I need to create can be called, for instance, sysfs-driver-w1_ds2438? Thanks!
Re: [PATCH v4 9/9] w1: ds2438: support for writing to offset register
On Mon, Apr 05, 2021 at 07:50:09AM -0300, Luiz Sampaio wrote: > Added a sysfs entry to support writing to the offset register on page1. > This register is used to calibrate the chip canceling offset errors in the > current ADC. This means that, over time, reading the IAD register will not > return the correct current measurement, it will have an offset. Writing to > the offset register if the two's complement of the current register while > passing zero current to the load will calibrate the measurements. This > change was tested on real hardware and it was able to calibrate the chip > correctly. > > Signed-off-by: Luiz Sampaio > --- > Documentation/w1/slaves/w1_ds2438.rst | 11 +- > drivers/w1/slaves/w1_ds2438.c | 49 +++ > 2 files changed, 59 insertions(+), 1 deletion(-) In this, and the previous patch, you added new sysfs files, but no update to Documentation/ABI/ for them. Please fix that up. thanks, greg k-h
