Re: [PATCH v5 01/18] xfs: compat_ioctl: use compat_ptr()

2019-08-15 Thread Arnd Bergmann
On Thu, Aug 15, 2019 at 9:28 PM Darrick J. Wong wrote: > > On Thu, Aug 15, 2019 at 09:20:32PM +0200, Arnd Bergmann wrote: > > On Thu, Aug 15, 2019 at 4:04 PM Christoph Hellwig > > wrote: > > > > > > On Thu, Aug 15, 2019 at 10:15:12PM +1000, Dave Chinner wrote: > > > > >

Re: [PATCH v5 01/18] xfs: compat_ioctl: use compat_ptr()

2019-08-15 Thread Darrick J. Wong
On Thu, Aug 15, 2019 at 09:20:32PM +0200, Arnd Bergmann wrote: > On Thu, Aug 15, 2019 at 4:04 PM Christoph Hellwig wrote: > > > > On Thu, Aug 15, 2019 at 10:15:12PM +1000, Dave Chinner wrote: > > > > http://git.infradead.org/users/hch/xfs.git/shortlog/refs/heads/xfs-ioctl-table > > > > > > Lots

Re: [PATCH v5 01/18] xfs: compat_ioctl: use compat_ptr()

2019-08-15 Thread Arnd Bergmann
On Thu, Aug 15, 2019 at 4:04 PM Christoph Hellwig wrote: > > On Thu, Aug 15, 2019 at 10:15:12PM +1000, Dave Chinner wrote: > > > http://git.infradead.org/users/hch/xfs.git/shortlog/refs/heads/xfs-ioctl-table > > > > Lots to like in that handful of patches. :) > > > > It can easily go before or

Re: [PATCH v5 01/18] xfs: compat_ioctl: use compat_ptr()

2019-08-15 Thread Christoph Hellwig
On Thu, Aug 15, 2019 at 10:15:12PM +1000, Dave Chinner wrote: > > http://git.infradead.org/users/hch/xfs.git/shortlog/refs/heads/xfs-ioctl-table > > Lots to like in that handful of patches. :) > > It can easily go before or after Arnd's patch, and the merge > conflict either way would be minor,

Re: [PATCH v5 01/18] xfs: compat_ioctl: use compat_ptr()

2019-08-15 Thread Dave Chinner
On Thu, Aug 15, 2019 at 03:26:49AM -0700, Christoph Hellwig wrote: > On Thu, Aug 15, 2019 at 01:02:11AM -0700, Christoph Hellwig wrote: > > In many ways I'd actually much rather have a table driven approach. > > Let me try something.. > > Ok, it seems like we don't even need a table containing

Re: [PATCH v5 01/18] xfs: compat_ioctl: use compat_ptr()

2019-08-15 Thread Arnd Bergmann
On Thu, Aug 15, 2019 at 12:26 PM Christoph Hellwig wrote: > > On Thu, Aug 15, 2019 at 01:02:11AM -0700, Christoph Hellwig wrote: > > In many ways I'd actually much rather have a table driven approach. > > Let me try something.. > > Ok, it seems like we don't even need a table containing native

Re: [PATCH v5 01/18] xfs: compat_ioctl: use compat_ptr()

2019-08-15 Thread Christoph Hellwig
On Thu, Aug 15, 2019 at 01:02:11AM -0700, Christoph Hellwig wrote: > In many ways I'd actually much rather have a table driven approach. > Let me try something.. Ok, it seems like we don't even need a table containing native and compat as we can just fall back. The tables still seem nicer to

Re: [PATCH v5 01/18] xfs: compat_ioctl: use compat_ptr()

2019-08-15 Thread Christoph Hellwig
In many ways I'd actually much rather have a table driven approach. Let me try something..

Re: [PATCH v5 01/18] xfs: compat_ioctl: use compat_ptr()

2019-08-15 Thread Arnd Bergmann
On Thu, Aug 15, 2019 at 9:13 AM Christoph Hellwig wrote: > > On Thu, Aug 15, 2019 at 07:37:53AM +1000, Dave Chinner wrote: > > > @@ -576,7 +576,7 @@ xfs_file_compat_ioctl( > > > case XFS_IOC_SCRUB_METADATA: > > > case XFS_IOC_BULKSTAT: > > > case XFS_IOC_INUMBERS: > > > -

Re: [PATCH v5 01/18] xfs: compat_ioctl: use compat_ptr()

2019-08-15 Thread Christoph Hellwig
On Thu, Aug 15, 2019 at 07:37:53AM +1000, Dave Chinner wrote: > > @@ -576,7 +576,7 @@ xfs_file_compat_ioctl( > > case XFS_IOC_SCRUB_METADATA: > > case XFS_IOC_BULKSTAT: > > case XFS_IOC_INUMBERS: > > - return xfs_file_ioctl(filp, cmd, p); > > + return

Re: [PATCH v5 01/18] xfs: compat_ioctl: use compat_ptr()

2019-08-15 Thread Arnd Bergmann
On Wed, Aug 14, 2019 at 11:39 PM Dave Chinner wrote: > > case XFS_IOC_BULKSTAT: > > case XFS_IOC_INUMBERS: > > - return xfs_file_ioctl(filp, cmd, p); > > + return xfs_file_ioctl(filp, cmd, (unsigned long)arg); > > I don't really like having to sprinkle special

Re: [PATCH v5 01/18] xfs: compat_ioctl: use compat_ptr()

2019-08-14 Thread Dave Chinner
On Wed, Aug 14, 2019 at 10:42:28PM +0200, Arnd Bergmann wrote: > For 31-bit s390 user space, we have to pass pointer arguments through > compat_ptr() in the compat_ioctl handler. Seems fair enough, but... > > Signed-off-by: Arnd Bergmann > --- > fs/xfs/xfs_ioctl32.c | 8 > 1 file