Re: [PATCH v5 06/11] net: ethernet: mtk-star-emac: new driver

2020-05-27 Thread Arnd Bergmann
On Wed, May 27, 2020 at 1:49 PM Bartosz Golaszewski wrote: > > śr., 27 maj 2020 o 13:33 Arnd Bergmann napisał(a): > > > > On Wed, May 27, 2020 at 10:46 AM Bartosz Golaszewski wrote: > > > Thanks for reporting this! I have a fix ready and will send it shortly. > > > > I already have a workaround

Re: [PATCH v5 06/11] net: ethernet: mtk-star-emac: new driver

2020-05-27 Thread Bartosz Golaszewski
śr., 27 maj 2020 o 13:33 Arnd Bergmann napisał(a): > > On Wed, May 27, 2020 at 10:46 AM Bartosz Golaszewski wrote: > > > > I don't know if there should be a new label that excludes that > > > assignment for those particular gotos or if new_dma_addr should > > > be initialized to something at the

Re: [PATCH v5 06/11] net: ethernet: mtk-star-emac: new driver

2020-05-27 Thread Arnd Bergmann
On Wed, May 27, 2020 at 10:46 AM Bartosz Golaszewski wrote: > > I don't know if there should be a new label that excludes that > > assignment for those particular gotos or if new_dma_addr should > > be initialized to something at the top. Please take a look at > > addressing this when you get a

Re: [PATCH v5 06/11] net: ethernet: mtk-star-emac: new driver

2020-05-27 Thread Bartosz Golaszewski
śr., 27 maj 2020 o 09:31 Nathan Chancellor napisał(a): > > On Fri, May 22, 2020 at 02:06:55PM +0200, Bartosz Golaszewski wrote: > > > > > diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c > > b/drivers/net/ethernet/mediatek/mtk_star_emac.c > > new file mode 100644 > > index

Re: [PATCH v5 06/11] net: ethernet: mtk-star-emac: new driver

2020-05-27 Thread Nathan Chancellor
On Fri, May 22, 2020 at 02:06:55PM +0200, Bartosz Golaszewski wrote: > diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c > b/drivers/net/ethernet/mediatek/mtk_star_emac.c > new file mode 100644 > index ..789c77af501f > --- /dev/null > +++

Re: [PATCH v5 06/11] net: ethernet: mtk-star-emac: new driver

2020-05-22 Thread Andrew Lunn
On Fri, May 22, 2020 at 05:06:34PM +0200, Matthias Brugger wrote: > > > On 22/05/2020 14:06, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > This adds the driver for the MediaTek STAR Ethernet MAC currently used > > on the MT8* SoC family. For now we only support full-duplex.

Re: [PATCH v5 06/11] net: ethernet: mtk-star-emac: new driver

2020-05-22 Thread Bartosz Golaszewski
pt., 22 maj 2020 o 17:06 Matthias Brugger napisał(a): > > > > On 22/05/2020 14:06, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > This adds the driver for the MediaTek STAR Ethernet MAC currently used > > on the MT8* SoC family. For now we only support full-duplex. > > MT85**

Re: [PATCH v5 06/11] net: ethernet: mtk-star-emac: new driver

2020-05-22 Thread Bartosz Golaszewski
pt., 22 maj 2020 o 17:06 Matthias Brugger napisał(a): > > On 22/05/2020 14:06, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > This adds the driver for the MediaTek STAR Ethernet MAC currently used > > on the MT8* SoC family. For now we only support full-duplex. > > MT85** SoC

Re: [PATCH v5 06/11] net: ethernet: mtk-star-emac: new driver

2020-05-22 Thread Matthias Brugger
On 22/05/2020 14:06, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > This adds the driver for the MediaTek STAR Ethernet MAC currently used > on the MT8* SoC family. For now we only support full-duplex. MT85** SoC family, AFAIU it's not used on MT81** devices. Correct? > >