Re: [PATCH v5 1/2] KVM: X86: Introduce handle_ud()

2018-04-04 Thread David Hildenbrand
On 04.04.2018 19:12, Paolo Bonzini wrote: > On 04/04/2018 13:54, David Hildenbrand wrote: >>> +{ >>> + enum emulation_result er; >>> + >>> + er = emulate_instruction(vcpu, EMULTYPE_TRAP_UD); >>> + if (er == EMULATE_USER_EXIT) >>> + return 0; >>> + if (er != EMULATE_DONE) >>> +

Re: [PATCH v5 1/2] KVM: X86: Introduce handle_ud()

2018-04-04 Thread David Hildenbrand
On 04.04.2018 19:12, Paolo Bonzini wrote: > On 04/04/2018 13:54, David Hildenbrand wrote: >>> +{ >>> + enum emulation_result er; >>> + >>> + er = emulate_instruction(vcpu, EMULTYPE_TRAP_UD); >>> + if (er == EMULATE_USER_EXIT) >>> + return 0; >>> + if (er != EMULATE_DONE) >>> +

Re: [PATCH v5 1/2] KVM: X86: Introduce handle_ud()

2018-04-04 Thread Paolo Bonzini
On 04/04/2018 13:54, David Hildenbrand wrote: >> +{ >> +enum emulation_result er; >> + >> +er = emulate_instruction(vcpu, EMULTYPE_TRAP_UD); >> +if (er == EMULATE_USER_EXIT) >> +return 0; >> +if (er != EMULATE_DONE) >> +kvm_queue_exception(vcpu, UD_VECTOR);

Re: [PATCH v5 1/2] KVM: X86: Introduce handle_ud()

2018-04-04 Thread Paolo Bonzini
On 04/04/2018 13:54, David Hildenbrand wrote: >> +{ >> +enum emulation_result er; >> + >> +er = emulate_instruction(vcpu, EMULTYPE_TRAP_UD); >> +if (er == EMULATE_USER_EXIT) >> +return 0; >> +if (er != EMULATE_DONE) >> +kvm_queue_exception(vcpu, UD_VECTOR);

Re: [PATCH v5 1/2] KVM: X86: Introduce handle_ud()

2018-04-04 Thread Wanpeng Li
2018-04-04 19:54 GMT+08:00 David Hildenbrand : > On 04.04.2018 01:28, Wanpeng Li wrote: >> From: Wanpeng Li >> >> Introduce handle_ud() to handle invalid opcode, this function will be >> used by later patches. >> >> Reviewed-by: Konrad Rzeszutek Wilk

Re: [PATCH v5 1/2] KVM: X86: Introduce handle_ud()

2018-04-04 Thread Wanpeng Li
2018-04-04 19:54 GMT+08:00 David Hildenbrand : > On 04.04.2018 01:28, Wanpeng Li wrote: >> From: Wanpeng Li >> >> Introduce handle_ud() to handle invalid opcode, this function will be >> used by later patches. >> >> Reviewed-by: Konrad Rzeszutek Wilk >> Reviewed-by: Liran Alon >> Cc: Paolo

Re: [PATCH v5 1/2] KVM: X86: Introduce handle_ud()

2018-04-04 Thread David Hildenbrand
On 04.04.2018 01:28, Wanpeng Li wrote: > From: Wanpeng Li > > Introduce handle_ud() to handle invalid opcode, this function will be > used by later patches. > > Reviewed-by: Konrad Rzeszutek Wilk > Reviewed-by: Liran Alon >

Re: [PATCH v5 1/2] KVM: X86: Introduce handle_ud()

2018-04-04 Thread David Hildenbrand
On 04.04.2018 01:28, Wanpeng Li wrote: > From: Wanpeng Li > > Introduce handle_ud() to handle invalid opcode, this function will be > used by later patches. > > Reviewed-by: Konrad Rzeszutek Wilk > Reviewed-by: Liran Alon > Cc: Paolo Bonzini > Cc: Radim Krčmář > Cc: Andrew Cooper > Cc: