Re: [PATCH v5 1/5] firmware: document user mode helper lock usage

2016-10-10 Thread Luis R. Rodriguez
On Fri, Oct 07, 2016 at 08:16:29AM +0200, Daniel Wagner wrote: > > > Sorry, I am a bit confused now. What is the consensus here: > > > > > > a) add a comment to _request_firmware() as in this patch #1 v5 > > > > The adding a comment note from Daniel was that the UMH lock is *not* > > needed on

Re: [PATCH v5 1/5] firmware: document user mode helper lock usage

2016-10-10 Thread Luis R. Rodriguez
On Fri, Oct 07, 2016 at 08:16:29AM +0200, Daniel Wagner wrote: > > > Sorry, I am a bit confused now. What is the consensus here: > > > > > > a) add a comment to _request_firmware() as in this patch #1 v5 > > > > The adding a comment note from Daniel was that the UMH lock is *not* > > needed on

Re: [PATCH v5 1/5] firmware: document user mode helper lock usage

2016-10-05 Thread Luis R. Rodriguez
On Fri, Sep 23, 2016 at 10:13:44AM +0200, Daniel Wagner wrote: > On 09/22/2016 04:36 AM, Ming Lei wrote: > >On Sat, Sep 10, 2016 at 6:14 AM, Luis R. Rodriguez wrote: > >>On Fri, Sep 09, 2016 at 02:12:20PM +0200, Daniel Wagner wrote: > >>>From: Daniel Wagner

Re: [PATCH v5 1/5] firmware: document user mode helper lock usage

2016-10-05 Thread Luis R. Rodriguez
On Fri, Sep 23, 2016 at 10:13:44AM +0200, Daniel Wagner wrote: > On 09/22/2016 04:36 AM, Ming Lei wrote: > >On Sat, Sep 10, 2016 at 6:14 AM, Luis R. Rodriguez wrote: > >>On Fri, Sep 09, 2016 at 02:12:20PM +0200, Daniel Wagner wrote: > >>>From: Daniel Wagner > >>> > >>>The lock is also used to

Re: [PATCH v5 1/5] firmware: document user mode helper lock usage

2016-10-05 Thread Luis R. Rodriguez
On Thu, Sep 22, 2016 at 10:36:39AM +0800, Ming Lei wrote: > On Sat, Sep 10, 2016 at 6:14 AM, Luis R. Rodriguez wrote: > > On Fri, Sep 09, 2016 at 02:12:20PM +0200, Daniel Wagner wrote: > >> From: Daniel Wagner > >> > >> The lock is also used to

Re: [PATCH v5 1/5] firmware: document user mode helper lock usage

2016-10-05 Thread Luis R. Rodriguez
On Thu, Sep 22, 2016 at 10:36:39AM +0800, Ming Lei wrote: > On Sat, Sep 10, 2016 at 6:14 AM, Luis R. Rodriguez wrote: > > On Fri, Sep 09, 2016 at 02:12:20PM +0200, Daniel Wagner wrote: > >> From: Daniel Wagner > >> > >> The lock is also used to generate warnings when a direct > >> firmware load

Re: [PATCH v5 1/5] firmware: document user mode helper lock usage

2016-09-21 Thread Ming Lei
On Sat, Sep 10, 2016 at 6:14 AM, Luis R. Rodriguez wrote: > On Fri, Sep 09, 2016 at 02:12:20PM +0200, Daniel Wagner wrote: >> From: Daniel Wagner >> >> The lock is also used to generate warnings when a direct >> firmware load is requested too early.

Re: [PATCH v5 1/5] firmware: document user mode helper lock usage

2016-09-21 Thread Ming Lei
On Sat, Sep 10, 2016 at 6:14 AM, Luis R. Rodriguez wrote: > On Fri, Sep 09, 2016 at 02:12:20PM +0200, Daniel Wagner wrote: >> From: Daniel Wagner >> >> The lock is also used to generate warnings when a direct >> firmware load is requested too early. > > I've determined the firmware cache lets us

Re: [PATCH v5 1/5] firmware: document user mode helper lock usage

2016-09-09 Thread Luis R. Rodriguez
On Fri, Sep 09, 2016 at 02:12:20PM +0200, Daniel Wagner wrote: > From: Daniel Wagner > > The lock is also used to generate warnings when a direct > firmware load is requested too early. I've determined the firmware cache lets us bail out of this consideration now. If

Re: [PATCH v5 1/5] firmware: document user mode helper lock usage

2016-09-09 Thread Luis R. Rodriguez
On Fri, Sep 09, 2016 at 02:12:20PM +0200, Daniel Wagner wrote: > From: Daniel Wagner > > The lock is also used to generate warnings when a direct > firmware load is requested too early. I've determined the firmware cache lets us bail out of this consideration now. If Ming agrees with the logic