Re: [PATCH v5 3/4] ARM64: dts: meson-gx: use stable UART bindings with correct gate clock
On 06/16/2017 10:57 PM, Kevin Hilman wrote:
> Neil Armstrong writes:
>
>> From: Helmut Klein
>>
>> This patch switches to the stable UART bindings but also add the correct
>> gate clock to the non-AO UART nodes for GXBB and GXL SoCs.
>>
>> Acked-by: Jerome Brunet
>> Signed-off-by: Helmut Klein
>> Signed-off-by: Neil Armstrong
>> ---
>> arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 12 +---
>> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 25 +
>> arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 25 +
>> 3 files changed, 55 insertions(+), 7 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
>> b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
>> index 603491d..86a4018 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
>> @@ -225,7 +225,7 @@
>> };
>>
>> uart_A: serial@84c0 {
>> -compatible = "amlogic,meson-uart";
>> +compatible = "amlogic,meson-gx-uart";
>
> IMO, we should keep both compatibles (the more specific one first.)
> That would allow new DTs to continue to run on older kernels.
>
> It would also allow this DT change to be completely independent of the
> driver changes. Otherwise, if I merge this before the driver change are
> merged, we'll have a bunch of boards with no more serial console output.
>
> Kevin
>
Hi Kevin,
Sure, no problem with that.
I'll push an update when the bindings + tty fixes are merged somewhere.
Neil
Re: [PATCH v5 3/4] ARM64: dts: meson-gx: use stable UART bindings with correct gate clock
Neil Armstrong writes:
> From: Helmut Klein
>
> This patch switches to the stable UART bindings but also add the correct
> gate clock to the non-AO UART nodes for GXBB and GXL SoCs.
>
> Acked-by: Jerome Brunet
> Signed-off-by: Helmut Klein
> Signed-off-by: Neil Armstrong
> ---
> arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 12 +---
> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 25 +
> arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 25 +
> 3 files changed, 55 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> index 603491d..86a4018 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> @@ -225,7 +225,7 @@
> };
>
> uart_A: serial@84c0 {
> - compatible = "amlogic,meson-uart";
> + compatible = "amlogic,meson-gx-uart";
IMO, we should keep both compatibles (the more specific one first.)
That would allow new DTs to continue to run on older kernels.
It would also allow this DT change to be completely independent of the
driver changes. Otherwise, if I merge this before the driver change are
merged, we'll have a bunch of boards with no more serial console output.
Kevin
