Re: [PATCH v5 bpf-next 05/15] samples/bpf: use __LINUX_ARM_ARCH__ selector for arm

2019-10-11 Thread Ivan Khoronzhuk

On Fri, Oct 11, 2019 at 11:46:54AM +0300, Sergei Shtylyov wrote:

Hello!

  Sorry, didn't comment on v4...

On 11.10.2019 3:27, Ivan Khoronzhuk wrote:


For arm, -D__LINUX_ARM_ARCH__=X is min version used as instruction
set selector and is absolutely required while parsing some parts of
headers. It's present in KBUILD_CFLAGS but not in autoconf.h, so let's
retrieve it from and add to programs cflags. In another case errors


  From where? And it's program's, no?

from KBUIL_CFLAGS. it's programs.




like "SMP is not supported" for armv7 and bunch of other errors are
issued resulting to incorrect final object.

Signed-off-by: Ivan Khoronzhuk 

[...]

MBR, Sergei


--
Regards,
Ivan Khoronzhuk


Re: [PATCH v5 bpf-next 05/15] samples/bpf: use __LINUX_ARM_ARCH__ selector for arm

2019-10-11 Thread Sergei Shtylyov

Hello!

   Sorry, didn't comment on v4...

On 11.10.2019 3:27, Ivan Khoronzhuk wrote:


For arm, -D__LINUX_ARM_ARCH__=X is min version used as instruction
set selector and is absolutely required while parsing some parts of
headers. It's present in KBUILD_CFLAGS but not in autoconf.h, so let's
retrieve it from and add to programs cflags. In another case errors


   From where? And it's program's, no?


like "SMP is not supported" for armv7 and bunch of other errors are
issued resulting to incorrect final object.

Signed-off-by: Ivan Khoronzhuk 

[...]

MBR, Sergei