Re: [PATCH v6 09/17] media: rkisp1: add rockchip isp1 core driver

[Tomasz Figa]

Hi Jacob, Shunqian,

On Thu, Mar 8, 2018 at 6:49 PM Jacob Chen  wrote:
[snip]
> +static const struct of_device_id rkisp1_plat_of_match[] = {
> +   {
> +   .compatible = "rockchip,rk3288-cif-isp",
> +   .data = &rk3288_isp_clk_data,
> +   }, {
> +   .compatible = "rockchip,rk3399-cif-isp",
> +   .data = &rk3399_isp_clk_data,
> +   },
> +   {},
> +};

We need MODULE_DEVICE_TABLE() here.

Best regards,
Tomasz

Re: [PATCH v6 09/17] media: rkisp1: add rockchip isp1 core driver

[Baruch Siach]

Hi Jacob,

On Thu, Mar 08, 2018 at 05:47:59PM +0800, Jacob Chen wrote:
> +config VIDEO_ROCKCHIP_ISP1
> + tristate "Rockchip Image Signal Processing v1 Unit driver"
> + depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
> + depends on ARCH_ROCKCHIP || COMPILE_TEST
> + select VIDEOBUF2_DMA_CONTIG
> + select V4L2_FWNODE
> + default n
> + ---help---
> +   Support for ISP1 on the rockchip SoC.

I added 'select VIDEOBUF2_VMALLOC' here to fix link failure:

drivers/media/platform/rockchip/isp1/isp_stats.o: In function 
`rkisp1_register_stats_vdev':
isp_stats.c:(.text+0x80c): undefined reference to `vb2_vmalloc_memops'
isp_stats.c:(.text+0x814): undefined reference to `vb2_vmalloc_memops'
drivers/media/platform/rockchip/isp1/isp_params.o: In function 
`rkisp1_register_params_vdev':
isp_params.c:(.text+0x29b4): undefined reference to `vb2_vmalloc_memops'
isp_params.c:(.text+0x29bc): undefined reference to `vb2_vmalloc_memops'

baruch

-- 
 http://baruch.siach.name/blog/  ~. .~   Tk Open Systems
=}ooO--U--Ooo{=
   - bar...@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -