Re: [PATCH v6 19/29] memcg: infrastructure to match an allocation to the right cache

2012-11-08 Thread Michal Hocko
On Thu 08-11-12 12:05:13, Michal Hocko wrote: > On Tue 06-11-12 09:03:54, Michal Hocko wrote: > > On Mon 05-11-12 16:28:37, Andrew Morton wrote: > > > On Thu, 1 Nov 2012 16:07:35 +0400 > > > Glauber Costa wrote: > > > > > > > +static __always_inline struct kmem_cache * > > > >

Re: [PATCH v6 19/29] memcg: infrastructure to match an allocation to the right cache

2012-11-08 Thread Michal Hocko
On Tue 06-11-12 09:03:54, Michal Hocko wrote: > On Mon 05-11-12 16:28:37, Andrew Morton wrote: > > On Thu, 1 Nov 2012 16:07:35 +0400 > > Glauber Costa wrote: > > > > > +static __always_inline struct kmem_cache * > > > +memcg_kmem_get_cache(struct kmem_cache *cachep, gfp_t gfp) > > > > I still

Re: [PATCH v6 19/29] memcg: infrastructure to match an allocation to the right cache

2012-11-08 Thread Michal Hocko
On Tue 06-11-12 09:03:54, Michal Hocko wrote: On Mon 05-11-12 16:28:37, Andrew Morton wrote: On Thu, 1 Nov 2012 16:07:35 +0400 Glauber Costa glom...@parallels.com wrote: +static __always_inline struct kmem_cache * +memcg_kmem_get_cache(struct kmem_cache *cachep, gfp_t gfp) I

Re: [PATCH v6 19/29] memcg: infrastructure to match an allocation to the right cache

2012-11-08 Thread Michal Hocko
On Thu 08-11-12 12:05:13, Michal Hocko wrote: On Tue 06-11-12 09:03:54, Michal Hocko wrote: On Mon 05-11-12 16:28:37, Andrew Morton wrote: On Thu, 1 Nov 2012 16:07:35 +0400 Glauber Costa glom...@parallels.com wrote: +static __always_inline struct kmem_cache *

Re: [PATCH v6 19/29] memcg: infrastructure to match an allocation to the right cache

2012-11-06 Thread Andrew Morton
On Wed, 7 Nov 2012 08:04:03 +0100 Glauber Costa wrote: > On 11/06/2012 01:28 AM, Andrew Morton wrote: > > On Thu, 1 Nov 2012 16:07:35 +0400 > > Glauber Costa wrote: > > > >> +static __always_inline struct kmem_cache * > >> +memcg_kmem_get_cache(struct kmem_cache *cachep, gfp_t gfp) > > > > I

Re: [PATCH v6 19/29] memcg: infrastructure to match an allocation to the right cache

2012-11-06 Thread Glauber Costa
On 11/06/2012 01:28 AM, Andrew Morton wrote: > On Thu, 1 Nov 2012 16:07:35 +0400 > Glauber Costa wrote: > >> +static __always_inline struct kmem_cache * >> +memcg_kmem_get_cache(struct kmem_cache *cachep, gfp_t gfp) > > I still don't understand why this code uses __always_inline so much. > >

Re: [PATCH v6 19/29] memcg: infrastructure to match an allocation to the right cache

2012-11-06 Thread Michal Hocko
On Mon 05-11-12 16:28:37, Andrew Morton wrote: > On Thu, 1 Nov 2012 16:07:35 +0400 > Glauber Costa wrote: > > > +static __always_inline struct kmem_cache * > > +memcg_kmem_get_cache(struct kmem_cache *cachep, gfp_t gfp) > > I still don't understand why this code uses __always_inline so much.

Re: [PATCH v6 19/29] memcg: infrastructure to match an allocation to the right cache

2012-11-06 Thread Michal Hocko
On Mon 05-11-12 16:28:37, Andrew Morton wrote: On Thu, 1 Nov 2012 16:07:35 +0400 Glauber Costa glom...@parallels.com wrote: +static __always_inline struct kmem_cache * +memcg_kmem_get_cache(struct kmem_cache *cachep, gfp_t gfp) I still don't understand why this code uses

Re: [PATCH v6 19/29] memcg: infrastructure to match an allocation to the right cache

2012-11-06 Thread Glauber Costa
On 11/06/2012 01:28 AM, Andrew Morton wrote: On Thu, 1 Nov 2012 16:07:35 +0400 Glauber Costa glom...@parallels.com wrote: +static __always_inline struct kmem_cache * +memcg_kmem_get_cache(struct kmem_cache *cachep, gfp_t gfp) I still don't understand why this code uses __always_inline so

Re: [PATCH v6 19/29] memcg: infrastructure to match an allocation to the right cache

2012-11-06 Thread Andrew Morton
On Wed, 7 Nov 2012 08:04:03 +0100 Glauber Costa glom...@parallels.com wrote: On 11/06/2012 01:28 AM, Andrew Morton wrote: On Thu, 1 Nov 2012 16:07:35 +0400 Glauber Costa glom...@parallels.com wrote: +static __always_inline struct kmem_cache * +memcg_kmem_get_cache(struct kmem_cache

Re: [PATCH v6 19/29] memcg: infrastructure to match an allocation to the right cache

2012-11-05 Thread Andrew Morton
On Thu, 1 Nov 2012 16:07:35 +0400 Glauber Costa wrote: > +static __always_inline struct kmem_cache * > +memcg_kmem_get_cache(struct kmem_cache *cachep, gfp_t gfp) I still don't understand why this code uses __always_inline so much. I don't recall seeing the compiler producing out-of-line

Re: [PATCH v6 19/29] memcg: infrastructure to match an allocation to the right cache

2012-11-05 Thread Andrew Morton
On Thu, 1 Nov 2012 16:07:35 +0400 Glauber Costa glom...@parallels.com wrote: +static __always_inline struct kmem_cache * +memcg_kmem_get_cache(struct kmem_cache *cachep, gfp_t gfp) I still don't understand why this code uses __always_inline so much. I don't recall seeing the compiler