Re: [PATCH v6 8/8] x86/microcode/AMD: Don't scan past the CPU equivalence table data

2018-06-18 Thread Borislav Petkov
On Mon, Jun 18, 2018 at 08:11:53PM +0200, Maciej S. Szmigiero wrote: > The equivalence table size can be computed in the late loader - there is > no problem there. > > However, this computed size needs to be passed somehow to functions > scanning the equivalence table. Ok, then let's make a compr

Re: [PATCH v6 8/8] x86/microcode/AMD: Don't scan past the CPU equivalence table data

2018-06-18 Thread Maciej S. Szmigiero
On 18.06.2018 18:44, Borislav Petkov wrote: > On Tue, Jun 12, 2018 at 11:08:31PM +0200, Maciej S. Szmigiero wrote: >> That was the solution before this patch series version (6) - there was >> a variable holding the CPU equivalence table size for the late loader, >> but you didn't like it:> Instead

Re: [PATCH v6 8/8] x86/microcode/AMD: Don't scan past the CPU equivalence table data

2018-06-18 Thread Borislav Petkov
On Tue, Jun 12, 2018 at 11:08:31PM +0200, Maciej S. Szmigiero wrote: > That was the solution before this patch series version (6) - there was > a variable holding the CPU equivalence table size for the late loader, > but you didn't like it:> Instead of adding yet another global var which needs > h

Re: [PATCH v6 8/8] x86/microcode/AMD: Don't scan past the CPU equivalence table data

2018-06-12 Thread Maciej S. Szmigiero
On 05.06.2018 10:55, Borislav Petkov wrote: > On Sun, May 20, 2018 at 12:07:22AM +0200, Maciej S. Szmigiero wrote: >> Currently, the code scanning a CPU equivalence table read from a microcode >> container file assumes that it actually contains a terminating zero entry, >> but if does not then the

Re: [PATCH v6 8/8] x86/microcode/AMD: Don't scan past the CPU equivalence table data

2018-06-05 Thread Borislav Petkov
On Sun, May 20, 2018 at 12:07:22AM +0200, Maciej S. Szmigiero wrote: > Currently, the code scanning a CPU equivalence table read from a microcode > container file assumes that it actually contains a terminating zero entry, > but if does not then the code will continue the scan past its valid data.