Re: [PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type

2017-10-22 Thread gengdongjiu
On 2017/10/21 20:15, Borislav Petkov wrote: >> Signed-off-by: Dongjiu Geng >> Tested-by: Tyler Baicar >> Signed-off-by: Borislav Petkov > I gave you Reviewed-by, not Signed-off-by. > > Before you send more patches, read this: > >

Re: [PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type

2017-10-22 Thread gengdongjiu
On 2017/10/21 20:15, Borislav Petkov wrote: >> Signed-off-by: Dongjiu Geng >> Tested-by: Tyler Baicar >> Signed-off-by: Borislav Petkov > I gave you Reviewed-by, not Signed-off-by. > > Before you send more patches, read this: > > Documentation/process/submitting-patches.rst > > You can

Re: [PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type

2017-10-21 Thread Borislav Petkov
On Sat, Oct 21, 2017 at 06:35:03PM +0800, Dongjiu Geng wrote: > For the SEA notification, the two functions ghes_sea_add() and > ghes_sea_remove() are only called when CONFIG_ACPI_APEI_SEA > is defined. If not, it will return errors in the ghes_probe() > and not continue. If the probe is failed,

Re: [PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type

2017-10-21 Thread Borislav Petkov
On Sat, Oct 21, 2017 at 06:35:03PM +0800, Dongjiu Geng wrote: > For the SEA notification, the two functions ghes_sea_add() and > ghes_sea_remove() are only called when CONFIG_ACPI_APEI_SEA > is defined. If not, it will return errors in the ghes_probe() > and not continue. If the probe is failed,