Re: [PATCH v7 0/5] usb: usbtmc: Add support for missing functions in USBTMC-USB488 spec

2016-01-29 Thread Dave Penkler 
Hi Clemens,
On Thu, Jan 28, 2016 at 09:46:59AM +0100, Clemens Ladisch wrote:
> Dave Penkler wrote:
> > Implement support for the USB488 defined READ_STATUS_BYTE ioctl (1/5)
> > and SRQ notifications with fasync (2/5) and poll/select (3/5) in order
> > to be able to synchronize with variable duration instrument
> > operations.
> >
> > Add convenience ioctl to return all device capabilities (4/5)
> >
> > Add ioctls for other USB488 requests: REN_CONTROL, GOTO_LOCAL and
> > LOCAL_LOCKOUT. (5/5)
> > [...]
> >  Testing:
> > All functions tested ok on an USBTMC-USB488 compliant oscilloscope
> 
> How?  Did you extend the usbtmc_ioctl tool?

No, I have written my own test program and run it against my Agilent/Keysight 
Oscilloscope. It is available, as is,  on request.

cheers,
-Dave

Re: [PATCH v7 0/5] usb: usbtmc: Add support for missing functions in USBTMC-USB488 spec

2016-01-29 Thread Dave Penkler 
Hi Clemens,
On Thu, Jan 28, 2016 at 09:46:59AM +0100, Clemens Ladisch wrote:
> Dave Penkler wrote:
> > Implement support for the USB488 defined READ_STATUS_BYTE ioctl (1/5)
> > and SRQ notifications with fasync (2/5) and poll/select (3/5) in order
> > to be able to synchronize with variable duration instrument
> > operations.
> >
> > Add convenience ioctl to return all device capabilities (4/5)
> >
> > Add ioctls for other USB488 requests: REN_CONTROL, GOTO_LOCAL and
> > LOCAL_LOCKOUT. (5/5)
> > [...]
> >  Testing:
> > All functions tested ok on an USBTMC-USB488 compliant oscilloscope
> 
> How?  Did you extend the usbtmc_ioctl tool?

No, I have written my own test program and run it against my Agilent/Keysight 
Oscilloscope. It is available, as is,  on request.

cheers,
-Dave

Re: [PATCH v7 0/5] usb: usbtmc: Add support for missing functions in USBTMC-USB488 spec

2016-01-28 Thread Clemens Ladisch 
Dave Penkler wrote:
> Implement support for the USB488 defined READ_STATUS_BYTE ioctl (1/5)
> and SRQ notifications with fasync (2/5) and poll/select (3/5) in order
> to be able to synchronize with variable duration instrument
> operations.
>
> Add convenience ioctl to return all device capabilities (4/5)
>
> Add ioctls for other USB488 requests: REN_CONTROL, GOTO_LOCAL and
> LOCAL_LOCKOUT. (5/5)
> [...]
>  Testing:
> All functions tested ok on an USBTMC-USB488 compliant oscilloscope

How?  Did you extend the usbtmc_ioctl tool?


Regards,
Clemens

Re: [PATCH v7 0/5] usb: usbtmc: Add support for missing functions in USBTMC-USB488 spec

2016-01-28 Thread Clemens Ladisch 
Dave Penkler wrote:
> Implement support for the USB488 defined READ_STATUS_BYTE ioctl (1/5)
> and SRQ notifications with fasync (2/5) and poll/select (3/5) in order
> to be able to synchronize with variable duration instrument
> operations.
>
> Add convenience ioctl to return all device capabilities (4/5)
>
> Add ioctls for other USB488 requests: REN_CONTROL, GOTO_LOCAL and
> LOCAL_LOCKOUT. (5/5)
> [...]
>  Testing:
> All functions tested ok on an USBTMC-USB488 compliant oscilloscope

How?  Did you extend the usbtmc_ioctl tool?


Regards,
Clemens