Re: [PATCH v7 3/6] kernel/reboot.c: export pm_power_off_prepare
Hi Rafael, it is two weeks since this email. Probably it was lost some where in the space time continuum. Can you please respond to it :) On 17.06.2018 09:05, Shawn Guo wrote: > On Tue, Jun 12, 2018 at 04:33:05PM +0200, Rafael J. Wysocki wrote: >> On Tuesday, June 12, 2018 2:42:12 PM CEST Oleksij Rempel wrote: >>> This is an OpenPGP/MIME signed message (RFC 4880 and 3156) >>> --Sj2PRcQlY7eZybdA0sq9wWzJEO8fKS924 >>> Content-Type: multipart/mixed; boundary="d6BZYFRi4L3iCmOh3nm6wjii3dWC9QFDg"; >>> protected-headers="v1" >>> From: Oleksij Rempel >>> To: Shawn Guo , Mark Brown , >>> "Rafael J. Wysocki" >>> Cc: ker...@pengutronix.de, devicet...@vger.kernel.org, >>> linux-arm-ker...@lists.infradead.org, linux-...@vger.kernel.org, >>> linux-kernel@vger.kernel.org, Andrew Morton , >>> Liam Girdwood , >>> Leonard Crestez , Rob Herring >>> , >>> Mark Rutland , >>> Michael Turquette , >>> Stephen Boyd , Fabio Estevam , >>> Russell King >>> Message-ID: >>> Subject: Re: [PATCH v7 3/6] kernel/reboot.c: export pm_power_off_prepare >>> References: <20180517055014.6607-1-o.rem...@pengutronix.de> >>> <20180517055014.6607-4-o.rem...@pengutronix.de> >>> In-Reply-To: <20180517055014.6607-4-o.rem...@pengutronix.de> >>> >>> --d6BZYFRi4L3iCmOh3nm6wjii3dWC9QFDg >>> Content-Type: text/plain; charset=utf-8 >>> Content-Language: en-US >>> Content-Transfer-Encoding: quoted-printable >>> >>> Hi Rafael, >>> >>> Last version of this patch was send at 17.05.2018. No other comment was >>> provided and this patch is a blocker for other patches in this serie. >>> Can you please give some feedback on it. >> >> I would have done that had I not missed the patch. >> >> Which probably wouldn't have happened had you CCed it to linux-pm. >> >> Anyway, I have no particular problems with exporting pm_power_off_prepare via >> EXPORT_SYMBOL_GPL(). > > Rafael, > > Can we have your explicit Acked-by tag on this patch? Thanks. > > Shawn > signature.asc Description: OpenPGP digital signature
Re: [PATCH v7 3/6] kernel/reboot.c: export pm_power_off_prepare
Hi Rafael, it is two weeks since this email. Probably it was lost some where in the space time continuum. Can you please respond to it :) On 17.06.2018 09:05, Shawn Guo wrote: > On Tue, Jun 12, 2018 at 04:33:05PM +0200, Rafael J. Wysocki wrote: >> On Tuesday, June 12, 2018 2:42:12 PM CEST Oleksij Rempel wrote: >>> This is an OpenPGP/MIME signed message (RFC 4880 and 3156) >>> --Sj2PRcQlY7eZybdA0sq9wWzJEO8fKS924 >>> Content-Type: multipart/mixed; boundary="d6BZYFRi4L3iCmOh3nm6wjii3dWC9QFDg"; >>> protected-headers="v1" >>> From: Oleksij Rempel >>> To: Shawn Guo , Mark Brown , >>> "Rafael J. Wysocki" >>> Cc: ker...@pengutronix.de, devicet...@vger.kernel.org, >>> linux-arm-ker...@lists.infradead.org, linux-...@vger.kernel.org, >>> linux-kernel@vger.kernel.org, Andrew Morton , >>> Liam Girdwood , >>> Leonard Crestez , Rob Herring >>> , >>> Mark Rutland , >>> Michael Turquette , >>> Stephen Boyd , Fabio Estevam , >>> Russell King >>> Message-ID: >>> Subject: Re: [PATCH v7 3/6] kernel/reboot.c: export pm_power_off_prepare >>> References: <20180517055014.6607-1-o.rem...@pengutronix.de> >>> <20180517055014.6607-4-o.rem...@pengutronix.de> >>> In-Reply-To: <20180517055014.6607-4-o.rem...@pengutronix.de> >>> >>> --d6BZYFRi4L3iCmOh3nm6wjii3dWC9QFDg >>> Content-Type: text/plain; charset=utf-8 >>> Content-Language: en-US >>> Content-Transfer-Encoding: quoted-printable >>> >>> Hi Rafael, >>> >>> Last version of this patch was send at 17.05.2018. No other comment was >>> provided and this patch is a blocker for other patches in this serie. >>> Can you please give some feedback on it. >> >> I would have done that had I not missed the patch. >> >> Which probably wouldn't have happened had you CCed it to linux-pm. >> >> Anyway, I have no particular problems with exporting pm_power_off_prepare via >> EXPORT_SYMBOL_GPL(). > > Rafael, > > Can we have your explicit Acked-by tag on this patch? Thanks. > > Shawn > signature.asc Description: OpenPGP digital signature
Re: [PATCH v7 3/6] kernel/reboot.c: export pm_power_off_prepare
On Tue, Jun 12, 2018 at 04:33:05PM +0200, Rafael J. Wysocki wrote: > On Tuesday, June 12, 2018 2:42:12 PM CEST Oleksij Rempel wrote: > > This is an OpenPGP/MIME signed message (RFC 4880 and 3156) > > --Sj2PRcQlY7eZybdA0sq9wWzJEO8fKS924 > > Content-Type: multipart/mixed; boundary="d6BZYFRi4L3iCmOh3nm6wjii3dWC9QFDg"; > > protected-headers="v1" > > From: Oleksij Rempel > > To: Shawn Guo , Mark Brown , > > "Rafael J. Wysocki" > > Cc: ker...@pengutronix.de, devicet...@vger.kernel.org, > > linux-arm-ker...@lists.infradead.org, linux-...@vger.kernel.org, > > linux-kernel@vger.kernel.org, Andrew Morton , > > Liam Girdwood , > > Leonard Crestez , Rob Herring > > , > > Mark Rutland , > > Michael Turquette , > > Stephen Boyd , Fabio Estevam , > > Russell King > > Message-ID: > > Subject: Re: [PATCH v7 3/6] kernel/reboot.c: export pm_power_off_prepare > > References: <20180517055014.6607-1-o.rem...@pengutronix.de> > > <20180517055014.6607-4-o.rem...@pengutronix.de> > > In-Reply-To: <20180517055014.6607-4-o.rem...@pengutronix.de> > > > > --d6BZYFRi4L3iCmOh3nm6wjii3dWC9QFDg > > Content-Type: text/plain; charset=utf-8 > > Content-Language: en-US > > Content-Transfer-Encoding: quoted-printable > > > > Hi Rafael, > > > > Last version of this patch was send at 17.05.2018. No other comment was > > provided and this patch is a blocker for other patches in this serie. > > Can you please give some feedback on it. > > I would have done that had I not missed the patch. > > Which probably wouldn't have happened had you CCed it to linux-pm. > > Anyway, I have no particular problems with exporting pm_power_off_prepare via > EXPORT_SYMBOL_GPL(). Rafael, Can we have your explicit Acked-by tag on this patch? Thanks. Shawn
Re: [PATCH v7 3/6] kernel/reboot.c: export pm_power_off_prepare
On Tue, Jun 12, 2018 at 04:33:05PM +0200, Rafael J. Wysocki wrote: > On Tuesday, June 12, 2018 2:42:12 PM CEST Oleksij Rempel wrote: > > This is an OpenPGP/MIME signed message (RFC 4880 and 3156) > > --Sj2PRcQlY7eZybdA0sq9wWzJEO8fKS924 > > Content-Type: multipart/mixed; boundary="d6BZYFRi4L3iCmOh3nm6wjii3dWC9QFDg"; > > protected-headers="v1" > > From: Oleksij Rempel > > To: Shawn Guo , Mark Brown , > > "Rafael J. Wysocki" > > Cc: ker...@pengutronix.de, devicet...@vger.kernel.org, > > linux-arm-ker...@lists.infradead.org, linux-...@vger.kernel.org, > > linux-kernel@vger.kernel.org, Andrew Morton , > > Liam Girdwood , > > Leonard Crestez , Rob Herring > > , > > Mark Rutland , > > Michael Turquette , > > Stephen Boyd , Fabio Estevam , > > Russell King > > Message-ID: > > Subject: Re: [PATCH v7 3/6] kernel/reboot.c: export pm_power_off_prepare > > References: <20180517055014.6607-1-o.rem...@pengutronix.de> > > <20180517055014.6607-4-o.rem...@pengutronix.de> > > In-Reply-To: <20180517055014.6607-4-o.rem...@pengutronix.de> > > > > --d6BZYFRi4L3iCmOh3nm6wjii3dWC9QFDg > > Content-Type: text/plain; charset=utf-8 > > Content-Language: en-US > > Content-Transfer-Encoding: quoted-printable > > > > Hi Rafael, > > > > Last version of this patch was send at 17.05.2018. No other comment was > > provided and this patch is a blocker for other patches in this serie. > > Can you please give some feedback on it. > > I would have done that had I not missed the patch. > > Which probably wouldn't have happened had you CCed it to linux-pm. > > Anyway, I have no particular problems with exporting pm_power_off_prepare via > EXPORT_SYMBOL_GPL(). Rafael, Can we have your explicit Acked-by tag on this patch? Thanks. Shawn
Re: [PATCH v7 3/6] kernel/reboot.c: export pm_power_off_prepare
On Tuesday, June 12, 2018 2:42:12 PM CEST Oleksij Rempel wrote: > This is an OpenPGP/MIME signed message (RFC 4880 and 3156) > --Sj2PRcQlY7eZybdA0sq9wWzJEO8fKS924 > Content-Type: multipart/mixed; boundary="d6BZYFRi4L3iCmOh3nm6wjii3dWC9QFDg"; > protected-headers="v1" > From: Oleksij Rempel > To: Shawn Guo , Mark Brown , > "Rafael J. Wysocki" > Cc: ker...@pengutronix.de, devicet...@vger.kernel.org, > linux-arm-ker...@lists.infradead.org, linux-...@vger.kernel.org, > linux-kernel@vger.kernel.org, Andrew Morton , > Liam Girdwood , > Leonard Crestez , Rob Herring , > Mark Rutland , > Michael Turquette , > Stephen Boyd , Fabio Estevam , > Russell King > Message-ID: > Subject: Re: [PATCH v7 3/6] kernel/reboot.c: export pm_power_off_prepare > References: <20180517055014.6607-1-o.rem...@pengutronix.de> > <20180517055014.6607-4-o.rem...@pengutronix.de> > In-Reply-To: <20180517055014.6607-4-o.rem...@pengutronix.de> > > --d6BZYFRi4L3iCmOh3nm6wjii3dWC9QFDg > Content-Type: text/plain; charset=utf-8 > Content-Language: en-US > Content-Transfer-Encoding: quoted-printable > > Hi Rafael, > > Last version of this patch was send at 17.05.2018. No other comment was > provided and this patch is a blocker for other patches in this serie. > Can you please give some feedback on it. I would have done that had I not missed the patch. Which probably wouldn't have happened had you CCed it to linux-pm. Anyway, I have no particular problems with exporting pm_power_off_prepare via EXPORT_SYMBOL_GPL(). > > On 17.05.2018 07:50, Oleksij Rempel wrote: > > Export pm_power_off_prepare. It is needed to implement power off on > > Freescale/NXP iMX6 based boards with external power management > > integrated circuit (PMIC). > >=20 > > Signed-off-by: Oleksij Rempel > > --- > > kernel/reboot.c | 1 + > > 1 file changed, 1 insertion(+) > >=20 > > diff --git a/kernel/reboot.c b/kernel/reboot.c > > index e4ced883d8de..83810d726f3e 100644 > > --- a/kernel/reboot.c > > +++ b/kernel/reboot.c > > @@ -49,6 +49,7 @@ int reboot_force; > > */ > > =20 > > void (*pm_power_off_prepare)(void); > > +EXPORT_SYMBOL_GPL(pm_power_off_prepare); > > =20 > > /** > > * emergency_restart - reboot the system > >=20 > > > --d6BZYFRi4L3iCmOh3nm6wjii3dWC9QFDg-- > > --Sj2PRcQlY7eZybdA0sq9wWzJEO8fKS924 > Content-Type: application/pgp-signature; name="signature.asc" > Content-Description: OpenPGP digital signature > Content-Disposition: attachment; filename="signature.asc" > > > --Sj2PRcQlY7eZybdA0sq9wWzJEO8fKS924-- >
Re: [PATCH v7 3/6] kernel/reboot.c: export pm_power_off_prepare
On Tuesday, June 12, 2018 2:42:12 PM CEST Oleksij Rempel wrote: > This is an OpenPGP/MIME signed message (RFC 4880 and 3156) > --Sj2PRcQlY7eZybdA0sq9wWzJEO8fKS924 > Content-Type: multipart/mixed; boundary="d6BZYFRi4L3iCmOh3nm6wjii3dWC9QFDg"; > protected-headers="v1" > From: Oleksij Rempel > To: Shawn Guo , Mark Brown , > "Rafael J. Wysocki" > Cc: ker...@pengutronix.de, devicet...@vger.kernel.org, > linux-arm-ker...@lists.infradead.org, linux-...@vger.kernel.org, > linux-kernel@vger.kernel.org, Andrew Morton , > Liam Girdwood , > Leonard Crestez , Rob Herring , > Mark Rutland , > Michael Turquette , > Stephen Boyd , Fabio Estevam , > Russell King > Message-ID: > Subject: Re: [PATCH v7 3/6] kernel/reboot.c: export pm_power_off_prepare > References: <20180517055014.6607-1-o.rem...@pengutronix.de> > <20180517055014.6607-4-o.rem...@pengutronix.de> > In-Reply-To: <20180517055014.6607-4-o.rem...@pengutronix.de> > > --d6BZYFRi4L3iCmOh3nm6wjii3dWC9QFDg > Content-Type: text/plain; charset=utf-8 > Content-Language: en-US > Content-Transfer-Encoding: quoted-printable > > Hi Rafael, > > Last version of this patch was send at 17.05.2018. No other comment was > provided and this patch is a blocker for other patches in this serie. > Can you please give some feedback on it. I would have done that had I not missed the patch. Which probably wouldn't have happened had you CCed it to linux-pm. Anyway, I have no particular problems with exporting pm_power_off_prepare via EXPORT_SYMBOL_GPL(). > > On 17.05.2018 07:50, Oleksij Rempel wrote: > > Export pm_power_off_prepare. It is needed to implement power off on > > Freescale/NXP iMX6 based boards with external power management > > integrated circuit (PMIC). > >=20 > > Signed-off-by: Oleksij Rempel > > --- > > kernel/reboot.c | 1 + > > 1 file changed, 1 insertion(+) > >=20 > > diff --git a/kernel/reboot.c b/kernel/reboot.c > > index e4ced883d8de..83810d726f3e 100644 > > --- a/kernel/reboot.c > > +++ b/kernel/reboot.c > > @@ -49,6 +49,7 @@ int reboot_force; > > */ > > =20 > > void (*pm_power_off_prepare)(void); > > +EXPORT_SYMBOL_GPL(pm_power_off_prepare); > > =20 > > /** > > * emergency_restart - reboot the system > >=20 > > > --d6BZYFRi4L3iCmOh3nm6wjii3dWC9QFDg-- > > --Sj2PRcQlY7eZybdA0sq9wWzJEO8fKS924 > Content-Type: application/pgp-signature; name="signature.asc" > Content-Description: OpenPGP digital signature > Content-Disposition: attachment; filename="signature.asc" > > > --Sj2PRcQlY7eZybdA0sq9wWzJEO8fKS924-- >
Re: [PATCH v7 3/6] kernel/reboot.c: export pm_power_off_prepare
Hi Rafael, Last version of this patch was send at 17.05.2018. No other comment was provided and this patch is a blocker for other patches in this serie. Can you please give some feedback on it. On 17.05.2018 07:50, Oleksij Rempel wrote: > Export pm_power_off_prepare. It is needed to implement power off on > Freescale/NXP iMX6 based boards with external power management > integrated circuit (PMIC). > > Signed-off-by: Oleksij Rempel > --- > kernel/reboot.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/reboot.c b/kernel/reboot.c > index e4ced883d8de..83810d726f3e 100644 > --- a/kernel/reboot.c > +++ b/kernel/reboot.c > @@ -49,6 +49,7 @@ int reboot_force; > */ > > void (*pm_power_off_prepare)(void); > +EXPORT_SYMBOL_GPL(pm_power_off_prepare); > > /** > * emergency_restart - reboot the system > signature.asc Description: OpenPGP digital signature
Re: [PATCH v7 3/6] kernel/reboot.c: export pm_power_off_prepare
Hi Rafael, Last version of this patch was send at 17.05.2018. No other comment was provided and this patch is a blocker for other patches in this serie. Can you please give some feedback on it. On 17.05.2018 07:50, Oleksij Rempel wrote: > Export pm_power_off_prepare. It is needed to implement power off on > Freescale/NXP iMX6 based boards with external power management > integrated circuit (PMIC). > > Signed-off-by: Oleksij Rempel > --- > kernel/reboot.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/reboot.c b/kernel/reboot.c > index e4ced883d8de..83810d726f3e 100644 > --- a/kernel/reboot.c > +++ b/kernel/reboot.c > @@ -49,6 +49,7 @@ int reboot_force; > */ > > void (*pm_power_off_prepare)(void); > +EXPORT_SYMBOL_GPL(pm_power_off_prepare); > > /** > * emergency_restart - reboot the system > signature.asc Description: OpenPGP digital signature
