Re: [PATCH v8 5/7] PCI/AER: Unify aer error defines at single space
Hi Oza, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on pci/next] [also build test WARNING on v4.16-rc2 next-20180222] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Oza-Pawandeep/Address-error-and-recovery-for-AER-and-DPC/20180222-060518 base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) include/linux/init.h:134:6: sparse: attribute 'indirect_branch': unknown attribute include/linux/init.h:135:5: sparse: attribute 'indirect_branch': unknown attribute include/linux/init.h:268:6: sparse: attribute 'indirect_branch': unknown attribute include/linux/init.h:269:6: sparse: attribute 'indirect_branch': unknown attribute include/linux/printk.h:200:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/mem_encrypt.h:32:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/mem_encrypt.h:34:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/mem_encrypt.h:37:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/mem_encrypt.h:38:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/mem_encrypt.h:40:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/mem_encrypt.h:42:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/mem_encrypt.h:43:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/mem_encrypt.h:45:5: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/mem_encrypt.h:46:5: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/mem_encrypt.h:49:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/qspinlock.h:53:32: sparse: attribute 'indirect_branch': unknown attribute include/linux/wait_bit.h:41:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/workqueue.h:646:5: sparse: attribute 'indirect_branch': unknown attribute include/linux/workqueue.h:647:5: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/numa.h:34:12: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/numa.h:35:13: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/numa.h:62:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/vmalloc.h:64:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/vmalloc.h:173:8: sparse: attribute 'indirect_branch': unknown attribute include/linux/vmalloc.h:174:8: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/fixmap.h:174:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/fixmap.h:176:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/fixmap.h:178:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/fixmap.h:180:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/apic.h:254:13: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/apic.h:430:13: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/io_apic.h:184:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/smp.h:113:6: sparse: attribute 'indirect_branch': unknown attribute include/linux/smp.h:125:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/smp.h:126:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/percpu.h:110:33: sparse: attribute 'indirect_branch': unknown attribute include/linux/percpu.h:112:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/percpu.h:114:12: sparse: attribute 'indirect_branch': unknown attribute include/linux/percpu.h:118:12: sparse: attribute 'indirect_branch': unknown attribute include/linux/percpu.h:126:12: sparse: attribute 'indirect_branch': unknown attribute include/linux/fs.h:63:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/fs.h:64:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/fs.h:65:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/fs.h:66:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/memory_hotplug.h:221:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/mmzone.h:1292:15: sparse: attribute 'indirect_branch': unknown attribute include/linux/fs.h:2421:13: sparse: attribute 'indirect_branch': unknown attribute
Re: [PATCH v8 5/7] PCI/AER: Unify aer error defines at single space
Hi Oza, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on pci/next] [also build test WARNING on v4.16-rc2 next-20180222] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Oza-Pawandeep/Address-error-and-recovery-for-AER-and-DPC/20180222-060518 base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) include/linux/init.h:134:6: sparse: attribute 'indirect_branch': unknown attribute include/linux/init.h:135:5: sparse: attribute 'indirect_branch': unknown attribute include/linux/init.h:268:6: sparse: attribute 'indirect_branch': unknown attribute include/linux/init.h:269:6: sparse: attribute 'indirect_branch': unknown attribute include/linux/printk.h:200:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/mem_encrypt.h:32:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/mem_encrypt.h:34:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/mem_encrypt.h:37:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/mem_encrypt.h:38:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/mem_encrypt.h:40:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/mem_encrypt.h:42:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/mem_encrypt.h:43:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/mem_encrypt.h:45:5: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/mem_encrypt.h:46:5: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/mem_encrypt.h:49:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/qspinlock.h:53:32: sparse: attribute 'indirect_branch': unknown attribute include/linux/wait_bit.h:41:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/workqueue.h:646:5: sparse: attribute 'indirect_branch': unknown attribute include/linux/workqueue.h:647:5: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/numa.h:34:12: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/numa.h:35:13: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/numa.h:62:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/vmalloc.h:64:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/vmalloc.h:173:8: sparse: attribute 'indirect_branch': unknown attribute include/linux/vmalloc.h:174:8: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/fixmap.h:174:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/fixmap.h:176:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/fixmap.h:178:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/fixmap.h:180:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/apic.h:254:13: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/apic.h:430:13: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/io_apic.h:184:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/smp.h:113:6: sparse: attribute 'indirect_branch': unknown attribute include/linux/smp.h:125:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/smp.h:126:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/percpu.h:110:33: sparse: attribute 'indirect_branch': unknown attribute include/linux/percpu.h:112:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/percpu.h:114:12: sparse: attribute 'indirect_branch': unknown attribute include/linux/percpu.h:118:12: sparse: attribute 'indirect_branch': unknown attribute include/linux/percpu.h:126:12: sparse: attribute 'indirect_branch': unknown attribute include/linux/fs.h:63:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/fs.h:64:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/fs.h:65:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/fs.h:66:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/memory_hotplug.h:221:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/mmzone.h:1292:15: sparse: attribute 'indirect_branch': unknown attribute include/linux/fs.h:2421:13: sparse: attribute 'indirect_branch': unknown attribute
Re: [PATCH v8 5/7] PCI/AER: Unify aer error defines at single space
Hi Oza, Thank you for the patch! Yet something to improve: [auto build test ERROR on pci/next] [also build test ERROR on v4.16-rc2 next-20180221] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Oza-Pawandeep/Address-error-and-recovery-for-AER-and-DPC/20180222-060518 base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next config: x86_64-randconfig-s2-02220611 (attached as .config) compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): In file included from include/trace/define_trace.h:96:0, from include/ras/ras_event.h:414, from drivers//ras/ras.c:15: include/trace/../../include/ras/ras_event.h: In function 'trace_raw_output_aer_event': >> include/trace/../../include/ras/ras_event.h:319:24: error: 'AER_CORRECTABLE' >> undeclared (first use in this function) __entry->severity == AER_CORRECTABLE ? "Corrected" : ^ include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS' trace_seq_printf(s, print); \ ^ include/trace/trace_events.h:79:9: note: in expansion of macro 'PARAMS' PARAMS(print)); \ ^~ include/trace/../../include/ras/ras_event.h:298:1: note: in expansion of macro 'TRACE_EVENT' TRACE_EVENT(aer_event, ^~~ include/trace/../../include/ras/ras_event.h:317:2: note: in expansion of macro 'TP_printk' TP_printk("%s PCIe Bus Error: severity=%s, %s\n", ^ include/trace/../../include/ras/ras_event.h:319:24: note: each undeclared identifier is reported only once for each function it appears in __entry->severity == AER_CORRECTABLE ? "Corrected" : ^ include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS' trace_seq_printf(s, print); \ ^ include/trace/trace_events.h:79:9: note: in expansion of macro 'PARAMS' PARAMS(print)); \ ^~ include/trace/../../include/ras/ras_event.h:298:1: note: in expansion of macro 'TRACE_EVENT' TRACE_EVENT(aer_event, ^~~ include/trace/../../include/ras/ras_event.h:317:2: note: in expansion of macro 'TP_printk' TP_printk("%s PCIe Bus Error: severity=%s, %s\n", ^ >> include/trace/../../include/ras/ras_event.h:320:25: error: 'AER_FATAL' >> undeclared (first use in this function) __entry->severity == AER_FATAL ? ^ include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS' trace_seq_printf(s, print); \ ^ include/trace/trace_events.h:79:9: note: in expansion of macro 'PARAMS' PARAMS(print)); \ ^~ include/trace/../../include/ras/ras_event.h:298:1: note: in expansion of macro 'TRACE_EVENT' TRACE_EVENT(aer_event, ^~~ include/trace/../../include/ras/ras_event.h:317:2: note: in expansion of macro 'TP_printk' TP_printk("%s PCIe Bus Error: severity=%s, %s\n", ^ vim +/AER_CORRECTABLE +319 include/trace/../../include/ras/ras_event.h 297b64c7 Tyler Baicar 2017-06-21 254 297b64c7 Tyler Baicar 2017-06-21 255 /* 0a2409aa Chen, Gong 2014-06-11 256 * PCIe AER Trace event 0a2409aa Chen, Gong 2014-06-11 257 * 0a2409aa Chen, Gong 2014-06-11 258 * These events are generated when hardware detects a corrected or 0a2409aa Chen, Gong 2014-06-11 259 * uncorrected event on a PCIe device. The event report has 0a2409aa Chen, Gong 2014-06-11 260 * the following structure: 0a2409aa Chen, Gong 2014-06-11 261 * 0a2409aa Chen, Gong 2014-06-11 262 * char * dev_name - The name of the slot where the device resides 0a2409aa Chen, Gong 2014-06-11 263 * ([domain:]bus:device.function). 0a2409aa Chen, Gong 2014-06-11 264 * u32 status - Either the correctable or uncorrectable register 0a2409aa Chen, Gong 2014-06-11 265 * indicating what error or errors have been seen 0a2409aa Chen, Gong 2014-06-11 266 * u8 severity - error severity 0:NONFATAL 1:FATAL 2:CORRECTED 0a2409aa Chen, Gong 2014-06-11 267 */ 0a2409aa Chen, Gong 2014-06-11 268 0a2409aa Chen, Gong 2014-06-11 269 #define aer_correctable_errors \ 99d44024 Chen, Gong 2014-08-13 270 {PCI_ERR_COR_RCVR, "Receiver Error"}, \ 99d44024 Chen, Gong 2014-08-13 271 {PCI_ERR_COR_BAD_TLP, "Bad TLP"}, \ 99d44024 Chen, Gong 2014-08-13 272 {PCI_ERR_COR_BAD_DLLP, "Bad DLLP"}, \ 99d44024 Chen, Gong
Re: [PATCH v8 5/7] PCI/AER: Unify aer error defines at single space
Hi Oza, Thank you for the patch! Yet something to improve: [auto build test ERROR on pci/next] [also build test ERROR on v4.16-rc2 next-20180221] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Oza-Pawandeep/Address-error-and-recovery-for-AER-and-DPC/20180222-060518 base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next config: x86_64-randconfig-s2-02220611 (attached as .config) compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): In file included from include/trace/define_trace.h:96:0, from include/ras/ras_event.h:414, from drivers//ras/ras.c:15: include/trace/../../include/ras/ras_event.h: In function 'trace_raw_output_aer_event': >> include/trace/../../include/ras/ras_event.h:319:24: error: 'AER_CORRECTABLE' >> undeclared (first use in this function) __entry->severity == AER_CORRECTABLE ? "Corrected" : ^ include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS' trace_seq_printf(s, print); \ ^ include/trace/trace_events.h:79:9: note: in expansion of macro 'PARAMS' PARAMS(print)); \ ^~ include/trace/../../include/ras/ras_event.h:298:1: note: in expansion of macro 'TRACE_EVENT' TRACE_EVENT(aer_event, ^~~ include/trace/../../include/ras/ras_event.h:317:2: note: in expansion of macro 'TP_printk' TP_printk("%s PCIe Bus Error: severity=%s, %s\n", ^ include/trace/../../include/ras/ras_event.h:319:24: note: each undeclared identifier is reported only once for each function it appears in __entry->severity == AER_CORRECTABLE ? "Corrected" : ^ include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS' trace_seq_printf(s, print); \ ^ include/trace/trace_events.h:79:9: note: in expansion of macro 'PARAMS' PARAMS(print)); \ ^~ include/trace/../../include/ras/ras_event.h:298:1: note: in expansion of macro 'TRACE_EVENT' TRACE_EVENT(aer_event, ^~~ include/trace/../../include/ras/ras_event.h:317:2: note: in expansion of macro 'TP_printk' TP_printk("%s PCIe Bus Error: severity=%s, %s\n", ^ >> include/trace/../../include/ras/ras_event.h:320:25: error: 'AER_FATAL' >> undeclared (first use in this function) __entry->severity == AER_FATAL ? ^ include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS' trace_seq_printf(s, print); \ ^ include/trace/trace_events.h:79:9: note: in expansion of macro 'PARAMS' PARAMS(print)); \ ^~ include/trace/../../include/ras/ras_event.h:298:1: note: in expansion of macro 'TRACE_EVENT' TRACE_EVENT(aer_event, ^~~ include/trace/../../include/ras/ras_event.h:317:2: note: in expansion of macro 'TP_printk' TP_printk("%s PCIe Bus Error: severity=%s, %s\n", ^ vim +/AER_CORRECTABLE +319 include/trace/../../include/ras/ras_event.h 297b64c7 Tyler Baicar 2017-06-21 254 297b64c7 Tyler Baicar 2017-06-21 255 /* 0a2409aa Chen, Gong 2014-06-11 256 * PCIe AER Trace event 0a2409aa Chen, Gong 2014-06-11 257 * 0a2409aa Chen, Gong 2014-06-11 258 * These events are generated when hardware detects a corrected or 0a2409aa Chen, Gong 2014-06-11 259 * uncorrected event on a PCIe device. The event report has 0a2409aa Chen, Gong 2014-06-11 260 * the following structure: 0a2409aa Chen, Gong 2014-06-11 261 * 0a2409aa Chen, Gong 2014-06-11 262 * char * dev_name - The name of the slot where the device resides 0a2409aa Chen, Gong 2014-06-11 263 * ([domain:]bus:device.function). 0a2409aa Chen, Gong 2014-06-11 264 * u32 status - Either the correctable or uncorrectable register 0a2409aa Chen, Gong 2014-06-11 265 * indicating what error or errors have been seen 0a2409aa Chen, Gong 2014-06-11 266 * u8 severity - error severity 0:NONFATAL 1:FATAL 2:CORRECTED 0a2409aa Chen, Gong 2014-06-11 267 */ 0a2409aa Chen, Gong 2014-06-11 268 0a2409aa Chen, Gong 2014-06-11 269 #define aer_correctable_errors \ 99d44024 Chen, Gong 2014-08-13 270 {PCI_ERR_COR_RCVR, "Receiver Error"}, \ 99d44024 Chen, Gong 2014-08-13 271 {PCI_ERR_COR_BAD_TLP, "Bad TLP"}, \ 99d44024 Chen, Gong 2014-08-13 272 {PCI_ERR_COR_BAD_DLLP, "Bad DLLP"}, \ 99d44024 Chen, Gong
Re: [PATCH v8 5/7] PCI/AER: Unify aer error defines at single space
Hi Oza, Thank you for the patch! Yet something to improve: [auto build test ERROR on pci/next] [also build test ERROR on v4.16-rc2 next-20180221] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Oza-Pawandeep/Address-error-and-recovery-for-AER-and-DPC/20180222-060518 base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=sh All error/warnings (new ones prefixed by >>): In file included from include/trace/define_trace.h:96:0, from include/ras/ras_event.h:414, from drivers//ras/ras.c:15: include/trace/../../include/ras/ras_event.h: In function 'trace_raw_output_aer_event': >> include/trace/../../include/ras/ras_event.h:319:24: error: 'AER_CORRECTABLE' >> undeclared (first use in this function); did you mean 'NR_UNEVICTABLE'? __entry->severity == AER_CORRECTABLE ? "Corrected" : ^ include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS' trace_seq_printf(s, print); \ ^ include/trace/trace_events.h:79:9: note: in expansion of macro 'PARAMS' PARAMS(print)); \ ^~ >> include/trace/../../include/ras/ras_event.h:298:1: note: in expansion of >> macro 'TRACE_EVENT' TRACE_EVENT(aer_event, ^~~ >> include/trace/../../include/ras/ras_event.h:317:2: note: in expansion of >> macro 'TP_printk' TP_printk("%s PCIe Bus Error: severity=%s, %s\n", ^ include/trace/../../include/ras/ras_event.h:319:24: note: each undeclared identifier is reported only once for each function it appears in __entry->severity == AER_CORRECTABLE ? "Corrected" : ^ include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS' trace_seq_printf(s, print); \ ^ include/trace/trace_events.h:79:9: note: in expansion of macro 'PARAMS' PARAMS(print)); \ ^~ >> include/trace/../../include/ras/ras_event.h:298:1: note: in expansion of >> macro 'TRACE_EVENT' TRACE_EVENT(aer_event, ^~~ >> include/trace/../../include/ras/ras_event.h:317:2: note: in expansion of >> macro 'TP_printk' TP_printk("%s PCIe Bus Error: severity=%s, %s\n", ^ >> include/trace/../../include/ras/ras_event.h:320:25: error: 'AER_FATAL' >> undeclared (first use in this function); did you mean 'NET_ATALK'? __entry->severity == AER_FATAL ? ^ include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS' trace_seq_printf(s, print); \ ^ include/trace/trace_events.h:79:9: note: in expansion of macro 'PARAMS' PARAMS(print)); \ ^~ >> include/trace/../../include/ras/ras_event.h:298:1: note: in expansion of >> macro 'TRACE_EVENT' TRACE_EVENT(aer_event, ^~~ >> include/trace/../../include/ras/ras_event.h:317:2: note: in expansion of >> macro 'TP_printk' TP_printk("%s PCIe Bus Error: severity=%s, %s\n", ^ vim +319 include/trace/../../include/ras/ras_event.h 297b64c7 Tyler Baicar 2017-06-21 254 297b64c7 Tyler Baicar 2017-06-21 255 /* 0a2409aa Chen, Gong 2014-06-11 256 * PCIe AER Trace event 0a2409aa Chen, Gong 2014-06-11 257 * 0a2409aa Chen, Gong 2014-06-11 258 * These events are generated when hardware detects a corrected or 0a2409aa Chen, Gong 2014-06-11 259 * uncorrected event on a PCIe device. The event report has 0a2409aa Chen, Gong 2014-06-11 260 * the following structure: 0a2409aa Chen, Gong 2014-06-11 261 * 0a2409aa Chen, Gong 2014-06-11 262 * char * dev_name - The name of the slot where the device resides 0a2409aa Chen, Gong 2014-06-11 263 * ([domain:]bus:device.function). 0a2409aa Chen, Gong 2014-06-11 264 * u32 status - Either the correctable or uncorrectable register 0a2409aa Chen, Gong 2014-06-11 265 * indicating what error or errors have been seen 0a2409aa Chen, Gong 2014-06-11 266 * u8 severity - error severity 0:NONFATAL 1:FATAL 2:CORRECTED 0a2409aa Chen, Gong 2014-06-11 267 */ 0a2409aa Chen, Gong 2014-06-11 268 0a2409aa Chen, Gong 2014-06-11 269 #define aer_correctable_errors \ 99d44024 Chen, Gong 2014-08-13 270 {PCI_ERR_COR_RCVR, "Receiver Error"}, \ 99d44024 Chen, Gong
Re: [PATCH v8 5/7] PCI/AER: Unify aer error defines at single space
Hi Oza, Thank you for the patch! Yet something to improve: [auto build test ERROR on pci/next] [also build test ERROR on v4.16-rc2 next-20180221] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Oza-Pawandeep/Address-error-and-recovery-for-AER-and-DPC/20180222-060518 base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=sh All error/warnings (new ones prefixed by >>): In file included from include/trace/define_trace.h:96:0, from include/ras/ras_event.h:414, from drivers//ras/ras.c:15: include/trace/../../include/ras/ras_event.h: In function 'trace_raw_output_aer_event': >> include/trace/../../include/ras/ras_event.h:319:24: error: 'AER_CORRECTABLE' >> undeclared (first use in this function); did you mean 'NR_UNEVICTABLE'? __entry->severity == AER_CORRECTABLE ? "Corrected" : ^ include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS' trace_seq_printf(s, print); \ ^ include/trace/trace_events.h:79:9: note: in expansion of macro 'PARAMS' PARAMS(print)); \ ^~ >> include/trace/../../include/ras/ras_event.h:298:1: note: in expansion of >> macro 'TRACE_EVENT' TRACE_EVENT(aer_event, ^~~ >> include/trace/../../include/ras/ras_event.h:317:2: note: in expansion of >> macro 'TP_printk' TP_printk("%s PCIe Bus Error: severity=%s, %s\n", ^ include/trace/../../include/ras/ras_event.h:319:24: note: each undeclared identifier is reported only once for each function it appears in __entry->severity == AER_CORRECTABLE ? "Corrected" : ^ include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS' trace_seq_printf(s, print); \ ^ include/trace/trace_events.h:79:9: note: in expansion of macro 'PARAMS' PARAMS(print)); \ ^~ >> include/trace/../../include/ras/ras_event.h:298:1: note: in expansion of >> macro 'TRACE_EVENT' TRACE_EVENT(aer_event, ^~~ >> include/trace/../../include/ras/ras_event.h:317:2: note: in expansion of >> macro 'TP_printk' TP_printk("%s PCIe Bus Error: severity=%s, %s\n", ^ >> include/trace/../../include/ras/ras_event.h:320:25: error: 'AER_FATAL' >> undeclared (first use in this function); did you mean 'NET_ATALK'? __entry->severity == AER_FATAL ? ^ include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS' trace_seq_printf(s, print); \ ^ include/trace/trace_events.h:79:9: note: in expansion of macro 'PARAMS' PARAMS(print)); \ ^~ >> include/trace/../../include/ras/ras_event.h:298:1: note: in expansion of >> macro 'TRACE_EVENT' TRACE_EVENT(aer_event, ^~~ >> include/trace/../../include/ras/ras_event.h:317:2: note: in expansion of >> macro 'TP_printk' TP_printk("%s PCIe Bus Error: severity=%s, %s\n", ^ vim +319 include/trace/../../include/ras/ras_event.h 297b64c7 Tyler Baicar 2017-06-21 254 297b64c7 Tyler Baicar 2017-06-21 255 /* 0a2409aa Chen, Gong 2014-06-11 256 * PCIe AER Trace event 0a2409aa Chen, Gong 2014-06-11 257 * 0a2409aa Chen, Gong 2014-06-11 258 * These events are generated when hardware detects a corrected or 0a2409aa Chen, Gong 2014-06-11 259 * uncorrected event on a PCIe device. The event report has 0a2409aa Chen, Gong 2014-06-11 260 * the following structure: 0a2409aa Chen, Gong 2014-06-11 261 * 0a2409aa Chen, Gong 2014-06-11 262 * char * dev_name - The name of the slot where the device resides 0a2409aa Chen, Gong 2014-06-11 263 * ([domain:]bus:device.function). 0a2409aa Chen, Gong 2014-06-11 264 * u32 status - Either the correctable or uncorrectable register 0a2409aa Chen, Gong 2014-06-11 265 * indicating what error or errors have been seen 0a2409aa Chen, Gong 2014-06-11 266 * u8 severity - error severity 0:NONFATAL 1:FATAL 2:CORRECTED 0a2409aa Chen, Gong 2014-06-11 267 */ 0a2409aa Chen, Gong 2014-06-11 268 0a2409aa Chen, Gong 2014-06-11 269 #define aer_correctable_errors \ 99d44024 Chen, Gong 2014-08-13 270 {PCI_ERR_COR_RCVR, "Receiver Error"}, \ 99d44024 Chen, Gong