Re: [PATCH v8 7/9] dax: add dax holder helper for filesystems
On Wed, Dec 15, 2021 at 10:21:00AM +0800, Shiyang Ruan wrote: > > > 在 2021/12/14 23:47, Christoph Hellwig 写道: > > On Thu, Dec 02, 2021 at 04:48:54PM +0800, Shiyang Ruan wrote: > > > Add these helper functions, and export them for filesystem use. > > > > What is the point of adding these wrappers vs just calling the > > underlying functions? > > I added them so that they can be called in a friendly way, even if > CONFIG_DAX is off. Otherwise, we need #if IS_ENABLED(CONFIG_DAX) to wrap > them where they are called. No need for wrappers, you can stub out the underlying functions as well.
Re: [PATCH v8 7/9] dax: add dax holder helper for filesystems
在 2021/12/14 23:47, Christoph Hellwig 写道: On Thu, Dec 02, 2021 at 04:48:54PM +0800, Shiyang Ruan wrote: Add these helper functions, and export them for filesystem use. What is the point of adding these wrappers vs just calling the underlying functions? I added them so that they can be called in a friendly way, even if CONFIG_DAX is off. Otherwise, we need #if IS_ENABLED(CONFIG_DAX) to wrap them where they are called. -- Thanks, Ruan.
Re: [PATCH v8 7/9] dax: add dax holder helper for filesystems
On Thu, Dec 02, 2021 at 04:48:54PM +0800, Shiyang Ruan wrote: > Add these helper functions, and export them for filesystem use. What is the point of adding these wrappers vs just calling the underlying functions?