Re: [PATCHv2] x86/boot/KASLR: skip the specified crashkernel reserved region

2019-03-29 Thread Baoquan He
On 03/29/19 at 06:00pm, Pingfan Liu wrote: > On Fri, Mar 29, 2019 at 3:34 PM Baoquan He wrote: > > > > On 03/29/19 at 03:25pm, Pingfan Liu wrote: > > > On Fri, Mar 29, 2019 at 2:27 PM Baoquan He wrote: > > > > > > > > On 03/29/19 at 01:45pm, Pingfan Liu wrote: > > > > > On Fri, Mar 22, 2019 at

Re: [PATCHv2] x86/boot/KASLR: skip the specified crashkernel reserved region

2019-03-29 Thread Pingfan Liu
On Fri, Mar 29, 2019 at 3:34 PM Baoquan He wrote: > > On 03/29/19 at 03:25pm, Pingfan Liu wrote: > > On Fri, Mar 29, 2019 at 2:27 PM Baoquan He wrote: > > > > > > On 03/29/19 at 01:45pm, Pingfan Liu wrote: > > > > On Fri, Mar 22, 2019 at 4:34 PM Baoquan He wrote: > > > > > > > > > > On 03/22/19

Re: [PATCHv2] x86/boot/KASLR: skip the specified crashkernel reserved region

2019-03-29 Thread Baoquan He
On 03/29/19 at 03:25pm, Pingfan Liu wrote: > On Fri, Mar 29, 2019 at 2:27 PM Baoquan He wrote: > > > > On 03/29/19 at 01:45pm, Pingfan Liu wrote: > > > On Fri, Mar 22, 2019 at 4:34 PM Baoquan He wrote: > > > > > > > > On 03/22/19 at 03:52pm, Baoquan He wrote: > > > > > On 03/22/19 at 03:43pm,

Re: [PATCHv2] x86/boot/KASLR: skip the specified crashkernel reserved region

2019-03-29 Thread Pingfan Liu
On Fri, Mar 29, 2019 at 2:27 PM Baoquan He wrote: > > On 03/29/19 at 01:45pm, Pingfan Liu wrote: > > On Fri, Mar 22, 2019 at 4:34 PM Baoquan He wrote: > > > > > > On 03/22/19 at 03:52pm, Baoquan He wrote: > > > > On 03/22/19 at 03:43pm, Pingfan Liu wrote: > > > > > > > +/* parse crashkernel=x@y

Re: [PATCHv2] x86/boot/KASLR: skip the specified crashkernel reserved region

2019-03-29 Thread Baoquan He
On 03/29/19 at 01:45pm, Pingfan Liu wrote: > On Fri, Mar 22, 2019 at 4:34 PM Baoquan He wrote: > > > > On 03/22/19 at 03:52pm, Baoquan He wrote: > > > On 03/22/19 at 03:43pm, Pingfan Liu wrote: > > > > > > +/* parse crashkernel=x@y option */ > > > > > > +static void

Re: [PATCHv2] x86/boot/KASLR: skip the specified crashkernel reserved region

2019-03-28 Thread Pingfan Liu
On Fri, Mar 22, 2019 at 4:34 PM Baoquan He wrote: > > On 03/22/19 at 03:52pm, Baoquan He wrote: > > On 03/22/19 at 03:43pm, Pingfan Liu wrote: > > > > > +/* parse crashkernel=x@y option */ > > > > > +static void mem_avoid_crashkernel_simple(char *option) > > > > > > > > Chao ever mentioned this,

Re: [PATCHv2] x86/boot/KASLR: skip the specified crashkernel reserved region

2019-03-24 Thread Pingfan Liu
On Fri, Mar 22, 2019 at 4:34 PM Baoquan He wrote: > > On 03/22/19 at 03:52pm, Baoquan He wrote: > > On 03/22/19 at 03:43pm, Pingfan Liu wrote: > > > > > +/* parse crashkernel=x@y option */ > > > > > +static void mem_avoid_crashkernel_simple(char *option) > > > > > > > > Chao ever mentioned this,

Re: [PATCHv2] x86/boot/KASLR: skip the specified crashkernel reserved region

2019-03-22 Thread Baoquan He
On 03/22/19 at 03:52pm, Baoquan He wrote: > On 03/22/19 at 03:43pm, Pingfan Liu wrote: > > > > +/* parse crashkernel=x@y option */ > > > > +static void mem_avoid_crashkernel_simple(char *option) > > > > > > Chao ever mentioned this, I want to ask again, why does it has to be > > > xxx_simple()? >

Re: [PATCHv2] x86/boot/KASLR: skip the specified crashkernel reserved region

2019-03-22 Thread Baoquan He
On 03/22/19 at 03:43pm, Pingfan Liu wrote: > > > +/* parse crashkernel=x@y option */ > > > +static void mem_avoid_crashkernel_simple(char *option) > > > > Chao ever mentioned this, I want to ask again, why does it has to be > > xxx_simple()? > > > Seems that I had replied Chao's question in

Re: [PATCHv2] x86/boot/KASLR: skip the specified crashkernel reserved region

2019-03-22 Thread Pingfan Liu
On Thu, Mar 21, 2019 at 2:38 PM Chao Fan wrote: > > On Wed, Mar 13, 2019 at 12:19:31PM +0800, Pingfan Liu wrote: > > I tested it in Qemu test with 12G memory, and set crashkernel=6G@6G. > Without this PATCH, it successed to reserve memory just 4 times(total > 10 times). > With this PATCH, it

Re: [PATCHv2] x86/boot/KASLR: skip the specified crashkernel reserved region

2019-03-22 Thread Pingfan Liu
On Wed, Mar 20, 2019 at 8:25 AM Baoquan He wrote: > > Please change subject as: > > "x86/boot/KASLR: skip the specified crashkernel region" > OK. > Don't see why reserved is needed here. > > On 03/13/19 at 12:19pm, Pingfan Liu wrote: > > crashkernel=x@y option may fail to reserve the required

Re: [PATCHv2] x86/boot/KASLR: skip the specified crashkernel reserved region

2019-03-21 Thread Chao Fan
On Wed, Mar 13, 2019 at 12:19:31PM +0800, Pingfan Liu wrote: I tested it in Qemu test with 12G memory, and set crashkernel=6G@6G. Without this PATCH, it successed to reserve memory just 4 times(total 10 times). With this PATCH, it successed to reserve memory 15 times(total 15 times). So I think

Re: [PATCHv2] x86/boot/KASLR: skip the specified crashkernel reserved region

2019-03-19 Thread Chao Fan
On Wed, Mar 13, 2019 at 12:19:31PM +0800, Pingfan Liu wrote: Hi Pingfan, I wonder your test method and test case. Do you test it in the Qemu guest or real machine. Thanks, Chao Fan >crashkernel=x@y option may fail to reserve the required memory region if >KASLR puts kernel into the region. To

Re: [PATCHv2] x86/boot/KASLR: skip the specified crashkernel reserved region

2019-03-19 Thread Baoquan He
Please change subject as: "x86/boot/KASLR: skip the specified crashkernel region" Don't see why reserved is needed here. On 03/13/19 at 12:19pm, Pingfan Liu wrote: > crashkernel=x@y option may fail to reserve the required memory region if > KASLR puts kernel into the region. To avoid this