Re: [PATCHv3 2/2] dt-bindings: arm: coresight: Add support to skip trace unit power up

2020-05-28 Thread Rob Herring
On Fri, 15 May 2020 21:52:33 +0530, Sai Prakash Ranjan wrote:
> From: Tingwei Zhang 
> 
> Add "qcom,skip-power-up" property to identify systems which can
> skip powering up of trace unit since they share the same power
> domain as their CPU core. This is required to identify such
> systems with hardware errata which stops the CPU watchdog counter
> when the power up bit is set (TRCPDCR.PU).
> 
> Signed-off-by: Tingwei Zhang 
> Co-developed-by: Sai Prakash Ranjan 
> Signed-off-by: Sai Prakash Ranjan 
> ---
>  Documentation/devicetree/bindings/arm/coresight.txt | 7 +++
>  1 file changed, 7 insertions(+)
> 

Reviewed-by: Rob Herring 


Re: [PATCHv3 2/2] dt-bindings: arm: coresight: Add support to skip trace unit power up

2020-05-21 Thread Mathieu Poirier
On Fri, 15 May 2020 at 10:23, Sai Prakash Ranjan
 wrote:
>
> From: Tingwei Zhang 
>
> Add "qcom,skip-power-up" property to identify systems which can
> skip powering up of trace unit since they share the same power
> domain as their CPU core. This is required to identify such
> systems with hardware errata which stops the CPU watchdog counter
> when the power up bit is set (TRCPDCR.PU).
>
> Signed-off-by: Tingwei Zhang 
> Co-developed-by: Sai Prakash Ranjan 
> Signed-off-by: Sai Prakash Ranjan 
> ---
>  Documentation/devicetree/bindings/arm/coresight.txt | 7 +++
>  1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/coresight.txt 
> b/Documentation/devicetree/bindings/arm/coresight.txt
> index 846f6daae71b..e4b2eda0b53b 100644
> --- a/Documentation/devicetree/bindings/arm/coresight.txt
> +++ b/Documentation/devicetree/bindings/arm/coresight.txt
> @@ -108,6 +108,13 @@ its hardware characteristcs.
> * arm,cp14: must be present if the system accesses ETM/PTM management
>   registers via co-processor 14.
>
> +   * qcom,skip-power-up: boolean. Indicates that an implementation can
> + skip powering up the trace unit. TRCPDCR.PU does not have to be set
> + on Qualcomm Technologies Inc. systems since ETMs are in the same 
> power
> + domain as their CPU cores. This property is required to identify 
> such
> + systems with hardware errata where the CPU watchdog counter is 
> stopped
> + when TRCPDCR.PU is set.
> +
>  * Optional property for TMC:

Reviewed-by: Mathieu Poirier 

>
> * arm,buffer-size: size of contiguous buffer space for TMC ETR
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation