Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

Hi, On Wed, Jul 25, 2018 at 07:48:21AM +1000, NeilBrown wrote: > On Tue, Jul 24 2018, Brian Norris wrote: > > On Tue, Jul 24, 2018 at 11:51:49AM +1000, NeilBrown wrote: > >> On Tue, Jul 24 2018, Boris Brezillon wrote: > >> > On Tue, 24 Jul 2018 08:46:33 +1000 > >> > NeilBrown wrote: > >> >> One

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

Hi, On Wed, Jul 25, 2018 at 07:48:21AM +1000, NeilBrown wrote: > On Tue, Jul 24 2018, Brian Norris wrote: > > On Tue, Jul 24, 2018 at 11:51:49AM +1000, NeilBrown wrote: > >> On Tue, Jul 24 2018, Boris Brezillon wrote: > >> > On Tue, 24 Jul 2018 08:46:33 +1000 > >> > NeilBrown wrote: > >> >> One

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

On Tue, Jul 24 2018, Brian Norris wrote: > Hi, > > On Tue, Jul 24, 2018 at 11:51:49AM +1000, NeilBrown wrote: >> On Tue, Jul 24 2018, Boris Brezillon wrote: >> > On Tue, 24 Jul 2018 08:46:33 +1000 >> > NeilBrown wrote: >> >> One possibility that occurred to me when I was exploring this issue is

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

On Tue, Jul 24 2018, Brian Norris wrote: > Hi, > > On Tue, Jul 24, 2018 at 11:51:49AM +1000, NeilBrown wrote: >> On Tue, Jul 24 2018, Boris Brezillon wrote: >> > On Tue, 24 Jul 2018 08:46:33 +1000 >> > NeilBrown wrote: >> >> One possibility that occurred to me when I was exploring this issue is

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

On Tue, 24 Jul 2018 12:52:02 -0700 Brian Norris wrote: > > > Or even better: put this hack behind a DT flag, so that one has to > > > admit that their board design is broken before it will even do > > > anything. Proposal: "linux,badly-designed-flash-reset". > > > > I think we can remove the

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

On Tue, 24 Jul 2018 12:52:02 -0700 Brian Norris wrote: > > > Or even better: put this hack behind a DT flag, so that one has to > > > admit that their board design is broken before it will even do > > > anything. Proposal: "linux,badly-designed-flash-reset". > > > > I think we can remove the

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

Hi Boris, On Tue, Jul 24, 2018 at 01:18:11AM +0200, Boris Brezillon wrote: > On Mon, 23 Jul 2018 15:06:43 -0700 > Brian Norris wrote: > > On Mon, Jul 23, 2018 at 1:10 PM, Boris Brezillon > > wrote: > > > but it still seems to improve things. Of course, that means the > > > user should try to

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

Hi Boris, On Tue, Jul 24, 2018 at 01:18:11AM +0200, Boris Brezillon wrote: > On Mon, 23 Jul 2018 15:06:43 -0700 > Brian Norris wrote: > > On Mon, Jul 23, 2018 at 1:10 PM, Boris Brezillon > > wrote: > > > but it still seems to improve things. Of course, that means the > > > user should try to

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

Hi, On Tue, Jul 24, 2018 at 11:51:49AM +1000, NeilBrown wrote: > On Tue, Jul 24 2018, Boris Brezillon wrote: > > On Tue, 24 Jul 2018 08:46:33 +1000 > > NeilBrown wrote: > >> One possibility that occurred to me when I was exploring this issue is > >> to revert to 3-byte mode whenever 4-byte was

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

Hi, On Tue, Jul 24, 2018 at 11:51:49AM +1000, NeilBrown wrote: > On Tue, Jul 24 2018, Boris Brezillon wrote: > > On Tue, 24 Jul 2018 08:46:33 +1000 > > NeilBrown wrote: > >> One possibility that occurred to me when I was exploring this issue is > >> to revert to 3-byte mode whenever 4-byte was

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

On Tue, Jul 24 2018, Boris Brezillon wrote: > On Tue, 24 Jul 2018 08:46:33 +1000 > NeilBrown wrote: > >> On Mon, Jul 23 2018, Brian Norris wrote: >> >> > Hi Boris, >> > >> > On Mon, Jul 23, 2018 at 1:10 PM, Boris Brezillon >> > wrote: >> >> On Mon, 23 Jul 2018 11:13:50 -0700 >> >> Brian

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

On Tue, Jul 24 2018, Boris Brezillon wrote: > On Tue, 24 Jul 2018 08:46:33 +1000 > NeilBrown wrote: > >> On Mon, Jul 23 2018, Brian Norris wrote: >> >> > Hi Boris, >> > >> > On Mon, Jul 23, 2018 at 1:10 PM, Boris Brezillon >> > wrote: >> >> On Mon, 23 Jul 2018 11:13:50 -0700 >> >> Brian

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

On Tue, 24 Jul 2018 08:46:33 +1000 NeilBrown wrote: > On Mon, Jul 23 2018, Brian Norris wrote: > > > Hi Boris, > > > > On Mon, Jul 23, 2018 at 1:10 PM, Boris Brezillon > > wrote: > >> On Mon, 23 Jul 2018 11:13:50 -0700 > >> Brian Norris wrote: > >>> I noticed this got merged, but I wanted

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

On Tue, 24 Jul 2018 08:46:33 +1000 NeilBrown wrote: > On Mon, Jul 23 2018, Brian Norris wrote: > > > Hi Boris, > > > > On Mon, Jul 23, 2018 at 1:10 PM, Boris Brezillon > > wrote: > >> On Mon, 23 Jul 2018 11:13:50 -0700 > >> Brian Norris wrote: > >>> I noticed this got merged, but I wanted

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

+Neil On Mon, 23 Jul 2018 15:06:43 -0700 Brian Norris wrote: > Hi Boris, > > On Mon, Jul 23, 2018 at 1:10 PM, Boris Brezillon > wrote: > > On Mon, 23 Jul 2018 11:13:50 -0700 > > Brian Norris wrote: > >> I noticed this got merged, but I wanted to put my 2 cents in here: > > > > I wish you

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

+Neil On Mon, 23 Jul 2018 15:06:43 -0700 Brian Norris wrote: > Hi Boris, > > On Mon, Jul 23, 2018 at 1:10 PM, Boris Brezillon > wrote: > > On Mon, 23 Jul 2018 11:13:50 -0700 > > Brian Norris wrote: > >> I noticed this got merged, but I wanted to put my 2 cents in here: > > > > I wish you

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

On Mon, Jul 23 2018, Brian Norris wrote: > Hi Boris, > > On Mon, Jul 23, 2018 at 1:10 PM, Boris Brezillon > wrote: >> On Mon, 23 Jul 2018 11:13:50 -0700 >> Brian Norris wrote: >>> I noticed this got merged, but I wanted to put my 2 cents in here: >> >> I wish you had replied to this thread when

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

On Mon, Jul 23 2018, Brian Norris wrote: > Hi Boris, > > On Mon, Jul 23, 2018 at 1:10 PM, Boris Brezillon > wrote: >> On Mon, 23 Jul 2018 11:13:50 -0700 >> Brian Norris wrote: >>> I noticed this got merged, but I wanted to put my 2 cents in here: >> >> I wish you had replied to this thread when

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

Hi Boris, On Mon, Jul 23, 2018 at 1:10 PM, Boris Brezillon wrote: > On Mon, 23 Jul 2018 11:13:50 -0700 > Brian Norris wrote: >> I noticed this got merged, but I wanted to put my 2 cents in here: > > I wish you had replied to this thread when it was posted (more than > 6 months ago). Reverting

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

Hi Boris, On Mon, Jul 23, 2018 at 1:10 PM, Boris Brezillon wrote: > On Mon, 23 Jul 2018 11:13:50 -0700 > Brian Norris wrote: >> I noticed this got merged, but I wanted to put my 2 cents in here: > > I wish you had replied to this thread when it was posted (more than > 6 months ago). Reverting

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

Hi Brian, On Mon, 23 Jul 2018 11:13:50 -0700 Brian Norris wrote: > Hello, > > I noticed this got merged, but I wanted to put my 2 cents in here: I wish you had replied to this thread when it was posted (more than 6 months ago). Reverting the patch now implies making some people unhappy

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

Hi Brian, On Mon, 23 Jul 2018 11:13:50 -0700 Brian Norris wrote: > Hello, > > I noticed this got merged, but I wanted to put my 2 cents in here: I wish you had replied to this thread when it was posted (more than 6 months ago). Reverting the patch now implies making some people unhappy

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

Hello, I noticed this got merged, but I wanted to put my 2 cents in here: On Wed, Dec 06, 2017 at 10:53:42AM +0800, Zhiqiang Hou wrote: > From: Hou Zhiqiang > > Restore the status to be compatible with legacy devices. > Take Freescale eSPI boot for example, it copies (in 3 Byte > addressing

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

Hello, I noticed this got merged, but I wanted to put my 2 cents in here: On Wed, Dec 06, 2017 at 10:53:42AM +0800, Zhiqiang Hou wrote: > From: Hou Zhiqiang > > Restore the status to be compatible with legacy devices. > Take Freescale eSPI boot for example, it copies (in 3 Byte > addressing

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

Le 06/12/2017 à 03:53, Zhiqiang Hou a écrit : > From: Hou Zhiqiang > > Restore the status to be compatible with legacy devices. > Take Freescale eSPI boot for example, it copies (in 3 Byte > addressing mode) the RCW and bootloader images from SPI flash > without firing a

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

Le 06/12/2017 à 03:53, Zhiqiang Hou a écrit : > From: Hou Zhiqiang > > Restore the status to be compatible with legacy devices. > Take Freescale eSPI boot for example, it copies (in 3 Byte > addressing mode) the RCW and bootloader images from SPI flash > without firing a reset signal previously,