Re: [PATCHv4 2/4] ASoC: codec: cpcap: new codec

2018-02-23 Thread Sebastian Reichel
Hi, On Fri, Feb 23, 2018 at 09:07:14AM +0100, Pavel Machek wrote: > On Fri 2018-02-16 14:27:16, Mark Brown wrote: > > On Fri, Feb 16, 2018 at 02:51:13PM +0100, Sebastian Reichel wrote: > > > On Fri, Feb 16, 2018 at 11:39:01AM +, Mark Brown wrote: > > > > > > We don't have default lines like t

Re: [PATCHv4 2/4] ASoC: codec: cpcap: new codec

2018-02-23 Thread Pavel Machek
On Fri 2018-02-16 14:27:16, Mark Brown wrote: > On Fri, Feb 16, 2018 at 02:51:13PM +0100, Sebastian Reichel wrote: > > On Fri, Feb 16, 2018 at 11:39:01AM +, Mark Brown wrote: > > > > We don't have default lines like this for other MFDs... > > > Is there a reason not to add them? It looks very

Re: [PATCHv4 2/4] ASoC: codec: cpcap: new codec

2018-02-16 Thread Mark Brown
On Fri, Feb 16, 2018 at 02:51:13PM +0100, Sebastian Reichel wrote: > On Fri, Feb 16, 2018 at 11:39:01AM +, Mark Brown wrote: > > We don't have default lines like this for other MFDs... > Is there a reason not to add them? It looks very useful to me: Consistency. It's a lot easier to apply a

Re: [PATCHv4 2/4] ASoC: codec: cpcap: new codec

2018-02-16 Thread Sebastian Reichel
Hi Mark, On Fri, Feb 16, 2018 at 11:39:01AM +, Mark Brown wrote: > On Wed, Feb 14, 2018 at 11:07:39PM +0100, Sebastian Reichel wrote: > > > +config SND_SOC_CPCAP > > + tristate "Motorola CPCAP codec" > > + depends on MFD_CPCAP > > + default MFD_CPCAP > > + > > We don't have default lin

Re: [PATCHv4 2/4] ASoC: codec: cpcap: new codec

2018-02-16 Thread Sebastian Reichel
Hi Philippe, On Thu, Feb 15, 2018 at 10:50:22AM +0100, Philippe Ombredanne wrote: > Dear Sebastian, > > On Wed, Feb 14, 2018 at 11:07 PM, Sebastian Reichel > wrote: > > Motorola CPCAP is a PMIC with audio functionality, that can be > > found on Motorola Droid 4 and probably a few other phones fr

Re: [PATCHv4 2/4] ASoC: codec: cpcap: new codec

2018-02-16 Thread Mark Brown
On Wed, Feb 14, 2018 at 11:07:39PM +0100, Sebastian Reichel wrote: > +config SND_SOC_CPCAP > + tristate "Motorola CPCAP codec" > + depends on MFD_CPCAP > + default MFD_CPCAP > + We don't have default lines like this for other MFDs... > + SOC_ENUM("Hifi Left Phase Playback Switch"

Re: [PATCHv4 2/4] ASoC: codec: cpcap: new codec

2018-02-15 Thread Philippe Ombredanne
Dear Sebastian, On Wed, Feb 14, 2018 at 11:07 PM, Sebastian Reichel wrote: > Motorola CPCAP is a PMIC with audio functionality, that can be > found on Motorola Droid 4 and probably a few other phones from > Motorola's Droid series. > > The driver has been written from scratch using Motorola's And