Re: [RFC/RFT] [PATCH 02/10] cpufreq: intel_pstate: Conditional frequency invariant accounting

2018-05-30 Thread Patrick Bellasi
Hi Peter, maybe you missed this previous my response: 20180518133353.GO30654@e110439-lin ? Would like to have your tought about the concept of "transient maximum capacity" I was describing... On 18-May 14:33, Patrick Bellasi wrote: > On 18-May 13:29, Peter Zijlstra wrote: > > On Fri, May 18, 2

Re: [RFC/RFT] [PATCH 02/10] cpufreq: intel_pstate: Conditional frequency invariant accounting

2018-05-18 Thread Valentin Schneider
Hi, On 18/05/18 12:29, Peter Zijlstra wrote: > On Fri, May 18, 2018 at 11:57:42AM +0100, Patrick Bellasi wrote: >> Thus, my simple (maybe dumb) questions are: >> - why can't we just fold turbo boost frequency into the existing concepts? >> - what are the limitations of such a "simple" approach? >

Re: [RFC/RFT] [PATCH 02/10] cpufreq: intel_pstate: Conditional frequency invariant accounting

2018-05-18 Thread Patrick Bellasi
On 18-May 13:29, Peter Zijlstra wrote: > On Fri, May 18, 2018 at 11:57:42AM +0100, Patrick Bellasi wrote: > > Thus, my simple (maybe dumb) questions are: > > - why can't we just fold turbo boost frequency into the existing concepts? > > - what are the limitations of such a "simple" approach? > > P

Re: [RFC/RFT] [PATCH 02/10] cpufreq: intel_pstate: Conditional frequency invariant accounting

2018-05-18 Thread Peter Zijlstra
On Fri, May 18, 2018 at 11:57:42AM +0100, Patrick Bellasi wrote: > Thus, my simple (maybe dumb) questions are: > - why can't we just fold turbo boost frequency into the existing concepts? > - what are the limitations of such a "simple" approach? Perhaps... but does this not further complicate the

Re: [RFC/RFT] [PATCH 02/10] cpufreq: intel_pstate: Conditional frequency invariant accounting

2018-05-18 Thread Patrick Bellasi
On 17-May 20:28, Peter Zijlstra wrote: > On Thu, May 17, 2018 at 06:56:37PM +0200, Rafael J. Wysocki wrote: > > On Thu, May 17, 2018 at 6:42 PM, Srinivas Pandruvada > > > > What will happen if we look at all core turbo as max and cap any > > > utilization above this to 1024? > > > > I was going t

Re: [RFC/RFT] [PATCH 02/10] cpufreq: intel_pstate: Conditional frequency invariant accounting

2018-05-18 Thread Rafael J. Wysocki
On Thu, May 17, 2018 at 8:28 PM, Peter Zijlstra wrote: > On Thu, May 17, 2018 at 06:56:37PM +0200, Rafael J. Wysocki wrote: >> On Thu, May 17, 2018 at 6:42 PM, Srinivas Pandruvada > >> > What will happen if we look at all core turbo as max and cap any >> > utilization above this to 1024? >> >> I w

Re: [RFC/RFT] [PATCH 02/10] cpufreq: intel_pstate: Conditional frequency invariant accounting

2018-05-17 Thread Peter Zijlstra
On Thu, May 17, 2018 at 06:56:37PM +0200, Rafael J. Wysocki wrote: > On Thu, May 17, 2018 at 6:42 PM, Srinivas Pandruvada > > What will happen if we look at all core turbo as max and cap any > > utilization above this to 1024? > > I was going to suggest that. To the basic premise behind all our

Re: [RFC/RFT] [PATCH 02/10] cpufreq: intel_pstate: Conditional frequency invariant accounting

2018-05-17 Thread Rafael J. Wysocki
On Thu, May 17, 2018 at 6:42 PM, Srinivas Pandruvada wrote: > On Thu, 2018-05-17 at 18:16 +0200, Peter Zijlstra wrote: >> On Thu, May 17, 2018 at 08:41:32AM -0700, Srinivas Pandruvada wrote: >> > One more point to note. Even if we calculate some utilization based >> > on >> > the freq-invariant an

Re: [RFC/RFT] [PATCH 02/10] cpufreq: intel_pstate: Conditional frequency invariant accounting

2018-05-17 Thread Srinivas Pandruvada
On Thu, 2018-05-17 at 18:16 +0200, Peter Zijlstra wrote: > On Thu, May 17, 2018 at 08:41:32AM -0700, Srinivas Pandruvada wrote: > > One more point to note. Even if we calculate some utilization based > > on > > the freq-invariant and arrive at a P-state, we will not be able to > > control any P-sta

Re: [RFC/RFT] [PATCH 02/10] cpufreq: intel_pstate: Conditional frequency invariant accounting

2018-05-17 Thread Peter Zijlstra
On Thu, May 17, 2018 at 08:41:32AM -0700, Srinivas Pandruvada wrote: > One more point to note. Even if we calculate some utilization based on > the freq-invariant and arrive at a P-state, we will not be able to > control any P-state in turbo region (not even as a cap) on several > Intel processors

Re: [RFC/RFT] [PATCH 02/10] cpufreq: intel_pstate: Conditional frequency invariant accounting

2018-05-17 Thread Srinivas Pandruvada
On Thu, 2018-05-17 at 17:04 +0200, Juri Lelli wrote: > On 17/05/18 12:59, Juri Lelli wrote: > > On 16/05/18 18:31, Juri Lelli wrote: > > > On 16/05/18 17:47, Peter Zijlstra wrote: > > > > On Wed, May 16, 2018 at 05:19:25PM +0200, Juri Lelli wrote: > > > > > > > > > Anyway, FWIW I started testing t

Re: [RFC/RFT] [PATCH 02/10] cpufreq: intel_pstate: Conditional frequency invariant accounting

2018-05-17 Thread Juri Lelli
On 17/05/18 12:59, Juri Lelli wrote: > On 16/05/18 18:31, Juri Lelli wrote: > > On 16/05/18 17:47, Peter Zijlstra wrote: > > > On Wed, May 16, 2018 at 05:19:25PM +0200, Juri Lelli wrote: > > > > > > > Anyway, FWIW I started testing this on a E5-2609 v3 and I'm not seeing > > > > hackbench regressi

Re: [RFC/RFT] [PATCH 02/10] cpufreq: intel_pstate: Conditional frequency invariant accounting

2018-05-17 Thread Juri Lelli
On 16/05/18 18:31, Juri Lelli wrote: > On 16/05/18 17:47, Peter Zijlstra wrote: > > On Wed, May 16, 2018 at 05:19:25PM +0200, Juri Lelli wrote: > > > > > Anyway, FWIW I started testing this on a E5-2609 v3 and I'm not seeing > > > hackbench regressions so far (running with schedutil governor). > >

Re: [RFC/RFT] [PATCH 02/10] cpufreq: intel_pstate: Conditional frequency invariant accounting

2018-05-16 Thread Srinivas Pandruvada
On Wed, 2018-05-16 at 11:07 +0200, Rafael J. Wysocki wrote: > On Wed, May 16, 2018 at 9:29 AM, Peter Zijlstra > wrote: > > On Wed, May 16, 2018 at 09:16:40AM +0200, Peter Zijlstra wrote: > > > On Tue, May 15, 2018 at 09:49:03PM -0700, Srinivas Pandruvada > > > wrote: > > > > intel_pstate has two o

Re: [RFC/RFT] [PATCH 02/10] cpufreq: intel_pstate: Conditional frequency invariant accounting

2018-05-16 Thread Juri Lelli
On 16/05/18 17:47, Peter Zijlstra wrote: > On Wed, May 16, 2018 at 05:19:25PM +0200, Juri Lelli wrote: > > > Anyway, FWIW I started testing this on a E5-2609 v3 and I'm not seeing > > hackbench regressions so far (running with schedutil governor). > > https://en.wikipedia.org/wiki/Haswell_(microa

Re: [RFC/RFT] [PATCH 02/10] cpufreq: intel_pstate: Conditional frequency invariant accounting

2018-05-16 Thread Srinivas Pandruvada
On Wed, 2018-05-16 at 17:19 +0200, Juri Lelli wrote: > On 15/05/18 21:49, Srinivas Pandruvada wrote: > > intel_pstate has two operating modes: active and passive. In > > "active" > > mode, the in-built scaling governor is used and in "passive" mode, > > the driver can be used with any governor like

Re: [RFC/RFT] [PATCH 02/10] cpufreq: intel_pstate: Conditional frequency invariant accounting

2018-05-16 Thread Peter Zijlstra
On Wed, May 16, 2018 at 05:19:25PM +0200, Juri Lelli wrote: > Anyway, FWIW I started testing this on a E5-2609 v3 and I'm not seeing > hackbench regressions so far (running with schedutil governor). https://en.wikipedia.org/wiki/Haswell_(microarchitecture)#Server_processors Lists the E5 2609 v3

Re: [RFC/RFT] [PATCH 02/10] cpufreq: intel_pstate: Conditional frequency invariant accounting

2018-05-16 Thread Juri Lelli
On 15/05/18 21:49, Srinivas Pandruvada wrote: > intel_pstate has two operating modes: active and passive. In "active" > mode, the in-built scaling governor is used and in "passive" mode, > the driver can be used with any governor like "schedutil". In "active" > mode the utilization values from sche

Re: [RFC/RFT] [PATCH 02/10] cpufreq: intel_pstate: Conditional frequency invariant accounting

2018-05-16 Thread Rafael J. Wysocki
On Wed, May 16, 2018 at 9:29 AM, Peter Zijlstra wrote: > On Wed, May 16, 2018 at 09:16:40AM +0200, Peter Zijlstra wrote: >> On Tue, May 15, 2018 at 09:49:03PM -0700, Srinivas Pandruvada wrote: >> > intel_pstate has two operating modes: active and passive. In "active" >> > mode, the in-built scalin

Re: [RFC/RFT] [PATCH 02/10] cpufreq: intel_pstate: Conditional frequency invariant accounting

2018-05-16 Thread Peter Zijlstra
On Wed, May 16, 2018 at 09:16:40AM +0200, Peter Zijlstra wrote: > On Tue, May 15, 2018 at 09:49:03PM -0700, Srinivas Pandruvada wrote: > > intel_pstate has two operating modes: active and passive. In "active" > > mode, the in-built scaling governor is used and in "passive" mode, > > the driver can

Re: [RFC/RFT] [PATCH 02/10] cpufreq: intel_pstate: Conditional frequency invariant accounting

2018-05-16 Thread Peter Zijlstra
On Tue, May 15, 2018 at 09:49:03PM -0700, Srinivas Pandruvada wrote: > intel_pstate has two operating modes: active and passive. In "active" > mode, the in-built scaling governor is used and in "passive" mode, > the driver can be used with any governor like "schedutil". In "active" > mode the utili