Re: [RFC][PATCHv4 4/6] printk: report lost messages in printk safe/nmi contexts

2016-12-01 Thread Petr Mladek
On Thu 2016-12-01 11:10:42, Sergey Senozhatsky wrote: > On (11/25/16 12:07), Petr Mladek wrote: > [..] > > > +static void report_message_lost(atomic_t *num_lost, char *fmt) > > > +{ > > > + int lost = atomic_xchg(num_lost, 0); > > > + > > > + if (lost) { > > > + char msg[56]; > > > I would

Re: [RFC][PATCHv4 4/6] printk: report lost messages in printk safe/nmi contexts

2016-12-01 Thread Petr Mladek
On Thu 2016-12-01 11:10:42, Sergey Senozhatsky wrote: > On (11/25/16 12:07), Petr Mladek wrote: > [..] > > > +static void report_message_lost(atomic_t *num_lost, char *fmt) > > > +{ > > > + int lost = atomic_xchg(num_lost, 0); > > > + > > > + if (lost) { > > > + char msg[56]; > > > I would

Re: [RFC][PATCHv4 4/6] printk: report lost messages in printk safe/nmi contexts

2016-11-30 Thread Sergey Senozhatsky
On (11/25/16 12:07), Petr Mladek wrote: [..] > > +static void report_message_lost(atomic_t *num_lost, char *fmt) > > +{ > > + int lost = atomic_xchg(num_lost, 0); > > + > > + if (lost) { > > + char msg[56]; > > I would really like to avoid a hard coded buffer size. Such things > are

Re: [RFC][PATCHv4 4/6] printk: report lost messages in printk safe/nmi contexts

2016-11-30 Thread Sergey Senozhatsky
On (11/25/16 12:07), Petr Mladek wrote: [..] > > +static void report_message_lost(atomic_t *num_lost, char *fmt) > > +{ > > + int lost = atomic_xchg(num_lost, 0); > > + > > + if (lost) { > > + char msg[56]; > > I would really like to avoid a hard coded buffer size. Such things > are

Re: [RFC][PATCHv4 4/6] printk: report lost messages in printk safe/nmi contexts

2016-11-25 Thread Petr Mladek
On Fri 2016-10-28 00:49:31, Sergey Senozhatsky wrote: > Account lost messages in pritk-safe and printk-safe-nmi > contexts and report those numbers during printk_safe_flush(). > > Signed-off-by: Sergey Senozhatsky > --- > kernel/printk/internal.h| 17

Re: [RFC][PATCHv4 4/6] printk: report lost messages in printk safe/nmi contexts

2016-11-25 Thread Petr Mladek
On Fri 2016-10-28 00:49:31, Sergey Senozhatsky wrote: > Account lost messages in pritk-safe and printk-safe-nmi > contexts and report those numbers during printk_safe_flush(). > > Signed-off-by: Sergey Senozhatsky > --- > kernel/printk/internal.h| 17 --- >