Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-06-01 Thread Peter Ujfalusi
Hi Radhey, On 2018-05-30 20:29, Radhey Shyam Pandey wrote: >> In couple of days I can update the metadata patches I have atm and send >> as RFC. >> >> Is there anything from your side I should take into account when doing that? > I think a generic interface to attach/share metadata buffer b/w

Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-06-01 Thread Peter Ujfalusi
Hi Radhey, On 2018-05-30 20:29, Radhey Shyam Pandey wrote: >> In couple of days I can update the metadata patches I have atm and send >> as RFC. >> >> Is there anything from your side I should take into account when doing that? > I think a generic interface to attach/share metadata buffer b/w

RE: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-05-30 Thread Radhey Shyam Pandey
el.org; > dan.j.willi...@intel.com; Appana Durga Kedareswara Rao > ; linux-arm-ker...@lists.infradead.org > Subject: Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words > to netdev dma client > > Hi, > > On 2018-05-17 09:39, Radhey Shyam Pandey wrote: > >

RE: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-05-30 Thread Radhey Shyam Pandey
el.org; > dan.j.willi...@intel.com; Appana Durga Kedareswara Rao > ; linux-arm-ker...@lists.infradead.org > Subject: Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words > to netdev dma client > > Hi, > > On 2018-05-17 09:39, Radhey Shyam Pandey wrote: > >

Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-05-29 Thread Peter Ujfalusi
Hi, On 2018-05-17 09:39, Radhey Shyam Pandey wrote: >> Well, let's see where this is going to go when I can send the patches >> for review. > Thanks all. @Peter: If we have metadata patchset ready may be good > to send an RFC? Sorry for the delay, I got distracted by this:

Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-05-29 Thread Peter Ujfalusi
Hi, On 2018-05-17 09:39, Radhey Shyam Pandey wrote: >> Well, let's see where this is going to go when I can send the patches >> for review. > Thanks all. @Peter: If we have metadata patchset ready may be good > to send an RFC? Sorry for the delay, I got distracted by this:

RE: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-05-17 Thread Radhey Shyam Pandey
ichal.si...@xilinx.com; linux- > ker...@vger.kernel.org; dmaeng...@vger.kernel.org; > dan.j.willi...@intel.com; Appana Durga Kedareswara Rao > <appa...@xilinx.com>; linux-arm-ker...@lists.infradead.org > Subject: Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words >

RE: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-05-17 Thread Radhey Shyam Pandey
el.org; > dan.j.willi...@intel.com; Appana Durga Kedareswara Rao > ; linux-arm-ker...@lists.infradead.org > Subject: Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words > to netdev dma client > > On 2018-04-24 06:55, Vinod Koul wrote: > > On Thu, Apr 19, 2

Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-04-24 Thread Peter Ujfalusi
On 2018-04-24 06:55, Vinod Koul wrote: > On Thu, Apr 19, 2018 at 02:40:26PM +0300, Peter Ujfalusi wrote: >> >> On 2018-04-18 16:06, Lars-Peter Clausen wrote: Hrm, true, but it is hardly the metadata use case. It is more like different DMA transfer type. >>> >>> When I look at this with

Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-04-24 Thread Peter Ujfalusi
On 2018-04-24 06:55, Vinod Koul wrote: > On Thu, Apr 19, 2018 at 02:40:26PM +0300, Peter Ujfalusi wrote: >> >> On 2018-04-18 16:06, Lars-Peter Clausen wrote: Hrm, true, but it is hardly the metadata use case. It is more like different DMA transfer type. >>> >>> When I look at this with

Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-04-23 Thread Vinod Koul
On Thu, Apr 19, 2018 at 02:40:26PM +0300, Peter Ujfalusi wrote: > > On 2018-04-18 16:06, Lars-Peter Clausen wrote: > >> Hrm, true, but it is hardly the metadata use case. It is more like > >> different DMA transfer type. > > > > When I look at this with my astronaut architect view from high high

Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-04-23 Thread Vinod Koul
On Thu, Apr 19, 2018 at 02:40:26PM +0300, Peter Ujfalusi wrote: > > On 2018-04-18 16:06, Lars-Peter Clausen wrote: > >> Hrm, true, but it is hardly the metadata use case. It is more like > >> different DMA transfer type. > > > > When I look at this with my astronaut architect view from high high

Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-04-19 Thread Peter Ujfalusi
On 2018-04-18 16:06, Lars-Peter Clausen wrote: >> Hrm, true, but it is hardly the metadata use case. It is more like >> different DMA transfer type. > > When I look at this with my astronaut architect view from high high up above > I do not see a difference between metadata and multi-planar

Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-04-19 Thread Peter Ujfalusi
On 2018-04-18 16:06, Lars-Peter Clausen wrote: >> Hrm, true, but it is hardly the metadata use case. It is more like >> different DMA transfer type. > > When I look at this with my astronaut architect view from high high up above > I do not see a difference between metadata and multi-planar

Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-04-18 Thread Lars-Peter Clausen
On 04/18/2018 08:31 AM, Peter Ujfalusi wrote: > > On 2018-04-17 18:54, Lars-Peter Clausen wrote: >> On 04/17/2018 04:53 PM, Peter Ujfalusi wrote: >>> On 2018-04-17 16:58, Lars-Peter Clausen wrote: >> There are two options. >> >> Either you extend the generic interfaces so it can cover

Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-04-18 Thread Lars-Peter Clausen
On 04/18/2018 08:31 AM, Peter Ujfalusi wrote: > > On 2018-04-17 18:54, Lars-Peter Clausen wrote: >> On 04/17/2018 04:53 PM, Peter Ujfalusi wrote: >>> On 2018-04-17 16:58, Lars-Peter Clausen wrote: >> There are two options. >> >> Either you extend the generic interfaces so it can cover

Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-04-18 Thread Peter Ujfalusi
On 2018-04-18 09:39, Peter Ujfalusi wrote: > > > On 2018-04-17 18:42, Vinod Koul wrote: >> On Tue, Apr 17, 2018 at 04:46:43PM +0300, Peter Ujfalusi wrote: >> >>> @@ -709,6 +709,11 @@ struct dma_filter { >>> * be called after period_len bytes have been transferred. >>> *

Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-04-18 Thread Peter Ujfalusi
On 2018-04-18 09:39, Peter Ujfalusi wrote: > > > On 2018-04-17 18:42, Vinod Koul wrote: >> On Tue, Apr 17, 2018 at 04:46:43PM +0300, Peter Ujfalusi wrote: >> >>> @@ -709,6 +709,11 @@ struct dma_filter { >>> * be called after period_len bytes have been transferred. >>> *

Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-04-18 Thread Peter Ujfalusi
On 2018-04-17 18:42, Vinod Koul wrote: > On Tue, Apr 17, 2018 at 04:46:43PM +0300, Peter Ujfalusi wrote: > >> @@ -709,6 +709,11 @@ struct dma_filter { >> * be called after period_len bytes have been transferred. >> * @device_prep_interleaved_dma: Transfer expression in a generic way. >>

Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-04-18 Thread Peter Ujfalusi
On 2018-04-17 18:42, Vinod Koul wrote: > On Tue, Apr 17, 2018 at 04:46:43PM +0300, Peter Ujfalusi wrote: > >> @@ -709,6 +709,11 @@ struct dma_filter { >> * be called after period_len bytes have been transferred. >> * @device_prep_interleaved_dma: Transfer expression in a generic way. >>

Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-04-18 Thread Peter Ujfalusi
On 2018-04-17 18:54, Lars-Peter Clausen wrote: > On 04/17/2018 04:53 PM, Peter Ujfalusi wrote: >> On 2018-04-17 16:58, Lars-Peter Clausen wrote: > There are two options. > > Either you extend the generic interfaces so it can cover your usecase in a > generic way. E.g. the ability

Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-04-18 Thread Peter Ujfalusi
On 2018-04-17 18:54, Lars-Peter Clausen wrote: > On 04/17/2018 04:53 PM, Peter Ujfalusi wrote: >> On 2018-04-17 16:58, Lars-Peter Clausen wrote: > There are two options. > > Either you extend the generic interfaces so it can cover your usecase in a > generic way. E.g. the ability

Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-04-17 Thread Lars-Peter Clausen
On 04/17/2018 04:53 PM, Peter Ujfalusi wrote: > On 2018-04-17 16:58, Lars-Peter Clausen wrote: There are two options. Either you extend the generic interfaces so it can cover your usecase in a generic way. E.g. the ability to attach meta data to transfer. >>> >>> Fwiw I have

Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-04-17 Thread Lars-Peter Clausen
On 04/17/2018 04:53 PM, Peter Ujfalusi wrote: > On 2018-04-17 16:58, Lars-Peter Clausen wrote: There are two options. Either you extend the generic interfaces so it can cover your usecase in a generic way. E.g. the ability to attach meta data to transfer. >>> >>> Fwiw I have

Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-04-17 Thread Lars-Peter Clausen
On 04/17/2018 05:42 PM, Vinod Koul wrote: > On Tue, Apr 17, 2018 at 04:46:43PM +0300, Peter Ujfalusi wrote: > >> @@ -709,6 +709,11 @@ struct dma_filter { >> * be called after period_len bytes have been transferred. >> * @device_prep_interleaved_dma: Transfer expression in a generic way. >>

Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-04-17 Thread Lars-Peter Clausen
On 04/17/2018 05:42 PM, Vinod Koul wrote: > On Tue, Apr 17, 2018 at 04:46:43PM +0300, Peter Ujfalusi wrote: > >> @@ -709,6 +709,11 @@ struct dma_filter { >> * be called after period_len bytes have been transferred. >> * @device_prep_interleaved_dma: Transfer expression in a generic way. >>

Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-04-17 Thread Vinod Koul
On Tue, Apr 17, 2018 at 04:46:43PM +0300, Peter Ujfalusi wrote: > @@ -709,6 +709,11 @@ struct dma_filter { > * be called after period_len bytes have been transferred. > * @device_prep_interleaved_dma: Transfer expression in a generic way. > * @device_prep_dma_imm_data: DMA's 8 byte

Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-04-17 Thread Vinod Koul
On Tue, Apr 17, 2018 at 04:46:43PM +0300, Peter Ujfalusi wrote: > @@ -709,6 +709,11 @@ struct dma_filter { > * be called after period_len bytes have been transferred. > * @device_prep_interleaved_dma: Transfer expression in a generic way. > * @device_prep_dma_imm_data: DMA's 8 byte

Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-04-17 Thread Peter Ujfalusi
On 2018-04-17 16:58, Lars-Peter Clausen wrote: >>> There are two options. >>> >>> Either you extend the generic interfaces so it can cover your usecase in a >>> generic way. E.g. the ability to attach meta data to transfer. >> >> Fwiw I have this patch as part of a bigger work to achieve similar

Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-04-17 Thread Peter Ujfalusi
On 2018-04-17 16:58, Lars-Peter Clausen wrote: >>> There are two options. >>> >>> Either you extend the generic interfaces so it can cover your usecase in a >>> generic way. E.g. the ability to attach meta data to transfer. >> >> Fwiw I have this patch as part of a bigger work to achieve similar

Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-04-17 Thread Lars-Peter Clausen
gt;>>> <radh...@xilinx.com>; l...@metafoo.de; dmaeng...@vger.kernel.org; >>>> linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org >>>> Subject: Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control >>>> words

Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-04-17 Thread Lars-Peter Clausen
.kernel.org; >>>> linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org >>>> Subject: Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control >>>> words to netdev dma client >>>> >>>> On Mon, Apr 02, 2018 at

Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-04-17 Thread Peter Ujfalusi
>>> linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org >>> Subject: Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control >>> words to netdev dma client >>> >>> On Mon, Apr 02, 2018 at 04:09:02PM +0530, Radhey Sh

Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-04-17 Thread Peter Ujfalusi
t;> To: Radhey Shyam Pandey >>> Cc: dan.j.willi...@intel.com; michal.si...@xilinx.com; Appana Durga >>> Kedareswara Rao ; Radhey Shyam Pandey >>> ; l...@metafoo.de; dmaeng...@vger.kernel.org; >>> linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.o

Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-04-17 Thread Lars-Peter Clausen
illi...@intel.com; michal.si...@xilinx.com; Appana Durga >> Kedareswara Rao <appa...@xilinx.com>; Radhey Shyam Pandey >> <radh...@xilinx.com>; l...@metafoo.de; dmaeng...@vger.kernel.org; >> linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org >> S

Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-04-17 Thread Lars-Peter Clausen
ichal.si...@xilinx.com; Appana Durga >> Kedareswara Rao ; Radhey Shyam Pandey >> ; l...@metafoo.de; dmaeng...@vger.kernel.org; >> linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org >> Subject: Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control >> words t

RE: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-04-17 Thread Radhey Shyam Pandey
appa...@xilinx.com>; Radhey Shyam Pandey > <radh...@xilinx.com>; l...@metafoo.de; dmaeng...@vger.kernel.org; > linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org > Subject: Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control > words to netdev dma clie

RE: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-04-17 Thread Radhey Shyam Pandey
..@metafoo.de; dmaeng...@vger.kernel.org; > linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org > Subject: Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control > words to netdev dma client > > On Mon, Apr 02, 2018 at 04:09:02PM +0530, Radhey Shyam Pandey wrot

Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-04-11 Thread Vinod Koul
On Mon, Apr 02, 2018 at 04:09:02PM +0530, Radhey Shyam Pandey wrote: > + > + if (chan->xdev->has_axieth_connected) { > + seg = list_first_entry(>segments, > + struct xilinx_axidma_tx_segment, node); > + if

Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-04-11 Thread Vinod Koul
On Mon, Apr 02, 2018 at 04:09:02PM +0530, Radhey Shyam Pandey wrote: > + > + if (chan->xdev->has_axieth_connected) { > + seg = list_first_entry(>segments, > + struct xilinx_axidma_tx_segment, node); > + if